Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp414757ybm; Wed, 22 May 2019 05:31:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJ00JCfQE3jffRVaMXa/wrYO04IpgnYHeTAxxX+0ad2AqiHQUQB5lKXoB6n1d3oJykgw3A X-Received: by 2002:a63:e408:: with SMTP id a8mr2577582pgi.146.1558528262785; Wed, 22 May 2019 05:31:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558528262; cv=none; d=google.com; s=arc-20160816; b=wAzKfFsTinvAPaSlQo1vibe4RQtS0FdeG6C/Ro6trJq1A8rhaI6FMGUxoF6Hz5pnup OC0U7V068AAiSrBKL2Fai1UhyAV7hkG0pbdTFbskJqfGdslLPZkUcMYlMnogiiKtkUhJ iZkb1YGqKFbEbzXJ4fsHLc5KPXT6u2vpRSONhoUgb3wl/tMwNttz+ipEqw/tBfUmlvqm NOQAVliOMxWSfxCwesev3PsVNF1v3HHqbT3aMiKzaqv+hJjiHUspz/8viPAV/KZ/QBsa JAF0sCPeWqP2cNj7Y9ovbz7eR8avwLZx75EM8++Q+koxOg+1uDxjHLcTv46v5FiMolbm jP9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=eD9swnpgzU09oy8QbmHLU+ZgDlxKTOnileR3ZPD24Hs=; b=Vcv8eZKDKMlzZlDVHv4eCw7JRA29sRvqgz9l4OgMPfmcqz9HgoJToMOYj3UyCoXIjF wCtkyA5QrHL8wQLAxNZX8Zm+pd8Dg0Kf/R8/MaXQZsHwIzd3PWzZ9Gh4XHOdSsZsEZEB k95AeLsbNOKnpnOncPp5fiOOPY1y8DjpR9J2dCzbkuywVqZM1HDHeEywSlR8RuwO5hdI DflGUZ1l91Sj4s026NO8S3vqQd1dR+TTfIcldb29P/7lhCs2z1cXnqpRPEgDlYy48+oV gBgYuhv44zWCWgNFl0z+j/HNffn26YjDfGE/bVm+OmcQfIRHkEWn38mOpIGaFL472Zv8 kenw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bJfD+mjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18si24414270pls.22.2019.05.22.05.30.47; Wed, 22 May 2019 05:31:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bJfD+mjF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729215AbfEVM3L (ORCPT + 99 others); Wed, 22 May 2019 08:29:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:33492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728914AbfEVM3L (ORCPT ); Wed, 22 May 2019 08:29:11 -0400 Received: from [192.168.0.101] (unknown [49.77.233.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30B0C2173C; Wed, 22 May 2019 12:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558528150; bh=upmsRZdkQq8h/PyD9HJOtFErgwAT7ktBsV7srF/AT70=; h=Subject:To:References:From:Date:In-Reply-To:From; b=bJfD+mjFb6YdomL+VqHfR6L1H6ztDKFP/+OfrymNyi4djSftXdHR/bx4GkO4OY7Q9 K96jNO+km9Hcjda9UHQtxiEo3bNKrIdrK3Apk0sWuAsjCaSOLQMQfohPVdtpBvVnQP M54ptaNLWAaA8y/o/ba0aZEzLh4ixvb3hJgemL/A= Subject: Re: [f2fs-dev] [PATCH 1/2] Revert "f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG" To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20190521180625.10562-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <8e9a4cac-c81b-11ce-0a5a-c6f5caf716c4@kernel.org> Date: Wed, 22 May 2019 20:29:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190521180625.10562-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-5-22 2:06, Jaegeuk Kim wrote: > This reverts commit fb40d618b03978b7cc5820697894461f4a2af98b. > > The original patch introduced # of fsck triggers. How about pointing out the old issue has been fixed with below patch: f2fs-tools: fix to check total valid block count before block allocation Otherwise, user should keep kernel commit "f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG". Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/checkpoint.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index d0539ddad6e2..89825261d474 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1317,10 +1317,8 @@ static void update_ckpt_flags(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > if (is_sbi_flag_set(sbi, SBI_QUOTA_SKIP_FLUSH)) > __set_ckpt_flags(ckpt, CP_QUOTA_NEED_FSCK_FLAG); > - /* > - * TODO: we count on fsck.f2fs to clear this flag until we figure out > - * missing cases which clear it incorrectly. > - */ > + else > + __clear_ckpt_flags(ckpt, CP_QUOTA_NEED_FSCK_FLAG); > > if (is_sbi_flag_set(sbi, SBI_QUOTA_NEED_REPAIR)) > __set_ckpt_flags(ckpt, CP_QUOTA_NEED_FSCK_FLAG); >