Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp431091ybm; Wed, 22 May 2019 05:48:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4P1osZBs7kO7LF9j3iUvupXqhnjuP8Xl0EKn/jjRI69Hl53mTgBJpEv+IMZivn0pVNZtt X-Received: by 2002:a63:e616:: with SMTP id g22mr22703879pgh.61.1558529300360; Wed, 22 May 2019 05:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558529300; cv=none; d=google.com; s=arc-20160816; b=uoA+0SokGbcGWlKLPt7u4uNX2PwC3kfiiRbKNSIvN+zBLnqtyXe7jjZL2iZBOyMgMj kv/oYTvPCHFk8jzuyqejBwEu6krSsofZ0qNyBoDo49X9owJ5irM4zBc4v2UCuKCCMHHc 5EeErkZT9cxqFGQIJPez6HXhnrYnc7A82/TwGdBhSNpWmHt9x6eSSBWkXLRNTZ65u+Qr Bdz+vgoyzkxMZsNI3PzsZ2wfa7h1b3FmvxgnKqIg3SoHoNrZ87WT9IOQbjKS+hk5JMON dQwBpPSCG8zDzA3dhjRmiirbWe8044XSXBJKsbVg9m3OS2ZCJok/btaExeH/PoX+0Six 9C3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1F8jBEWxGY787SCNJEpouiYvDXkikaekndSOZ10FIWs=; b=lrI1KNVsGU7MDsmWw+tUwZGuz7rhu10fyF3rVTqKkT4vL2N5YxvI+or6TOlhAtXapx 5SGBxFIrcVp+F1ec6MqPPuAWuSE8sC9Uvl0UifqBft/WHTi+PaL/XAmA+POgGxwp1hW3 eeSSgoUtVsuIGsqAxWSiuOtsj3j7Zel4Vhz7m/Z7WuTV+c7wqY8Xek25AX2RKtfuTgbI vWcdBybV9T/h7G5WE3ykKEhXIbQuZlAiLcRXQByO5dMX+ccB2VH2pVPSK4arfM/hTX/k RGWj2UXXjhCuZSys9nGPFfy9w8Ed90wT9PEVisW3UZKC43bgs4pg8+9zv6716PdYKOwy lSsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AudOvINV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11si27184678plb.416.2019.05.22.05.48.03; Wed, 22 May 2019 05:48:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AudOvINV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729171AbfEVMq4 (ORCPT + 99 others); Wed, 22 May 2019 08:46:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:39736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728468AbfEVMqz (ORCPT ); Wed, 22 May 2019 08:46:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BD1E821773; Wed, 22 May 2019 12:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558529215; bh=4U9I/NIQVI//8jEbd8ZkohshHTF1sn59PS/Bq9njMLo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AudOvINVOGb4x2bKnHS0cL/0I2MQxsxZE0I1RGx+QCjXy8AgPOMX/H5z7/buVmllm YkOmvkLJwOYL39HC4UDzkQBw6bB/PlYXxH1eyMZePkHjE1Iz1vXav5ennBIQogRzQp nQqso7OYwuKP2oQP4DsBFyS/tZHic/LM81X+f4o8= Date: Wed, 22 May 2019 14:46:52 +0200 From: Greg Kroah-Hartman To: Geordan Neukum Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Matt Sickler , Dan Carpenter Subject: Re: [PATCH 3/6] staging: kpc2000: kpc_i2c: newline fixups to meet linux style guide Message-ID: <20190522124652.GB22148@kroah.com> References: <1c1b8428a502e79f19af7bc2a98787ecc6a1ed5a.1558526487.git.gneukum1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c1b8428a502e79f19af7bc2a98787ecc6a1ed5a.1558526487.git.gneukum1@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 12:13:59PM +0000, Geordan Neukum wrote: > The linux coding style document states: > > 1) That braces should not be used where a single single statement > will do. Therefore all instances of single block statements > wrapped in braces that do not meet the qualifications of any > of the exceptions to the rule should be fixed up. > > 2) That the declaration of variables local to a given function > should be immediately followed by a blank newline. Therefore, > the single instance of this in kpc2000_i2c.c should be fixed > up. This really should be 2 different patches, but given that this file is so messy, I'll take it for now :) thanks, greg k-h