Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 22 May 2019 14:54:09 +0200
From:   Roman Penyaev <rpenyaev@suse.de>
To:     Eric Wong <e@80x24.org>
Cc:     Azat Khuzhin <azat@libevent.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/13] epoll: offload polling to a work in case of epfd
 polled from userspace
In-Reply-To: <20190521075114.if4urjezominbojj@dcvr>
References: <20190516085810.31077-1-rpenyaev@suse.de>
 <20190516085810.31077-6-rpenyaev@suse.de>
 <20190521075114.if4urjezominbojj@dcvr>
Message-ID: <7fced5a4f9468a273b6acb0ca0fdcfb1@suse.de>
User-Agent: Roundcube Webmail
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-05-21 09:51, Eric Wong wrote:
> Roman Penyaev <rpenyaev@suse.de> wrote:
>> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
>> index 81da4571f1e0..9d3905c0afbf 100644
>> --- a/fs/eventpoll.c
>> +++ b/fs/eventpoll.c
>> @@ -44,6 +44,7 @@
>>  #include <linux/seq_file.h>
>>  #include <linux/compat.h>
>>  #include <linux/rculist.h>
>> +#include <linux/workqueue.h>
>>  #include <net/busy_poll.h>
>> 
>>  /*
>> @@ -185,6 +186,9 @@ struct epitem {
>> 
>>  	/* The structure that describe the interested events and the source 
>> fd */
>>  	struct epoll_event event;
>> +
>> +	/* Work for offloading event callback */
>> +	struct work_struct work;
>>  };
>> 
>>  /*
> 
> Can we avoid the size regression for existing epoll users?

Yeah, ->next, ->rdllink, ->ws are not used for user polling, so can hold 
work
struct and co (or pointer on container which holds work struct, if work 
struct
is huge).

--
Roman