Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp443363ybm; Wed, 22 May 2019 06:02:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwld1aBVW1BKKeRk/KCnmx62oJrfflnQ3joZruDyfe7Cf+KVWO5azcdjNwz5xVseHrm9Ems X-Received: by 2002:a62:55:: with SMTP id 82mr12632654pfa.86.1558530133682; Wed, 22 May 2019 06:02:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558530133; cv=none; d=google.com; s=arc-20160816; b=h0CO5C+ZyIGTrKpslx0Wdi66+Lt4sA8UK1PvzyGCe67loiGa6nIdoXom0bk1Rv1Fsy eDrXlm+wwZ+s3igRju9Y6ckI2FaQYascM9+Dld67GFf1gC2ui2CDiJd0iXtPZRvNQPWL Pj6HNgUmyajTBc1l+YFGoYqf1mCZ6jF27Tn/apyXdWAehjfR9nFx6MT0qsfX99uA1MEv RqtqEdKkoyOor2aGcI5rW6bEUJshsq9KUfOT+EOdTvzwXHQz9yufO4hpXEPLqoV4p/pk Ny4G+BYzCC2COuhvszojaMPOvh/Gn+yKCG/27UCFxDNlSVv59ZFh8cxyGsiEGSWi1T5W qwdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=FvL15YcB7OpIpp0gHWQHPa/ADBouGFQj+XmJQ40ImwU=; b=hrEsZJuk5c4KhrLsi15YwFQuOcsuwvcRyhluJ1bMxsq8axLXwIXOFoHwpZjECJW7/K wWe35MLn2mhTjKpvtH8M+ff7SJSY/tbgR/pFQj38ARvi994SORxDqG2S6OmlTlTQiBj2 nE9n3yTd5/Wp/BfrfMxCDkM3P150/GwYbKIzNQ+2PxfnxLViW19P1xpPqin2uTgNGMf3 Ov/w6hpFbd7rT69+YuJgthlhCCfCTT21++6XE+QIgPgDfnFZvvgWjYwcwi/TfOn/HCoV xleqSoLOCyFTV4OkaFJXjmRh1TrD1rw/XNPnL0EdqBs1T5/3jM6fjFHLkjP779ap/Jj1 rVzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q20si5288858pgj.216.2019.05.22.06.01.54; Wed, 22 May 2019 06:02:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729198AbfEVNAn (ORCPT + 99 others); Wed, 22 May 2019 09:00:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43015 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728638AbfEVNAn (ORCPT ); Wed, 22 May 2019 09:00:43 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57F7A2FFC32; Wed, 22 May 2019 13:00:24 +0000 (UTC) Received: from treble (ovpn-122-194.rdu2.redhat.com [10.10.122.194]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF7BA28558; Wed, 22 May 2019 13:00:15 +0000 (UTC) Date: Wed, 22 May 2019 08:00:14 -0500 From: Josh Poimboeuf To: Steven Rostedt Cc: Johannes Erdfelt , Joe Lawrence , Jessica Yu , Jiri Kosina , Miroslav Benes , Ingo Molnar , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Oops caused by race between livepatch and ftrace Message-ID: <20190522130014.yvkbio62meatqvwf@treble> References: <20190520194915.GB1646@sventech.com> <90f78070-95ec-ce49-1641-19d061abecf4@redhat.com> <20190520210905.GC1646@sventech.com> <20190520211931.vokbqxkx5kb6k2bz@treble> <20190520173910.6da9ddaf@gandalf.local.home> <20190521141629.bmk5onsaab26qoaw@treble> <20190521104204.47d4e175@gandalf.local.home> <20190521164227.bxdff77kq7fgl5lp@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190521164227.bxdff77kq7fgl5lp@treble> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 22 May 2019 13:00:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2019 at 11:42:27AM -0500, Josh Poimboeuf wrote: > void module_enable_ro(const struct module *mod, bool after_init) > { > + lockdep_assert_held(&text_mutex); > + This assertion fails, it turns out the module code also calls this function (oops). I may move the meat of this function to a __module_enable_ro() which the module code can call. -- Josh