Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp496312ybm; Wed, 22 May 2019 06:52:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqz4rpz2V2XioHFuWeGYba8Pr6AtIX6tjrCBZeqQcgGyF1mlb+Xdd+0+GSX8OAHd/RV+IHep X-Received: by 2002:aa7:9e51:: with SMTP id z17mr95681816pfq.212.1558533168015; Wed, 22 May 2019 06:52:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558533168; cv=none; d=google.com; s=arc-20160816; b=rZJJGltGYwINQV4IHuf35V8kO34n8RKcAXFknkh+4K1zqXc9wqdUsNNZnqW+33jzmH ypZDZ9bfmzWCgwh9gQby6EPrbbw1D+MhXHD486HKfPSAaNWsdVl72VnhJTZI9yZ7latq miIOzLno+xa0lw0UH8HQihLMx8c7u06Zr7w7aNSU71MuHW69VD0j7cQkV1S3182Einh6 njcTL02PJRkrdlo/vjZec6Li7bIU+umbD7wADvUpYpzhei6APWYnnzPxF/TT2qynIxnR 37YScGqs6Cwse8PRfBCw0X0xBLp01eGjGNC3QzwgYEaGtrLl/v330Wzsk0yA1OTAjONj HbfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7PcrUJpAN8FUR5Os5eZdN4/qfIg3FFf2/UF6cSYu22g=; b=hozG8FRn02SKeslFyz7ic3XAUc2TZ+RdFb6aF1mCr1mMM65+a8Q7b1uHnJxezmx6TW HLwOQOSPq1xTlviIWRx3rtXyXgWJtmWsYe/DIFUh6tWqb1G+Tq1gJJMZjG1jcT0dfT/M XCrxb5uu539wqNi9VjLgg1Mp1R5kV6Bot0ESEIJgZ78UBRXJ3ZzavJ4VqqIN6oOOv9G2 5GWRSun1W9Wy18ji2bKTjqbSnQdUeFTphbIByXzZ+8TRGfPXVmVu+RlFcxt/6Z9yobJ1 x3h1JEepSrKaSxjhry5ebHIOtnvcbL6BGESnM0xmnn0Oii0YjIV81KbVkSE3WZmDOtDu yEZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FRneyTJ1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21si26145837pgv.410.2019.05.22.06.52.32; Wed, 22 May 2019 06:52:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=FRneyTJ1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729071AbfEVNvZ (ORCPT + 99 others); Wed, 22 May 2019 09:51:25 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40208 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbfEVNvY (ORCPT ); Wed, 22 May 2019 09:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7PcrUJpAN8FUR5Os5eZdN4/qfIg3FFf2/UF6cSYu22g=; b=FRneyTJ1KPX9uILNf6OYwDJke r1sUw/VWN1m3p5ISAdhvMbPPFLADQ764Wp+ofMRLOF1Ixa1dwIVr6HuEH1GwdoVNpR1adztp+plZM E5nO+VcZVOteXU3qtxUFly2BizAYJ05PghzY3RDhVnreLVIzynopkKDkQjFKDx8OYMYYkpUq+fTfC VjvPSZzzwkCVzVocdTUB7rmIgRtTiiqU/QyTwWtgpOSbpOaQY5FJB/4+D3t1nvn7jqG8kGJ6dW53O d5rXWNcHyUIkUJNOQMtQpHqRF3BK9F5pEp15zu04Mfn07X1V1MjGQYFVY14F6Zu2MJEDnGekXk3Hb L8vU2JuXA==; Received: from [31.161.185.207] (helo=worktop.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTRe7-0001EA-LX; Wed, 22 May 2019 13:51:08 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 9FCCB984E09; Wed, 22 May 2019 15:51:06 +0200 (CEST) Date: Wed, 22 May 2019 15:51:06 +0200 From: Peter Zijlstra To: Song Liu Cc: Kairui Song , Alexei Starovoitov , lkml , Kernel Team , Josh Poimboeuf , Alexei Starovoitov , Daniel Borkmann , "bpf@vger.kernel.org" Subject: Re: Getting empty callchain from perf_callchain_kernel() Message-ID: <20190522135106.GA16275@worktop.programming.kicks-ass.net> References: <3CD3EE63-0CD2-404A-A403-E11DCF2DF8D9@fb.com> <20190517074600.GJ2623@hirez.programming.kicks-ass.net> <20190517081057.GQ2650@hirez.programming.kicks-ass.net> <20190517091044.GM2606@hirez.programming.kicks-ass.net> <8C814E68-B0B6-47E4-BDD6-917B01EC62D0@fb.com> <8449BBF3-E754-4ABC-BFEF-A8F264297F2D@fb.com> <842A0302-9B36-4FBF-ADF7-9C6749E8C5BE@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <842A0302-9B36-4FBF-ADF7-9C6749E8C5BE@fb.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 05:22:12PM +0000, Song Liu wrote: > I think this is still the best fix/workaround here? And only one level > of stack trace should be OK for tracepoint? No. That's still completely broken.