Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp545993ybm; Wed, 22 May 2019 07:38:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3iE5NnlnoZliYHz+B9oDqOEFovSRfMdMVMVzQDB7WuhQE6vuPTo2WULh+fAS3DY7vXSl6 X-Received: by 2002:a63:1b56:: with SMTP id b22mr87414420pgm.87.1558535899140; Wed, 22 May 2019 07:38:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558535899; cv=none; d=google.com; s=arc-20160816; b=VRobDRu60mZFGgf7oiZTJUyJ4zphZhRmxYjH6lszr0Ra0o04ls0Ek2+iVQIvGEOZGD L6PT/dw39XbFREZ3Q5XEIaAQcgBi0A8P/sUiBsjoD23hZAo9yeqwfXuzmpxdkH17XaC/ Xr1zBVAjF0ghFxpdhefgSDBA+/B7C96byJ1nExr0zowFM70l9gcAI/xIrQsEf+UzG207 qkuJqV23E2MXnywwpN9ymhemyHSrIE4n7sNVUyEgGG6hVz94pVj5krgx2x9d7HRmo6kt dQ2gobMLFXY/kL7/5LDkc4IBqvIEjhqzWb40gNhCqyAXzfsuu9RGLaP3jrqUQ+/v+cdo oBew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0m0QjYyjO2xHrKzFzTehhWEPphtJIzzFFRYPzTW3DMQ=; b=LUuohmPgaJhb2znOHSeoJkRogAVAmmFiQecwoS9q+jZBHOJ60DRr/SNad6nhr7CTZb /cbCzO/URF0Mjr1aQQKhBlQmuVXGvLMFVy0iVk1dZwuFfioFiM9ICGLJnmuoIYEivupg C+QgAMuhdhtfj9iSUQpTlnC3whOnr19Ml9gdY3YZtrI5ZD1JBNleU5kMxte2SC1nfIxF 7RkMBfKgdkq22rLNAKa1vuhHF2pbL9h68LmC8IQ81zu5qrIS5yuzqW+chDKlha/GTjlD qDPnrJT2DkD9yVSOWnqumNe8eLeLon1XkoyRt9keo9PgxMOba+XZ0k5LLicRRzlHc8CJ eSug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rajagiritech-edu-in.20150623.gappssmtp.com header.s=20150623 header.b=T2kYxw6M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si15407252pli.54.2019.05.22.07.38.03; Wed, 22 May 2019 07:38:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rajagiritech-edu-in.20150623.gappssmtp.com header.s=20150623 header.b=T2kYxw6M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729388AbfEVOaa (ORCPT + 99 others); Wed, 22 May 2019 10:30:30 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46251 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728744AbfEVOaa (ORCPT ); Wed, 22 May 2019 10:30:30 -0400 Received: by mail-pl1-f194.google.com with SMTP id r18so1160108pls.13 for ; Wed, 22 May 2019 07:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rajagiritech-edu-in.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0m0QjYyjO2xHrKzFzTehhWEPphtJIzzFFRYPzTW3DMQ=; b=T2kYxw6M4VFwvrSg9HRUF2uPooKZ2Dk6AmNuLHygKvbtjUp1C79ABGleU4NpWQgtG+ xyNerFhZb1XMy6mw5lQzehrEE7/NBqYQPzUt9jvyTeLj9vsYw3pAry+y23L3yjfCjhDJ yoMBcgsNSAsgypmbF99mRLSytz+s/UDYzeuQUPzFC6WTuCtGRKRYUgQx6yvSE/FxlWH2 pqRUDuI5S4wSMke309nhIOWTIHwzEzKiKdSXZRidURLm26VHEBEOC1iIc3U2gexz0ynG vOxHFexpwwsDmgzyeSI00gmNJ0WAnYhTVwEa0K2+6EZjiULYXI9ZcdenQdTGsT3HwctH k3Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0m0QjYyjO2xHrKzFzTehhWEPphtJIzzFFRYPzTW3DMQ=; b=QSRFBuKUKSQZr6ojKTsbOqXxUgP+wdCG962TYxTCCQuUmOBpchDIwBy60cXsrqkIRQ CrEdBDZaSfI7Y21iM/2qZy+URaYHM5Gojn/Uj6A3SS7z4Jhcauhj0AFC/EyOrZtACEdo DbiuJiu6w6qPu+5K3Xvh28ZRFQnomL0c4Qnri7KfQA5RF1yi+WFAgG2muaK+L25RWYt9 4OOCpek5vbRDJJ/rF1hRIYL/A/Cyhys0XbgmueqIMQ4k611AmJswFHyFCjr1unih9Ytx xpVhoW5IJ5beXrRG8nTdZ49a5vF3HXm7jDT/qLWXZTy0MDMI8b9bDJdBWt8EEDJdtL6s HRQA== X-Gm-Message-State: APjAAAWVxPKeZqjo2Qeu37R0x4TgvlMiqDjBI1O9Wzqn76qPXo19PPjh IXQJCLYaYupJL/o1YLLuPI3lvdVl1TPC3vOqs1sEiQ== X-Received: by 2002:a17:902:3103:: with SMTP id w3mr15769604plb.187.1558535429532; Wed, 22 May 2019 07:30:29 -0700 (PDT) MIME-Version: 1.0 References: <20190515064405.3981-1-jeffrin@rajagiritech.edu.in> <20190521181125.anqj32v3gcwjxs3z@salvia> In-Reply-To: <20190521181125.anqj32v3gcwjxs3z@salvia> From: Jeffrin Thalakkottoor Date: Wed, 22 May 2019 19:59:53 +0530 Message-ID: Subject: Re: [PATCH v2] selftests: netfilter: missing error check when setting up veth interface To: Pablo Neira Ayuso Cc: Florian Westphal , Shuah Khan , linux-kselftest@vger.kernel.org, lkml , netfilter-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks to all ! On Tue, May 21, 2019 at 11:41 PM Pablo Neira Ayuso wrote: > > On Wed, May 15, 2019 at 12:14:04PM +0530, Jeffrin Jose T wrote: > > A test for the basic NAT functionality uses ip command which > > needs veth device.There is a condition where the kernel support > > for veth is not compiled into the kernel and the test script > > breaks.This patch contains code for reasonable error display > > and correct code exit. > > Applied, thanks. -- software engineer rajagiri school of engineering and technology