Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 22 May 2019 10:43:32 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Viktor Rosendahl <viktor.rosendahl@gmail.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        Joel Fernandes <joel@joelfernandes.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v4 1/4] ftrace: Implement fs notification for
 tracing_max_latency
Message-ID: <20190522104332.3564e82f@gandalf.local.home>
In-Reply-To: <20190522143545.GG16275@worktop.programming.kicks-ass.net>
References: <20190521120142.186487e9@gandalf.local.home>
        <20190522003014.1359-1-viktor.rosendahl@gmail.com>
        <20190522143545.GG16275@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 22 May 2019 16:35:45 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> > @@ -284,6 +285,7 @@ static void do_idle(void)
> >  	smp_mb__after_atomic();
> >  
> >  	sched_ttwu_pending();
> > +	/* schedule_idle() will call trace_enable_fsnotify() */
> >  	schedule_idle();
> >  
> >  	if (unlikely(klp_patch_pending(current)))  
> 
> I still hate this.. why are we doing this? We already have this
> stop_critical_timings() nonsense and are now adding more gunk.

I was thinking that this can possibly be added in the
stop_critical_timings() as that is probably where this is needed
anyway.

-- Steve