Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp737024ybm; Wed, 22 May 2019 10:37:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkp9aKolGWrXnxNNQzO10yrFF2OJfCnZ3X/LU8OQuEhz5kUCnQf355DN7F/wLnmSYxiO/v X-Received: by 2002:a62:4607:: with SMTP id t7mr97984220pfa.138.1558546672227; Wed, 22 May 2019 10:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558546672; cv=none; d=google.com; s=arc-20160816; b=ipIibCZHlh00CDuudo0OyFd5r871QY4zicYz2R0sZ/CyMsgxI1M00ZerH2cBNqon2J VWosmMxsVXEjVg9SuGSyOll0YNESZ917mxnRTe/66M9bA+EY9TnJB1hbQU4DJmub/Buw hAu/c3rE74dgrL42sTELRpt6B5UlDKz6qRHrnLqVUCia6wssH/TGITylZLj4wfVZNqA8 sIup26caBBa7aE8UReRXwspSHmcDDuV0oQ63KDaySUFSSVZQule/rgD3Q9OAJuDPAQNw 91iYbdhUgeKvf17p0aW/vwRoW6WZz5IJVRTysO272p7AKo3bjXHmW7aAnhSPMoKVhTuk Dy/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BdWuqZOtCxiJWKxyYPsYdHaasq4huWhopiY0JaG175g=; b=bdU1N1gXYovAQTnKT32Bp7Xiu3aXwOzrN5WMiGInSlJDjF44Dz6dcaoZYafYH1nq4O tcb202fYusNqsClwWCyNNQwOIHIVY/D9WHH7ErXjjKBu5i4TRtKFFqKHEQVY/mJTro1A olH8npQQxJfXa+25Jt7iIPtA8TUEJCuo3qHdjV+NQO+H0H6Rs/sMHbXZRR1pi21tJWst ZKyOYhF11+W5+xMupK80c2gFq/dNtG/dYn2mwTn/T4CoBnvS+6ax+ADYeLNHcN6nfNyD bGgE9okqXbVMVTaJg2fGz4u5n9u2YPMPYQukOgpVvPkQvzma5+ReBTCnvF5kQsmGItnY buag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r204si28243980pfc.263.2019.05.22.10.37.36; Wed, 22 May 2019 10:37:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729819AbfEVP5c (ORCPT + 99 others); Wed, 22 May 2019 11:57:32 -0400 Received: from verein.lst.de ([213.95.11.211]:40332 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729431AbfEVP5c (ORCPT ); Wed, 22 May 2019 11:57:32 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 35D7268B05; Wed, 22 May 2019 17:57:09 +0200 (CEST) Date: Wed, 22 May 2019 17:57:08 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , Tom Murphy , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/24] iommu/dma: Move domain lookup into __iommu_dma_{map, unmap} Message-ID: <20190522155708.GA29904@lst.de> References: <20190520072948.11412-1-hch@lst.de> <20190520072948.11412-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 02:34:49PM +0100, Robin Murphy wrote: > On 20/05/2019 08:29, Christoph Hellwig wrote: >> From: Robin Murphy >> >> Most of the callers don't care, and the couple that do already have the >> domain to hand for other reasons are in slow paths where the (trivial) >> overhead of a repeated lookup will be utterly immaterial. >> >> Signed-off-by: Robin Murphy >> [hch: dropped the hunk touching iommu_dma_get_msi_page to avoid a >> conflict with another series] > > Since the MSI changes made it into 5.2, do you want to resurrect that hunk > here, or shall I spin it up as a follow-on patch? Either way is fine with me.