Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp746236ybm; Wed, 22 May 2019 10:47:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8OX+6IDQUcVatU8DxLugqlUuYZ4JLyggyxjJEmljSvUKxcZWNQRxWLJmz0ScUncSK8qaP X-Received: by 2002:a17:902:4283:: with SMTP id h3mr69415370pld.214.1558547255950; Wed, 22 May 2019 10:47:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558547255; cv=none; d=google.com; s=arc-20160816; b=M0V6VwxWkSxKeBrjvLjXFzPFOA6Uo1rARA6GHIcFEyYUmY+0B8+0zXhrTp2/HBu4/c b+FANGnysTYCGbDX7jRqvHn9caqGkoiNnW54JzC2c8Pt4vCHqXfB5V0EXOCH+AXR61D7 gO5uNjtDQKGvhAeyzyQNuaXN58L2G8aDuQ9JWAdpF1/XFSuCeZymGJcYd3N4pRFIZqDw OrqjVeNq+r12LIhblixGLov492jux1sqol7RyBpWB6ffgZtVu7Tk6pZyvFxq4JIO9Muu rhSdRL77u6hKIUM7SKOBPduhRDfyp0l0C7J/JJdrrbfztKW53dZKTasBDwgjen0a+7Gz QykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wHA/7YHVtnbwMn8XamtMQWJP1tHqv3C9SKZiyANNEgc=; b=Y4TUdHpwQOpTe0r1EEs7iPjCeDLV/Ny5ielMGuGCbvByPD8zpikm2yTBGmDEczTP3W 7jkG/z1hczG+rTVRYyZMb3GDBDOS3ElA88NXaRlYety+g4/Vn25X2BUGV2HcLeQiaON8 kV/C8825Fie/KcsetHqCb7FZpfj4P7RAa/34aJVlI/Wo7C1mYqONJgaE4PS2WDvd46hy Cqm8jHBvVtj0FNUTG8YIqW2GC9zNcxIFv6Qmi61acuEnRMBsJTtDyk+1oUBQaBvkSMsz kpLiwDOevrxHuop+un1iK9njPxqnFSrzM8BopL6e9u7jRCOWpgF3/C5S3Wo3BWE4tYYy CnUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20si25682943pgl.332.2019.05.22.10.47.20; Wed, 22 May 2019 10:47:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729481AbfEVRpZ (ORCPT + 99 others); Wed, 22 May 2019 13:45:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36730 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727984AbfEVRpY (ORCPT ); Wed, 22 May 2019 13:45:24 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86DFB3084039; Wed, 22 May 2019 17:45:24 +0000 (UTC) Received: from treble (ovpn-120-127.rdu2.redhat.com [10.10.120.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 697CA54389; Wed, 22 May 2019 17:45:20 +0000 (UTC) Date: Wed, 22 May 2019 12:45:17 -0500 From: Josh Poimboeuf To: Alexei Starovoitov Cc: Peter Zijlstra , Kairui Song , Song Liu , lkml , Kernel Team , Alexei Starovoitov , Daniel Borkmann , "bpf@vger.kernel.org" Subject: Re: Getting empty callchain from perf_callchain_kernel() Message-ID: <20190522174517.pbdopvookggen3d7@treble> References: <3CD3EE63-0CD2-404A-A403-E11DCF2DF8D9@fb.com> <20190517074600.GJ2623@hirez.programming.kicks-ass.net> <20190517081057.GQ2650@hirez.programming.kicks-ass.net> <20190517091044.GM2606@hirez.programming.kicks-ass.net> <20190522140233.GC16275@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 22 May 2019 17:45:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 02:49:07PM +0000, Alexei Starovoitov wrote: > The one that is broken is prog_tests/stacktrace_map.c > There we attach bpf to standard tracepoint where > kernel suppose to collect pt_regs before calling into bpf. > And that's what bpf_get_stackid_tp() is doing. > It passes pt_regs (that was collected before any bpf) > into bpf_get_stackid() which calls get_perf_callchain(). > Same thing with kprobes, uprobes. Is it trying to unwind through ___bpf_prog_run()? If so, that would at least explain why ORC isn't working. Objtool currently ignores that function because it can't follow the jump table. -- Josh