Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp786081ybm; Wed, 22 May 2019 11:28:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzbNcqHFe9+KlXMuORaKIrWj6pDWJVKUZVtgfNLfTOcNLipE1bLpHHMWE1zVrMkTZwTN3NY X-Received: by 2002:a17:902:7488:: with SMTP id h8mr57093823pll.315.1558549703749; Wed, 22 May 2019 11:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558549703; cv=none; d=google.com; s=arc-20160816; b=fjCMamVrWip9ZW1qgZyorz9vYlHxy3TtK2zSlbFyxyYwAKMIHu3R7HeVX93mXSFran TkaA2KDxdyh/OwdvhNFB15a3/GUbIgPsVEY0rYVIq/tRjIIMSK1Bm5wRGj6XliXdQ+CO +pfN8rAqJIDb5eLH2+bywi1G8p7ugA7pIsn8gQX+rlPajs+EZnHaNfRm6LL7bytN98Nx szTKAtCbZ7IykPwLDQWYK41HV9XlQyAHN5CdujH/NT2JkJ0i2BSOUBC8sghe9H2/InpP Cx8ORJgvNjh9Wd9+Vd8issr4rfuIMMJf8hChUZCdk57x8Mxi8Mu27zHKogZ3BRYwzAYH qq2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=+cjZu7UYIWfl3+uZkDA8MDVh/UHQTxR9rJwk+Staepk=; b=nVUgW2zWtd94mqFZZ1yznirqYvzDccEq58RcMF/24HxXUptL8KpLVXBoYDevsZBU84 p8Ytl+YKMXyI+OcR7pQueOQlVm/qtcr24ZIBle6KXOSLkO8nHUkHqF3HmBd7+/9mYM85 E47XsVjUKgs//ZoVjbcMvt1DjzxlTSNX17bUC/bthDV1Y9t9Q/1gcqlEFRuQta6eyEO6 bbDONqOWoHwALxDifRMyLr0BVhzEZvNGHAkQbbWdaG6XDAIyciB6rTL6JSZcTpqQZMoJ uqlvez1MySzMV1C7/LporTESCNDe3vskU/W1RQvN/D7g0n2w3e4B4gudB4yw7+dWsIs1 yx3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DJjLEb3+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si26064722pgj.258.2019.05.22.11.28.08; Wed, 22 May 2019 11:28:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DJjLEb3+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729538AbfEVSZ0 (ORCPT + 99 others); Wed, 22 May 2019 14:25:26 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34324 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728272AbfEVSZZ (ORCPT ); Wed, 22 May 2019 14:25:25 -0400 Received: by mail-wr1-f67.google.com with SMTP id f8so3406341wrt.1; Wed, 22 May 2019 11:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+cjZu7UYIWfl3+uZkDA8MDVh/UHQTxR9rJwk+Staepk=; b=DJjLEb3+UhJU/UYaj40YgmYzbvfNSNjqRjc8+oIJ5ybtqvOhHVpAqlLGWoW6Pms3du LZKjemGcUzwORRb/s6Rl0XTz1OFtmoY3BjN60PkDwTlUWCLuHUu1iWKG0kyqfcNkYNY/ QotpBZVPdvQOlj3FZdchAOflX/fU5lAAr2xCw4Y4wJsTtAc36dBrDa6ULYVksrs2GzOT PE7Y3K4OB5Wil4h7sCtQLuwltkqKS3IjG5Lhi3WMd6Qef7ANiNkDa0mscFdYq3dKVDrV xTyALBI9negl33x7wiSH29FJOQINHs03kyWuYzIcUmPvU/JFV30z1t+wvidTH4asfEW8 DNRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+cjZu7UYIWfl3+uZkDA8MDVh/UHQTxR9rJwk+Staepk=; b=gXxiiyWOrKyHwX9iT8y/sN0KC+8WRJFncaaXLirhKcAPjz5FrgVM79R7+mRxYf6pcp WRSmFm+JvttG6BhmbahTrWt/1DY8/AJzPgt7xEVxyDBfSnF6+GJntPEtJa9wuSEg3GEt 0lvKGVWO8EAvEw8CrXS40j1M7Cr/73b3rsvlTs/JweHCXceXLoRQ3aK9VOECn/aOF0xg E9D+duFbyAbLt5gxWoRiXZZ2lXslr4u/uLh8Ej8hZ3DknZ62EIZ5fY32TkUtOSc4AQZP I/V3tlcebg28NHMh6WE2BaItnXrLpUhlST9izzD52nU2SFEXIbhal4cUyvtHRRc3c7zT /a1A== X-Gm-Message-State: APjAAAUTjpDpEym/SBSnnDqutD2a8CS30O9BddSlaVoxWB8tsYn+ndto y5+gEV9+0Txp9yT++gSOIhsAnnqi X-Received: by 2002:adf:b60f:: with SMTP id f15mr4507235wre.283.1558549523577; Wed, 22 May 2019 11:25:23 -0700 (PDT) Received: from ?IPv6:2003:ea:8bd4:5700:3029:8954:1431:dc1e? (p200300EA8BD45700302989541431DC1E.dip0.t-ipconnect.de. [2003:ea:8bd4:5700:3029:8954:1431:dc1e]) by smtp.googlemail.com with ESMTPSA id v184sm11516461wma.6.2019.05.22.11.25.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 11:25:22 -0700 (PDT) Subject: Re: [PATCH] net: phy: lxt: Add suspend/resume support to LXT971 and LXT973. To: Christophe Leroy , Andrew Lunn , Florian Fainelli , "David S. Miller" Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: From: Heiner Kallweit Message-ID: <15504aa9-092c-c3b0-4dbe-32b9cc8dff39@gmail.com> Date: Wed, 22 May 2019 20:25:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.05.2019 12:01, Christophe Leroy wrote: > All LXT PHYs implement the standard "power down" bit 11 of > BMCR, so this patch adds support using the generic > genphy_{suspend,resume} functions. > > LXT970 is left aside because all registers get cleared upon > "power down" exit. > > Fixes: 0f0ca340e57b ("phy: power management support") > Signed-off-by: Christophe Leroy The patch should be annotated net-next, and I would recommend to remove the Fixes tag, because it doesn't fix an actual issue and I see it rather as an improvement. Apart from that: Reviewed-by: Heiner Kallweit