Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 22 May 2019 13:54:47 -0700
From:   Kees Cook <keescook@chromium.org>
To:     Gen Zhang <blackgod016574@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] consolemap: Fix a memory leaking bug in
 drivers/tty/vt/consolemap.c
Message-ID: <201905221353.AD8E585E6D@keescook>
References: <20190521092935.GA2297@zhanggen-UX430UQ>
 <201905211342.DE554F0D@keescook>
 <20190522015055.GC4093@zhanggen-UX430UQ>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190522015055.GC4093@zhanggen-UX430UQ>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 22, 2019 at 09:50:55AM +0800, Gen Zhang wrote:
> On Tue, May 21, 2019 at 01:44:33PM -0700, Kees Cook wrote:
> > This doesn't look safe to me: p->uni_pgdir[n] will still have a handle
> > to the freed memory, won't it?
> > 
> Thanks for your reply, Kees!
> I think you are right. Maybe we should do this:
> 	kfree(p1);
> 	p->uni_pgdir[n] = NULL;
> Is this correct?

That's what I'm not sure about. I *think* so, from reading the code, but
I'd love to have Greg (or someone more familiar with the code) to
double-check this.

Otherwise, yeah, this looks right. Please send a v2 and we can debate
the correctness there, if it turns out to be wrong. :)

-- 
Kees Cook