Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp943394ybm; Wed, 22 May 2019 14:23:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxp9waAeJoXhVdDMMvkyCWhEN1d0iayIesuvoILguz/jOOPtqmNGb9PhZ4HsKRC1rKMonhU X-Received: by 2002:a63:7:: with SMTP id 7mr93444652pga.108.1558560185802; Wed, 22 May 2019 14:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558560185; cv=none; d=google.com; s=arc-20160816; b=BuZ7xHu9ixPN5mU+S+UCbdhALaPuZOFHmex8j2S1b12gYZRzlQP5AQGrO2t+9zh/kp 5zZCa9XCMqcG8EH/ToM9yrT+AOEsdW0349Vwq3NreL0KN1wwenjWsKKMsiPbWmp0VMZg 3bfDSAraaiXG1tdnZvKIIKZXnbOovHOptXnjVo/UxNeQSN7ILj9E0qlCxI1zBQtrw+qu +LJfAFHHv97bD1Jupsj+qwIlFWMzpqFWoqWl+kYkO4tVGMEJL/uJHtKcJnH3AQvglcR3 zvM8+QItO/fZ6Jiys5r81dj9z3bbDac12Kc44XmfXCiBU4p7HJ6KCQoAlTEDxH+NLI3a GBpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=PLY+CCzT6G7iJEFJBPIdwtB7E513yqHwhuA32U3ib3M=; b=mkPV/02p1cvZPvgqbYiVSHLPvjZWsAO/TWPWBg9/6iovbwVKbgJvyjy2GmiATljfgX i1iw7T0d5LhQ44nKDleDdAaMAD7LtM4fzIS/484hhRKqhAPwZB8l5Fonnz5aV09qNLKO NfeBhevyf2YgO2ZHgz59hj9BcZ5pXJJvtehofO8ZGSu6vYqyi/dTWLtuuqM0t/UUMVZf O5LYgExzlelJfGeBFEeeNOPYJM+kvRUr/b7ik8mX8RZh8wzjhcLD95BIRP0A6yx7Sjtp Kyyq+JMTEjEm4HDxNDlH8zaRRLmP19DrRbltWVBDOiC4wR0VLr2gWoDiuXbVLj+u2eyv igKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si15534398pgs.335.2019.05.22.14.22.49; Wed, 22 May 2019 14:23:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbfEVVUS (ORCPT + 99 others); Wed, 22 May 2019 17:20:18 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:39476 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729720AbfEVVUS (ORCPT ); Wed, 22 May 2019 17:20:18 -0400 Received: by mail-qt1-f193.google.com with SMTP id y42so4250275qtk.6 for ; Wed, 22 May 2019 14:20:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PLY+CCzT6G7iJEFJBPIdwtB7E513yqHwhuA32U3ib3M=; b=b2Vss0LRo5UJ5rnNq1qo8U2qGE/b/EohPq3TyGsUJ3BfWWfCp+7Td75D9fn3l5eIwv wKYzVQb7GZ4CffhKL/Cn5329X7GfiF4JtPnrCm4w5QawQOjHCiwAmADyubM5CVQCPoKl YDh0GScvABYx0BWTkZKm0CfgeBfWpojwBgYOm7Af7gRiUMrhVg4Zt+kU1EtAJliSUyqR qr5qP4xbZyoC9ku0baqmuamOVtGfpr35Yz0dl4OibLtuQI94ybS0f0nl643JqqfklTyr s2ijv8q3LCCcyhmrDgYlO7rLReXLCwf9+BUBgDRRJsA1unazkVcI55QXDXdMSHvw9XSU c/hw== X-Gm-Message-State: APjAAAXI1a3llIDFBXOlPQDxg01XR24p1okyZnAEIA5ee1Sw1OLq8cZI Fgpm/vYYJADP6IX5WXK3D/vA+JGQKttKmTLgX2g= X-Received: by 2002:ac8:2a05:: with SMTP id k5mr59259074qtk.304.1558560017048; Wed, 22 May 2019 14:20:17 -0700 (PDT) MIME-Version: 1.0 References: <1ab818ae-4d9f-d17a-f11f-7caaa5bf98bc@samsung.com> In-Reply-To: <1ab818ae-4d9f-d17a-f11f-7caaa5bf98bc@samsung.com> From: Arnd Bergmann Date: Wed, 22 May 2019 23:20:00 +0200 Message-ID: Subject: Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s To: Bartlomiej Zolnierkiewicz Cc: Greg Kroah-Hartman , Andrew Donnellan , Eric Piel , Frank Haverkamp , Frederic Barrat , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Linux Kernel Mailing List , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 4:10 PM Bartlomiej Zolnierkiewicz wrote: > > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols") the Kconfig behavior is the same > regardless of 'default n' being present or not: > > ... > One side effect of (and the main motivation for) this change is making > the following two definitions behave exactly the same: > > config FOO > bool > > config FOO > bool > default n > > With this change, neither of these will generate a > '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). > That might make it clearer to people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Arnd Bergmann