Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chris Packham <chris.packham@alliedtelesis.co.nz>
To:     dwmw2@infradead.org, computersforpeace@gmail.com,
        marek.vasut@gmail.com, miquel.raynal@bootlin.com, richard@nod.at,
        vigneshr@ti.com
Cc:     linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v2 1/2] mtd: concat: refactor concat_lock/concat_unlock
Date:   Thu, 23 May 2019 11:19:47 +1200
Message-Id: <20190522231948.17559-1-chris.packham@alliedtelesis.co.nz>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

concat_lock() and concat_unlock() only differed in terms of the mtd_xx
operation they called. Refactor them to use a common helper function and
pass a boolean flag to indicate whether lock or unlock is needed.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Changes in v2:
- Use a boolean flag instead of passing a function pointer.

 drivers/mtd/mtdconcat.c | 44 +++++++++++------------------------------
 1 file changed, 12 insertions(+), 32 deletions(-)

diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index cbc5925e6440..6cb60dea509a 100644
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -451,7 +451,8 @@ static int concat_erase(struct mtd_info *mtd, struct =
erase_info *instr)
 	return err;
 }
=20
-static int concat_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
+static int concat_xxlock(struct mtd_info *mtd, loff_t ofs, uint64_t len,
+			 bool is_lock)
 {
 	struct mtd_concat *concat =3D CONCAT(mtd);
 	int i, err =3D -EINVAL;
@@ -470,7 +471,10 @@ static int concat_lock(struct mtd_info *mtd, loff_t =
ofs, uint64_t len)
 		else
 			size =3D len;
=20
-		err =3D mtd_lock(subdev, ofs, size);
+		if (is_lock)
+			err =3D mtd_lock(subdev, ofs, size);
+		else
+			err =3D mtd_unlock(subdev, ofs, size);
 		if (err)
 			break;
=20
@@ -485,38 +489,14 @@ static int concat_lock(struct mtd_info *mtd, loff_t=
 ofs, uint64_t len)
 	return err;
 }
=20
-static int concat_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
+static int concat_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
 {
-	struct mtd_concat *concat =3D CONCAT(mtd);
-	int i, err =3D 0;
-
-	for (i =3D 0; i < concat->num_subdev; i++) {
-		struct mtd_info *subdev =3D concat->subdev[i];
-		uint64_t size;
-
-		if (ofs >=3D subdev->size) {
-			size =3D 0;
-			ofs -=3D subdev->size;
-			continue;
-		}
-		if (ofs + len > subdev->size)
-			size =3D subdev->size - ofs;
-		else
-			size =3D len;
-
-		err =3D mtd_unlock(subdev, ofs, size);
-		if (err)
-			break;
-
-		len -=3D size;
-		if (len =3D=3D 0)
-			break;
-
-		err =3D -EINVAL;
-		ofs =3D 0;
-	}
+	return concat_xxlock(mtd, ofs, len, true);
+}
=20
-	return err;
+static int concat_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
+{
+	return concat_xxlock(mtd, ofs, len, false);
 }
=20
 static void concat_sync(struct mtd_info *mtd)
--=20
2.21.0