Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1100981ybm; Wed, 22 May 2019 17:31:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5zyyaNTto+BdeWph5A5IR0vpYV3SlC7CXXcpPgE7YFvfg4i2l03SmzgU0+IQpyt42bfUg X-Received: by 2002:a17:902:6b81:: with SMTP id p1mr92478509plk.207.1558571476774; Wed, 22 May 2019 17:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558571476; cv=none; d=google.com; s=arc-20160816; b=vP1YUeXZSNCays2A9/P2ZJ6RDxqd9zi1W3Uj//rJgLwkfIoAsgMpPXpVfssnKLwgzr SPj160nd/JzMy0ZrEcDJmRP6g22ozZqkLGgunWHCwmTCRXKwvoM58vEzQFNumCdJTbNh ykRa0a3ow62aAajM+oT4Cq1HnT1OT7c7DHjwUwMeC+9yqM0xY5A1BQ4B6qNg33byBXGe awcX/1Nis7AFi27Fosme+eNmjthk5NpSDyPU072MYmdo072FKHg+zaOByCkGrqBt1890 ep2Bie5hZjAEvasqiPRfwrq2/IomhcLZHNjB26iamnSVU8A/80L2fCyrIin7WsFDfepi u7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=dOoa3XGBowxXrRn/79TVlsXXDEh19dAzEX0kocvAO48=; b=JPGZTNvM06GQNRU9IDx9+f1KGcPruQI5PsglC6uHr7/+/L6SM3xY8D34MSDbWi11d0 VeV4jejy3RZTQ6hiEmpoHjrPnF23jnt5pjjjTZ6vav24BiIMFU9uPE+bvpHn+y8x2Upz wVP15qcbcdFaP/Y4wkXX4+6hfergLQRvdNVJjac0/LPyF/4Za1CY6Vk9s8tKrtFdBBY0 IHCKPzsY5glZtxlScA2ienYHWn/11ZNITULydYMvpl6r3HtqrVcgw9Ct5oCoF06/pKg3 mG3qj9q+JJYVacLgI38Gt2CuO2nyTFMEXPWCtj82tufJtOmf6JjCwPmEEY1/3ESbKBS+ mn9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b16si10733055pgk.387.2019.05.22.17.31.00; Wed, 22 May 2019 17:31:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729172AbfEWA3u (ORCPT + 99 others); Wed, 22 May 2019 20:29:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36592 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727634AbfEWA3u (ORCPT ); Wed, 22 May 2019 20:29:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8D44E15042888; Wed, 22 May 2019 17:29:49 -0700 (PDT) Date: Wed, 22 May 2019 17:29:48 -0700 (PDT) Message-Id: <20190522.172948.1674625854915710265.davem@davemloft.net> To: Jisheng.Zhang@synaptics.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: fix reset gpio free missing From: David Miller In-Reply-To: <20190522175558.59b21673@xhacker.debian> References: <20190522175558.59b21673@xhacker.debian> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 May 2019 17:29:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jisheng Zhang Date: Wed, 22 May 2019 10:05:09 +0000 > Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") > removed the reset gpio free, when the driver is unbinded or rmmod, > we miss the gpio free. > > This patch uses managed API to request the reset gpio, so that the > gpio could be freed properly. > > Signed-off-by: Jisheng Zhang > Fixes: 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") Please put the Fixes: tag first in the list of tags in the future. Applied, thank you.