Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1109636ybm; Wed, 22 May 2019 17:42:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVRiQi+nYfcW0uBdI8/vRHivhgF964mahxRswY56btohaRxccl84zFzpoDQ0uJ8l6of5vY X-Received: by 2002:a63:170a:: with SMTP id x10mr92308581pgl.355.1558572135637; Wed, 22 May 2019 17:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558572135; cv=none; d=google.com; s=arc-20160816; b=Ba+Xyhzk93JYyocfrBhUXou0LIvq2fbLppwtrevi1dqrC7RBFVmy5uglaKmqLVWSLM DrrIN+2dbL81g1vWahKlo2TzyvTDKDJBUENKLZvqLOnwStgvsOwdu6UXAZWz9/c/42DS ASCctFhcTtJ2mRTLYJFKkwmk3W2FBtk2BoSN1wI0oTDoojUJLr3pMSwAFShu83i1vblX rU8jxXAo2PAcFiTQb8bq4uaD6wOnv4Y+kG1QG0lfogQpcvz98aWEB2RMxcjaDxTIKUd6 05P4VKaK0/A+XTZRVUsGHMC+4zDBmcVnFlp8NMdlYXiMg1bkTBLfrnYUwbJ+g9Om8rwD Ux6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=kWJKuAU5NdeVphwrSmxDVC471CAfN1daZGeqzEwBGws=; b=v8oqYg+ughKhFVgOb34mfZN+zaS5XEOd9i1OYdPGYrE4mDhbcLZz+4CGjb0NNGerjC tU1F2aOszaetvBYZi5AYcdPPoynlGTo7ARCseMAkQQ8uctwTm4nNt/Y8fSglibT8WrbO b2SnzeoNKz5LTL9h5Hhntt9Q/AgGZmfAV7YWW4nH1vyWGjQjsVLCOQvpLD9UAvJWR5vP B1uZegq+mnu0dznl148m0IX+Txn06+IwOhFoLLssQw/yfTUxJjSUkBWMkFx74rCGA1bC cfoVIoYV/NNAbfsybpF6pz0jrN4EGWQy/i/x0n6jrWKi2/qigvWKFOibEbWibfNy3hcG vD6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j16si28070188pfn.225.2019.05.22.17.42.00; Wed, 22 May 2019 17:42:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729687AbfEWAkj (ORCPT + 99 others); Wed, 22 May 2019 20:40:39 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:57319 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727790AbfEWAkj (ORCPT ); Wed, 22 May 2019 20:40:39 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hTbmf-0008IM-JO; Wed, 22 May 2019 18:40:37 -0600 Received: from ip72-206-97-68.om.om.cox.net ([72.206.97.68] helo=x220.int.ebiederm.org) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.87) (envelope-from ) id 1hTbmV-0005Z3-Tb; Wed, 22 May 2019 18:40:37 -0600 From: "Eric W. Biederman" To: linux-kernel@vger.kernel.org Cc: "Eric W. Biederman" , Linux Containers , Oleg Nesterov , linux-arch@vger.kernel.org, Dave Martin , James Morse , Will Deacon Date: Wed, 22 May 2019 19:38:53 -0500 Message-Id: <20190523003916.20726-4-ebiederm@xmission.com> X-Mailer: git-send-email 2.21.0.dirty In-Reply-To: <20190523003916.20726-1-ebiederm@xmission.com> References: <20190523003916.20726-1-ebiederm@xmission.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-XM-SPF: eid=1hTbmV-0005Z3-Tb;;;mid=<20190523003916.20726-4-ebiederm@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=72.206.97.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19WBJBSY4O7GYMc5RtcrFp0sTQ3QGKYGbY= X-SA-Exim-Connect-IP: 72.206.97.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa03.xmission.com X-Spam-Level: **** X-Spam-Status: No, score=4.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TR_Symld_Words,T_TM2_M_HEADER_IN_MSG, T_TooManySym_01,XMNoVowels,XMSubLong,XM_H_QuotedFrom autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.0 XM_H_QuotedFrom Sender address is in double quotes * 1.5 XMNoVowels Alpha-numberic number with no vowels * 1.5 TR_Symld_Words too many words that have symbols inside * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa03 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa03 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ****;linux-kernel@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 9315 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.7 (0.0%), b_tie_ro: 1.93 (0.0%), parse: 1.00 (0.0%), extract_message_metadata: 14 (0.2%), get_uri_detail_list: 1.73 (0.0%), tests_pri_-1000: 9 (0.1%), tests_pri_-950: 1.07 (0.0%), tests_pri_-900: 0.82 (0.0%), tests_pri_-90: 17 (0.2%), check_bayes: 15 (0.2%), b_tokenize: 4.4 (0.0%), b_tok_get_all: 5 (0.1%), b_comp_prob: 1.29 (0.0%), b_tok_touch_all: 3.0 (0.0%), b_finish: 0.61 (0.0%), tests_pri_0: 1165 (12.5%), check_dkim_signature: 0.35 (0.0%), check_dkim_adsp: 3.5 (0.0%), poll_dns_idle: 8089 (86.8%), tests_pri_10: 2.5 (0.0%), tests_pri_500: 8099 (86.9%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It really only matters to debuggers but the SIGKILL does not have any si_codes that use the fault member of the siginfo union. Correct this the simple way and call force_sig instead of force_sig_fault when the signal is SIGKILL. Cc: stable@vger.kernel.org Cc: Dave Martin Cc: James Morse Cc: Will Deacon Fixes: af40ff687bc9 ("arm64: signal: Ensure si_code is valid for all fault signals") Signed-off-by: "Eric W. Biederman" --- arch/arm64/kernel/traps.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index ade32046f3fe..0feb17bdcaa0 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -282,6 +282,11 @@ void arm64_notify_die(const char *str, struct pt_regs *regs, current->thread.fault_address = 0; current->thread.fault_code = err; + if (signo == SIGKILL) { + arm64_show_signal(signo, str); + force_sig(signo, current); + return; + } arm64_force_sig_fault(signo, sicode, addr, str); } else { die(str, regs, err); -- 2.21.0