Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1113866ybm; Wed, 22 May 2019 17:47:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRFK8w8H+ff/GG1BOU+dXjl6fNlgOq67s2W4FdskZ0mzeOiV0AxWjsxkVmnEReZxkTI1rP X-Received: by 2002:a17:902:1029:: with SMTP id b38mr53434761pla.72.1558572438819; Wed, 22 May 2019 17:47:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558572438; cv=none; d=google.com; s=arc-20160816; b=OXg3wLB9hB18Ap/19WwjIvsWs5yjcG06MXwMV4EXT5Cn5QDdRT5lyB0b7PTc3mWnw1 nD7pKFLksaJcX81tQEcBU2OxSVuo/TpyFFxM2s1vmMBzbjjN9pRHONtci0I0W+XkZPRR v8es8+tcf4+GiQ6BYsMTR3j6ck4TxeGw3JK4lmb6a3MS2zTe2PlmcyN0VcZs0IeLY73s VF2OwhoQ8/OGi9duP2GR9nCybm+M6xDb0gFFaIRCTcxgNslCABmxquPPNv1C+aO16xsu /wF+5y0AbHqvQb88nsZlCe49mgZSxa4BHPeFmOUA4iDPfHOOExijYZmzY/uXiI04NiUk mm7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:cc:to:from; bh=TOpzzeeEkDaOs2sVzhm6V52Spf3R3YlmVmU9qzvE8Ro=; b=aNvMvnhyUSsLcjc+9p4AYSdpktcXJR3xqbbqSvbssTyHsca4XeR0T9+id0bHE1nXa0 i9K0UOgTxa0sf0c+/oN1VJkQ+1Yuc6Jp5riBjfIpqJowZ/uCJKzXzWMbInFbsmop7t8O MhJEuurrK+B6TYVPjIqSq2+TYpyDUQmjC7KOsKNirECnuLKk+LUesN3pT641s5Lw+DBd uFdA99xjhqkKPOl6/AuTOcB3ynq3lGtIqHwI+rgmA04w1Pjtjtc48rlR238Inu6D0Az+ H17Iu8EtbjJvCoSrvGuTsGx4rpW8ZS6sPbgRnvi0eBxkDfoLNdUL8LIUEA1KWULqyOvt OFRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c9si20739592pls.381.2019.05.22.17.47.03; Wed, 22 May 2019 17:47:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730248AbfEWAn6 (ORCPT + 99 others); Wed, 22 May 2019 20:43:58 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:60244 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729771AbfEWAnO (ORCPT ); Wed, 22 May 2019 20:43:14 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1hTbpA-0004HG-H1; Wed, 22 May 2019 18:43:12 -0600 Received: from ip72-206-97-68.om.om.cox.net ([72.206.97.68] helo=x220.int.ebiederm.org) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.87) (envelope-from ) id 1hTbnb-0005Z3-Nt; Wed, 22 May 2019 18:41:37 -0600 From: "Eric W. Biederman" To: linux-kernel@vger.kernel.org Cc: "Eric W. Biederman" , Linux Containers , Oleg Nesterov , linux-arch@vger.kernel.org Date: Wed, 22 May 2019 19:39:07 -0500 Message-Id: <20190523003916.20726-18-ebiederm@xmission.com> X-Mailer: git-send-email 2.21.0.dirty In-Reply-To: <20190523003916.20726-1-ebiederm@xmission.com> References: <20190523003916.20726-1-ebiederm@xmission.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-XM-SPF: eid=1hTbnb-0005Z3-Nt;;;mid=<20190523003916.20726-18-ebiederm@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=72.206.97.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+NSKN9kc9oOZ73p1G7C7vPr8p5OGew4lA= X-SA-Exim-Connect-IP: 72.206.97.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa05.xmission.com X-Spam-Level: **** X-Spam-Status: No, score=4.5 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,TR_Symld_Words,T_TooManySym_01,XMNoVowels,XMSubLong, XM_H_QuotedFrom autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 1.0 XM_H_QuotedFrom Sender address is in double quotes * 1.5 TR_Symld_Words too many words that have symbols inside * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa05 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ****;linux-kernel@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 1314 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 2.7 (0.2%), b_tie_ro: 1.76 (0.1%), parse: 0.90 (0.1%), extract_message_metadata: 11 (0.8%), get_uri_detail_list: 1.14 (0.1%), tests_pri_-1000: 13 (1.0%), tests_pri_-950: 1.30 (0.1%), tests_pri_-900: 1.06 (0.1%), tests_pri_-90: 18 (1.4%), check_bayes: 17 (1.3%), b_tokenize: 6 (0.4%), b_tok_get_all: 5 (0.4%), b_comp_prob: 1.77 (0.1%), b_tok_touch_all: 2.6 (0.2%), b_finish: 0.56 (0.0%), tests_pri_0: 1247 (95.0%), check_dkim_signature: 0.61 (0.0%), check_dkim_adsp: 2.5 (0.2%), poll_dns_idle: 0.86 (0.1%), tests_pri_10: 4.1 (0.3%), tests_pri_500: 12 (0.9%), rewrite_mail: 0.00 (0.0%) Subject: [REVIEW][PATCH 17/26] signal/arm: Remove tsk parameter from __do_user_fault X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The __do_user_fault function is always called with tsk == current. Make that obvious by removing the tsk parameter. This makes it clear that __do_user_fault calls force_sig_fault on the current task. Signed-off-by: "Eric W. Biederman" --- arch/arm/mm/fault.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index 58f69fa07df9..324def0279b2 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c @@ -157,10 +157,11 @@ __do_kernel_fault(struct mm_struct *mm, unsigned long addr, unsigned int fsr, * User mode accesses just cause a SIGSEGV */ static void -__do_user_fault(struct task_struct *tsk, unsigned long addr, - unsigned int fsr, unsigned int sig, int code, - struct pt_regs *regs) +__do_user_fault(unsigned long addr, unsigned int fsr, unsigned int sig, + int code, struct pt_regs *regs) { + struct task_struct *tsk = current; + if (addr > TASK_SIZE) harden_branch_predictor(); @@ -196,7 +197,7 @@ void do_bad_area(unsigned long addr, unsigned int fsr, struct pt_regs *regs) * have no context to handle this fault with. */ if (user_mode(regs)) - __do_user_fault(tsk, addr, fsr, SIGSEGV, SEGV_MAPERR, regs); + __do_user_fault(addr, fsr, SIGSEGV, SEGV_MAPERR, regs); else __do_kernel_fault(mm, addr, fsr, regs); } @@ -392,7 +393,7 @@ do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs) SEGV_ACCERR : SEGV_MAPERR; } - __do_user_fault(tsk, addr, fsr, sig, code, regs); + __do_user_fault(addr, fsr, sig, code, regs); return 0; no_context: -- 2.21.0