Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1577615ybm; Thu, 23 May 2019 03:29:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrgxhGGGu4RoS3A1kvlle2jt8tpFG6YbSoV1S85iW3ee7z9I6ZIgqF4sUUpLfMmUW7ibYe X-Received: by 2002:a63:930d:: with SMTP id b13mr84172140pge.18.1558607379922; Thu, 23 May 2019 03:29:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558607379; cv=none; d=google.com; s=arc-20160816; b=NxM9QpqAl1M1JKtc0OaydE0syXdpafW4m3HszdxLRKNW1/HuwAKg2cWUdxD+WPm8dJ Mo41AhRDk83QTzH9HWGIkWqeKuHOhNnBznZrOKvjC0Joe33gMG28BCWUSSVBc810oHG9 jEc7o1Myf1cntQqU0/XUjCw4x49KcVs9grEhOoTFDpJF8EhJOIIj1Fve+Hww134L6yae vSz0ZaWUKfc51pO1pAMW36MIyZBHC9EwWH+z1jALoJBPYhZtfQVv1s6e4tA4Ms6KRKWz VQy6BVU7ohivq+o8G+XtjLQ89lWKF4YhVqDKr+Daqk/jdOpzAuOOET4jxq4IRw2UGtU4 bu0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=tkpMlI1VJs8pP20MTO4CpZeB7Z4l8OkaOkg+PHg5oMg=; b=Y6dKb9naYBnqLP/Vnc15H6tFiXo7Huk69m+Ieyfdc5Dw4YvidEB5gMpy6jSWD+cFLt 9gaAdFL4e2Dy3og942LVZxdoH0ILA+GMvy9YKPVsp9AFQxFqL6JShRj5mqY9hBpkyhfd kk+nBbtDvpfp2T8shevTiS+0oeik8flsL2694TiZxPFx+vVLVCQHDHtyZKRymgboBrO2 pL3k8gFzfTNw1/2uTtIncg6TJxW5oEc+q2puqBJ/Vqtrqg2WBu8+zjSLytTbyGWvHAX/ FxmTTTyGRPsJjroSjLkksoAnBcNi6E2KYdFy5m99QB/R7uUQhZIFb7muHzR+cMs6t+Kg neMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i38si30322518plb.132.2019.05.23.03.29.25; Thu, 23 May 2019 03:29:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730396AbfEWK2V (ORCPT + 99 others); Thu, 23 May 2019 06:28:21 -0400 Received: from foss.arm.com ([217.140.101.70]:42882 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729972AbfEWK2U (ORCPT ); Thu, 23 May 2019 06:28:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A688341; Thu, 23 May 2019 03:28:20 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1AA03F718; Thu, 23 May 2019 03:28:15 -0700 (PDT) Date: Thu, 23 May 2019 11:28:13 +0100 From: Mark Rutland To: Arnd Bergmann Cc: Linux Kernel Mailing List , Peter Zijlstra , Will Deacon , Albert Ou , Borislav Petkov , Catalin Marinas , David Miller , Fenghua Yu , Heiko Carstens , Herbert Xu , Ivan Kokshaysky , James Hogan , Russell King - ARM Linux , Matt Turner , Ingo Molnar , Michael Ellerman , Palmer Dabbelt , Paul Burton , Paul Mackerras , Ralf Baechle , Richard Henderson , "# 3.4.x" , Thomas Gleixner , Tony Luck , Vineet Gupta Subject: Re: [PATCH 00/18] locking/atomic: atomic64 type cleanup Message-ID: <20190523102813.GC3370@lakrids.cambridge.arm.com> References: <20190522132250.26499-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 11:18:59PM +0200, Arnd Bergmann wrote: > On Wed, May 22, 2019 at 3:23 PM Mark Rutland wrote: > > > > Currently architectures return inconsistent types for atomic64 ops. Some return > > long (e..g. powerpc), some return long long (e.g. arc), and some return s64 > > (e.g. x86). > > > > This is a bit messy, and causes unnecessary pain (e.g. as values must be cast > > before they can be printed [1]). > > > > This series reworks all the atomic64 implementations to use s64 as the base > > type for atomic64_t (as discussed [2]), and to ensure that this type is > > consistently used for parameters and return values in the API, avoiding further > > problems in this area. > > > > This series (based on v5.1-rc1) can also be found in my atomics/type-cleanup > > branch [3] on kernel.org. > > Nice cleanup! > > I've provided an explicit Ack for the asm-generic patch if someone wants > to pick up the entire series, but I can also put it all into my asm-generic > tree if you want, after more people have had a chance to take a look. Thanks! I had assumed that this would go through the tip tree, as previous atomic rework had, but I have no preference as to how this gets merged. I'm not sure what the policy is, so I'll leave it to Peter and Will to say. Mark.