Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1716991ybm; Thu, 23 May 2019 05:48:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyh7y1XOtjY2ype24Az+/IA8u8fpC4Y63Clto7WHHveVf9MpeUdixIvhpswUwWGb8JcS38g X-Received: by 2002:aa7:8dc3:: with SMTP id j3mr104432993pfr.141.1558615712805; Thu, 23 May 2019 05:48:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558615712; cv=none; d=google.com; s=arc-20160816; b=L78KUftEuA4luiGTgb3C2imoOsoB1OMNs5bdB9EDsQAsO+54uMPaW1mG/7BWm8gcdS BCQ2dHxRpio2LShmpU3Xz+xSZGSCUkJxPTM7wagz9GDaFZxbZ4lTZ7ES6sFrpz3xXWvQ 12Od2f0a8YxmQBQIFyvuOSHVgJYtKTSFNtztA//NROKZLcGLrBvp0AIeIP1Q6MJhVuXI pWqdf5TEu9rYdir7p1an+gRQ7dnL1tAq417D8pled8+lwaiyUZ/xZRSYwfdqVLBC0SFD HLroe+YqD0qSSemfnvparWbk4+SKhAqseqarS3Pwdd4GjaeBOVogvQd8L5MRUJdkMdBj ES2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=LzVnTmu8dj65YfOhaK3e24Jud9UbUMwKqG4mJie7xHc=; b=BEL4EbIWVuANxxV7rHme3iTfqa6kQWx6aOKDwbrdTY4jolFdGRqH6N4bvUd7EvQBbo 4YTlzy3CM+uknlAj9nuUJodZcHUj8MCE/FD+F+IwsCTdnYxncpYuKsHsGEUFsuC5fAom L9RmKafQXySgY+ShKglGcKe+hIb5fo4S0O50+33YaMA9y6qMzk3lXoQHub7uajtvkRVf Wtd6yi8Ayg4S0esRi+l4lHLy9Z8ZJF6dCDUM8v3WX/WQe65d3ek5LgWIU/75WHLqFqaR ezRFAL9vmr8HMxNrO1R4JZ340WfyGxBX98oIxHfZxYWWcUtV0PybscMhEiTJyYqvfv6f ulyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si21946614pgf.337.2019.05.23.05.48.16; Thu, 23 May 2019 05:48:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730650AbfEWMpe (ORCPT + 99 others); Thu, 23 May 2019 08:45:34 -0400 Received: from verein.lst.de ([213.95.11.211]:46617 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729698AbfEWMpd (ORCPT ); Thu, 23 May 2019 08:45:33 -0400 Received: by newverein.lst.de (Postfix, from userid 2005) id 139CB68AFE; Thu, 23 May 2019 14:45:09 +0200 (CEST) Date: Thu, 23 May 2019 14:45:08 +0200 From: Torsten Duwe To: Laurent Pinchart Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Andrzej Hajda , Icenowy Zheng , Sean Paul , Vasily Khoruzhick , Harald Geyer , Greg Kroah-Hartman , Thomas Gleixner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] drm/bridge: Add Analogix anx6345 support Message-ID: <20190523124508.GC15685@lst.de> References: <20190523065013.2719D68B05@newverein.lst.de> <20190523065356.0734568BFE@newverein.lst.de> <20190523075041.GC4745@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523075041.GC4745@pendragon.ideasonboard.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 10:50:41AM +0300, Laurent Pinchart wrote: > Hi Torsten, > > Thank you for the patch. Thank you for the thorough review! > On Thu, May 23, 2019 at 08:53:56AM +0200, Torsten Duwe wrote: > > +{ > > + struct anx6345 *anx6345 = connector_to_anx6345(connector); > > + int err, num_modes = 0; > > + bool power_off = false; > > + > > + mutex_lock(&anx6345->lock); > > + > > + if (!anx6345->edid) { > > Could the chip be used with a hot-pluggable display, or is it guaranteed > that EDID will never change ? The chip itself is capable of (e)DP hot-plugging, so the signals suggest. See the previous discussions about what to expect on the output side. Currently, the driver does not handle hot-plugging. > > + > > + err = drm_of_find_panel_or_bridge(client->dev.of_node, 1, 0, > > + &anx6345->panel, NULL); > > + if (err == -EPROBE_DEFER) > > + return err; > > + > > + if (err) > > + DRM_DEBUG("No panel found\n"); > > Shouldn't this be fatal ? No, basically same as above. On the output side, there can be a panel, another bridge, or some eDP plug. If the DT didn't explicitly specify a panel or a bridge, we can still generate video output as soon as there is valid EDID data. Your other points went straight onto my TODO list. Torsten