Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1730226ybm; Thu, 23 May 2019 06:01:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyrcsNuS8eq81FBR4BUJoij8KxUHaOP/UudrZkH8d4TBAe26wDtzdO4+4/q8DI7YJ8sJ1i X-Received: by 2002:a17:902:728f:: with SMTP id d15mr24020628pll.167.1558616491614; Thu, 23 May 2019 06:01:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558616491; cv=none; d=google.com; s=arc-20160816; b=s3WQGTIW2K0+5Mpn/Y1nhA+v6tGcg5Z4Tbzg85d7Q+3BMYXtCJJ46LAZAl1eExtCyL mMoE8EoRe1nryNFRK3cPWQ5A0+Yvr/t3vUmEOrtckK3IkdyGhwTehbkIL6zx/h8ci7y2 57Y6m+NG2RZF8FlooQ4LPB7gECK7SZjwTAbVF/wrN5O9mXN4LQFZj4/Okzh7np9HKC59 8mLQZ+CQAeJTx8ClIAFVlaeSwXc935oCXcr56k/T3WCgGmQRyiwAcPQDmM/zDxCEU1dw V4Ma4B+o6OXBJJi23JBYhWnFw7o11f3xYywbxwv52rBfpKTEh2bPai7KccDQ7BEtrU8x rduw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=AIHtdpz8zuPAe1w5Wj0qD8ztjrVfXmUXjGesLzTIxWg=; b=Cy9xtBYcYF/+INRzx889UcLFrTtUV4HbgJbHBJjD61POCVgVnQbewf9YE+ZUn7hKgF ikQDnfojmtf6hDaxIZB5L7SF2ewr0V1cZ8bEcLQy2gr7BEGLR2lZT6Wb8i4bsQ5sG9oI VgRU7rlUeK5rNGYxbBtWxElVMrwbINGE/1AZ0YOcdcnMsePFOLRRKTynJDUNZ/nTu9fZ g1ABYk/HsenSUljZC/0JpKnr94LhkZ4ApvAZZiqIkhI1GXDqwWy/ygrjHkSLkvicL09D 5uLxuJupAVZ+VSYCfcqlMcA6IRBgEY+k4hrUYr3Rd8Q7pTwhfN9a3ULWxkJlW1nOwiBx CKMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SyfqgaQv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si27588256plt.9.2019.05.23.06.01.13; Thu, 23 May 2019 06:01:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SyfqgaQv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730825AbfEWM7L (ORCPT + 99 others); Thu, 23 May 2019 08:59:11 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:44035 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730495AbfEWM7K (ORCPT ); Thu, 23 May 2019 08:59:10 -0400 Received: by mail-lj1-f193.google.com with SMTP id e13so5344264ljl.11 for ; Thu, 23 May 2019 05:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AIHtdpz8zuPAe1w5Wj0qD8ztjrVfXmUXjGesLzTIxWg=; b=SyfqgaQvyX9AF92ypS8wsVUTibefaicVMjStGpBVJbOAZBkTf3H4oVOuN7aiIDeqee VO9xAbEo90mh6A5I/g0kTHnaF4aqDpuXZbaM5Wkaa7gboy6jKIxQBiERs4ri4fDZv/SU mVb/JQ4GzjVfgwH/x9srvFWh2Mj4XsfNhdVhen3iWJPxOSv7RpUY8egSrZQ1ypjIei3n NioV09IYq/vH6KlC6RZQHphLrr9mKJqhj5jfwQSaWEn6TCK/EzQ7NDfhzk0Y+0dSHq4I Wxh/roOaQBbHuBUK1NswKxEBv1IoRYB3NLE9NpPMcGaR9tYNIxV6drm3UWMf4nZfe1EU Ucyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AIHtdpz8zuPAe1w5Wj0qD8ztjrVfXmUXjGesLzTIxWg=; b=mGI3wytQgRdt5h0lkF0UshEeksNVNm7iu1qStj9jNRr/jowonTEhHAfrckqnr9V9pX Hu3cYIlVdGJgP+v+aEBWBz8tV/q4fzBXZdlgCRSEzyTBgffcFvUBn2DWL2uEahUkgc1N 2hn5L68Ykh2sgIYditcvqKCFC9E4Gt9f0q8uZYvSRBCjo1S4aJRlc560cadnYdC1crVQ xsh/UU7Vgp8E6Up4XIGnU1USBOkrVKSTCCOBZWZfwdUZLrCl8Rf6PpPA5SwqN/2WVzgk LwGylpyrs4dFxXb6xhMMtdA/rk9kPbndOBwD5KJnhQFD8T2oz+s13wEtQfd9JGG160iw RxxQ== X-Gm-Message-State: APjAAAWog+pjJcumgcdicW2LGVQo7hmJP4jAwo2Mw3VrMGFTv4TS+5nL LcqnPstSaBu51GFBkHT/RlGczmjhQmcj7RfK3hE= X-Received: by 2002:a2e:9a4f:: with SMTP id k15mr41998151ljj.159.1558616348807; Thu, 23 May 2019 05:59:08 -0700 (PDT) MIME-Version: 1.0 References: <1558366258-3808-1-git-send-email-jrdr.linux@gmail.com> <20190521085547.58e1650c@erd987> In-Reply-To: From: Miguel Ojeda Date: Thu, 23 May 2019 14:58:57 +0200 Message-ID: Subject: Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero() To: Souptick Joarder Cc: Robin van der Gracht , linux-kernel , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 10:18 AM Souptick Joarder wrote: > > Miguel, Ack from Robin is missing in linux-next-20190523 when applied. Thanks for the warning! I wanted to review first but didn't get to it yet. Taking a quick look now, by the way, why does vm_map_pages_zero() (and __vm_map_pages() etc.) get a pointer to an array instead of a pointer to the first element? Cheers, Miguel