Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1867468ybm; Thu, 23 May 2019 07:55:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRo34aJ5hMN9euPwlDmNr9z1LbJ9BvQiojHzvGpiMOPwrYf5DCBI0NY/oDuGNZOSs7C6U1 X-Received: by 2002:a65:4b88:: with SMTP id t8mr98474734pgq.374.1558623319903; Thu, 23 May 2019 07:55:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558623319; cv=none; d=google.com; s=arc-20160816; b=P+mc0x7iC5OjL7mFrisv9QXPdgoRjedt9A52ajF2p/Gv2F4UzAiP5SKwwOX7HbtQcF n4USQAiVmdIjQnsLPlhimsBwPBGkfbsFCX5XhrHHo/HZG/YDV7uAIXyPFeyICaeW0pJA aZphoVG86EVY1xYOBz8kzN/eEM/KsP8hyNRQKkmnm35vzwQuCVOq2BRLMBTE9XAKY4SA Sco5+1AJ86scd8jK2Eo4azZNbcnpCFd6T038b84wnI/Yonql/LwP2+tTxT+srzOFtwTe B3zewYYKG8zWsWmtxekNm014lTy/gnWoo9kosnxJTXY08DHN1ZRDxFfb7uienUMTu1xr yBoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KuauVzjJswarfobGLMx62HbVwFkgBXXbK672bwB029A=; b=NSVGhfBika+CAZKXJbkVxFhScXOFKPWR8+X2gE7Wx3J9ZEzrSebSrsmA2iXR3ijJTE RNVM3AmHg2vG2LHda3roO5++p/aOymnZtggVwL4CW+tPKytAi+jyHepjm6/2IQFRU9po KZJdkGPzZm0x1f3sxeJuljYgikVQ8dg5lmBnvOw57fy3lVXsk7Lj3bacbgLBPHHzgxl0 zUtleWdZCjWHZOxI+dPrfsKT0S84hymZJoQl3QmWFWalIpaCRj2RKjsaVeQtdHZIW+mT 7uo+mlsqro3alOSef15xDI8lhHz8SsoFiRX7mJOJGizDQ5CURp8JNjzreSK/KH9OK6QN lDsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Sl9c/IVp"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g7si29552717pgb.109.2019.05.23.07.55.04; Thu, 23 May 2019 07:55:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="Sl9c/IVp"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730960AbfEWOxT (ORCPT + 99 others); Thu, 23 May 2019 10:53:19 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36454 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730957AbfEWOxS (ORCPT ); Thu, 23 May 2019 10:53:18 -0400 Received: by mail-wr1-f65.google.com with SMTP id s17so6646601wru.3 for ; Thu, 23 May 2019 07:53:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KuauVzjJswarfobGLMx62HbVwFkgBXXbK672bwB029A=; b=Sl9c/IVpkPxfdQFvyhEaxuRn1gyGyncWJpElpyHVCz0PT2Jqa0CZ78ux8e4bvp/UDK 9VGVElVF1dfjJUkX9iP/zAXDhTRf5rhu5AkZfZwIPthOEGQLaemCwa7mO+bs7KhepM9W b/Q1OdXSLuvvNGxjKUhlYBAIKZPFsLK2aloT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KuauVzjJswarfobGLMx62HbVwFkgBXXbK672bwB029A=; b=jwaG/mpmt2Jhdj8gKtCTBbR2nPFvG+DyQj1d5uTryGwUY78tGI99EFoN61H1FFCWJz Zg02MYSXvnOshojAlAOalDr7J4gCtOVRUs/i40Ng2BzTXbSc9Z7umeNrXKgFmqZWgI0v AS1K/uh312iuVu4utf4h1QznixZjmiYnHA6vxDvkT1I+S0giNNPFAMlZ33smAXyyd6xl MoquwzjTKknMHgNkRjbLmVu6BielZvcNWHP8LPQhA7wCV7XRPx2OwM8kzo0rUfLx32FU ELyZ4co70J/xed8UGbAEEJKqjPi79GcdPgpfridwEc4XQfY3ZHqQclB0RukqTbr5JVwv TXpw== X-Gm-Message-State: APjAAAUQnHhDbvNX9SklJxY6rVH739xlZIClmorU1kbqhMbUvDuZFKs/ lHdoho7yc3vOlkQqmU7BIqlxSw== X-Received: by 2002:adf:aa09:: with SMTP id p9mr6578948wrd.59.1558623197442; Thu, 23 May 2019 07:53:17 -0700 (PDT) Received: from andrea (86.100.broadband17.iol.cz. [109.80.100.86]) by smtp.gmail.com with ESMTPSA id j206sm14293686wma.47.2019.05.23.07.53.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 May 2019 07:53:16 -0700 (PDT) Date: Thu, 23 May 2019 16:53:09 +0200 From: Andrea Parri To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , rcu@vger.kernel.org, Peter Zijlstra , Will Deacon , Mark Rutland Subject: Re: [RFC PATCH] rcu: Make 'rcu_assign_pointer(p, v)' of type 'typeof(p)' Message-ID: <20190523145309.GA18692@andrea> References: <1558618340-17254-1-git-send-email-andrea.parri@amarulasolutions.com> <20190523135013.GL28207@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523135013.GL28207@linux.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > TBH, I'm not sure this is 'the right patch' (hence the RFC...): in > > fact, I'm currently missing the motivations for allowing assignments > > such as the "r0 = ..." assignment above in generic code. (BTW, it's > > not currently possible to use such assignments in litmus tests...) > > Given that a quick (and perhaps error-prone) search of the uses of > rcu_assign_pointer() in v5.1 didn't find a single use of the return > value, let's please instead change the documentation and implementation > to eliminate the return value. Thanks for the confirmation, Paul; I'll prepare the new patch shortly... Andrea