Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1965446ybm; Thu, 23 May 2019 09:15:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqySZFMQkBH+n9iWiSJPfFqL0YNdkRdPV0/5JMI6kOa0qwjRoFD9aHlB2bVTrLtxBAyOhawM X-Received: by 2002:a62:6241:: with SMTP id w62mr44807668pfb.226.1558628157610; Thu, 23 May 2019 09:15:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558628157; cv=none; d=google.com; s=arc-20160816; b=XMacjzlsRh7MA0ya/C6xQRR5svuB8lxZV40NH37t/MRN6HdId8PtZe2bxBZiJv3wIC XzKurmBRAyBPpM8HVd+Bh7NtyEq49KJT3UJGca8savLVKjy+hEFSliGvyDiMkQ/JRMuQ uFbot8bvhIF9SQ/jbAEq9/YpXkp561cnAaZjMUmJjT6FGp88FgFp17dNkuZAgBzjE2Y6 MJWEWV3LY5t23PAk8AOKAWiLdvKIBc1+wQPmJp8yB1VCMYOTolIqw6R+zcGwXgHIPhOX R+IVJhoVhDwSxvTMilB/gpxfJWOMHdWMAwvaF4swZegrq9aX9/0Ek/m3/0PPSDKDbSsy Bcrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ChOvj3jye7+dpjGXsz2+0k7g2KFNVnSuZwhDWWMHHmo=; b=R1boRvA9AcYPWJlSwvmJKQLrKyMpAvfjL+96GMeY8TkNjE0hj+YyAXS7GOZ7cyAgvR PrajU2n7ALfVVr+aHRT6POIKLqiUSoMW/Simzv+7HXteat6npcCks/Ectyy/WFjA2APd CXFBqFQ6m8jhtd5LXtXJ9bHOpVwNAOdSNjC7Tj5622OJHw2p4eS26v8UG5qffmzaIvog siPA+QgQy0Z+xPE99/VXE2pDF0gBc7q1pnGVLsWrZ0jEqFONzU2NT5hdelwgvdmZFwP/ 0Od2wKLPjQaiqkFtuiv2sqDqf9rCYlOhvB1aNtU7Ps6l7qS14cHzXrQaoq0VwzMoZys3 4yVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si32081013pla.380.2019.05.23.09.15.41; Thu, 23 May 2019 09:15:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731241AbfEWQNu (ORCPT + 99 others); Thu, 23 May 2019 12:13:50 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48220 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730782AbfEWQNu (ORCPT ); Thu, 23 May 2019 12:13:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 15F221509A10C; Thu, 23 May 2019 09:13:49 -0700 (PDT) Date: Thu, 23 May 2019 09:13:48 -0700 (PDT) Message-Id: <20190523.091348.50431813829161038.davem@davemloft.net> To: maxime.chevallier@bootlin.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, antoine.tenart@bootlin.com, thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com Subject: Re: [PATCH net] net: mvpp2: cls: Fix leaked ethtool_rx_flow_rule From: David Miller In-Reply-To: <20190523084724.14639-1-maxime.chevallier@bootlin.com> References: <20190523084724.14639-1-maxime.chevallier@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 23 May 2019 09:13:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Chevallier Date: Thu, 23 May 2019 10:47:24 +0200 > The flow_rule is only used when configuring the classification tables, > and should be free'd once we're done using it. The current code only > frees it in the error path. > > Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support") > Signed-off-by: Maxime Chevallier Applied, thanks Maxime.