Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1983031ybm; Thu, 23 May 2019 09:30:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9pz3dC6Czm4Pv0XE67ERgFXpSLagIkvng4E9+jGnzg4T3+GqyDGt/zTyDa/6TTl0AWFWY X-Received: by 2002:a17:902:d896:: with SMTP id b22mr86664769plz.40.1558629051909; Thu, 23 May 2019 09:30:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558629051; cv=none; d=google.com; s=arc-20160816; b=iV33RVueSlOjkH2Hlskil2QK9+AgyCDXoq5UOGv+c8y+Na9Rmqan4snqciIA+77WNz usm4Q1wqLGn7TlowxY1J5xqdT+MkK06lNc4IONyypvgd01oscnUzmJ8Nz0dPLLzpIkkX egzHEfaUKoGlC7zFq+EnHwhcSLuBn1J5qUXmfSnUb4YZsLQPCCXXHyc+6rh10sthCVfa elZzIA3zWwTT5qykJ1bzHHrgIIKFxDjeKzUPnNdzvXjoEzlCye4JAvualSJczTZzxzdE gMPLWsEMOjecLv29H968OSblL15z3nP11YsO00SxsMGFIqfcJKJFyUW7xGmzYuF/rOpO SM7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MuEDVw/eAhdV4CWO0ka0gzUbpS6xk9uURHsaoGKtR4M=; b=sGiVMjFHSrwAhoDw2bHGtkI5Ce0r1ODPlSKRFx4btXA/aT1Y3AuSVKdScOjUdgZwZ+ /VIUQuvP5LemLwxghMyYyxf3ohnSOjpn1Nmf5CO8sViR7VLgILNkU1excQ2fWiQQ7ofX fkDYnU+tqNNmqxTWRX6otupNJ/AVQXKAbvBh3Z117xB6bnsYRgEAtZ6Bi2PpNEoxkVps 35qN9T9gCQdm11O+H1z2Z3yDeoj6EPcFc/3Tir4HCGJstSEPll+9bfWcv02upf+ojIER 27OVk6zQYTAnM7MNI/H5vH/eNAX0FkI5aQuLF8/72Mypsu/dM2xpn1mxzCIMBH3SYI7W bxFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si22957183pgp.343.2019.05.23.09.30.34; Thu, 23 May 2019 09:30:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731349AbfEWQ1u (ORCPT + 99 others); Thu, 23 May 2019 12:27:50 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:35648 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730987AbfEWQ1u (ORCPT ); Thu, 23 May 2019 12:27:50 -0400 Received: from relay12.mail.gandi.net (unknown [217.70.178.232]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 0E9623A2EF0; Thu, 23 May 2019 15:48:39 +0000 (UTC) Received: from localhost (lfbn-1-3034-80.w90-66.abo.wanadoo.fr [90.66.53.80]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 3ED5E20000A; Thu, 23 May 2019 15:48:30 +0000 (UTC) Date: Thu, 23 May 2019 17:48:29 +0200 From: Alexandre Belloni To: Richard Leitner Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] rtc: s35390a: uie_unsupported and minor fixes Message-ID: <20190523154829.GW3274@piout.net> References: <20190523115451.20007-1-richard.leitner@skidata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523115451.20007-1-richard.leitner@skidata.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/2019 13:54:47+0200, Richard Leitner wrote: > As the s35390a does only support per-minute based alarms we have to > set the uie_unsupported flag. Otherwise it delays for 10sec and > fails afterwards with modern hwclock versions. > > Furthermore some other minor changes are made. > > All patches were tested on an i.MX6 platform. > > CHANGES v2: > - use BIT in "clarify INT2 pin output modes" > - add "change FLAG defines to use BIT macro" > > Richard Leitner (4): > rtc: s35390a: clarify INT2 pin output modes > rtc: s35390a: set uie_unsupported > rtc: s35390a: introduce struct device in probe > rtc: s35390a: change FLAG defines to use BIT macro > > drivers/rtc/rtc-s35390a.c | 55 +++++++++++++++++++++------------------ > 1 file changed, 29 insertions(+), 26 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com