Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2168875ybm; Thu, 23 May 2019 12:29:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxS9mS2WXgdnuIgWym2dJ991A5sl3xCsQLvHyJ5WfTo4c2DpmJ6cWyJ3CMcFlUHuCwHn9Qy X-Received: by 2002:a17:902:e48e:: with SMTP id cj14mr95173495plb.299.1558639780229; Thu, 23 May 2019 12:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558639780; cv=none; d=google.com; s=arc-20160816; b=SL12oubh7Mypj7FMv9ERETJgB3/dncrQOCYAtmoRkPd3poSmEz9+EAN8ZBqJCy+k4M TAfrrSFY95ydeh+DSyf4rcN54WN+ve2g+cvEHavbpHgnYIERpRDwK6t28IksGHjALMqs UNpeie0PCx8jEm/1ARAZ+8R2hSYA0CMo0bQEBLknoNiGzfEFmHHNentbMSQKMQB90YPJ Jo80WjJTTZLMn7Khi3fKy7s1AOnf+Hd4ww6sKwPteuNDrZT2uUSnJ+lL/it6ITMf45uf M/VZSljmG7XERspYA5mr/DtbRJpg11Q11GUT/4diTfDC5l/IuRn7GXQus/8afYyolHjx IyOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qKiyTAm5V0J7hWQitkz57xa5MFgq0QwsD8ashS3tz3g=; b=mo43rHmF7thJi2Jhd94wp7UGjzkxsOv1DC17aww1FnBINFRW0bTbatVGKO05j5oupQ I4AHzTGe7LXoiuz6mZfEVEgkbxtuJCmTHm3X+NGcJiys6z8fGWLg4t5yLIBMAmPoJprO ZX2dBiTBiZILyNFd2vDXjEv0l9A71wgS7fvD6P5rlj0VSaQW9g6GJbGA6z8467ZYoNO2 exngtSw1pnbO+VmLFSeTU2wLi57kkL7dP5ni9dkd6yqk8lYzn0JhW1f1p0XaevRS2mjY EZyse7JB0gR04gQShV1+6jfdekwLiAy23kD+ucHTeqkcO1ZUBns2Y94JU4M9vsD9NV4r 0S8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QWnIUEEP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b186si331743pfa.255.2019.05.23.12.29.25; Thu, 23 May 2019 12:29:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QWnIUEEP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391743AbfEWT2M (ORCPT + 99 others); Thu, 23 May 2019 15:28:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:40648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391727AbfEWT2J (ORCPT ); Thu, 23 May 2019 15:28:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38499206BA; Thu, 23 May 2019 19:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639688; bh=ZKAWL+TfWyCxI4eR1wQK7z52Plma/GdthdPmEGtd6Z0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QWnIUEEP7+z8+fj8jCbybQpQqEysyFm0wsDIuqSvr8xkDXIH43luv98vrvzEtP3f0 273knjPXjoVnvwc/JDAYvthhR7LMUE3h29Mek2NwwZp/xpD6Mqt9Y+kkVbnKxUspix UOr8qGHM2BLsAeN3TZOCGFCMvcd3Ax6N9Mj5GBV8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Olga Kornievskaia , Anna Schumaker Subject: [PATCH 5.1 058/122] PNFS fallback to MDS if no deviceid found Date: Thu, 23 May 2019 21:06:20 +0200 Message-Id: <20190523181712.487406914@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181705.091418060@linuxfoundation.org> References: <20190523181705.091418060@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olga Kornievskaia commit b1029c9bc078a6f1515f55dd993b507dcc7e3440 upstream. If we fail to find a good deviceid while trying to pnfs instead of propogating an error back fallback to doing IO to the MDS. Currently, code with fals the IO with EINVAL. Signed-off-by: Olga Kornievskaia Fixes: 8d40b0f14846f ("NFS filelayout:call GETDEVICEINFO after pnfs_layout_process completes" Cc: stable@vger.kernel.org # v4.11+ Signed-off-by: Anna Schumaker Signed-off-by: Greg Kroah-Hartman --- fs/nfs/filelayout/filelayout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/nfs/filelayout/filelayout.c +++ b/fs/nfs/filelayout/filelayout.c @@ -904,7 +904,7 @@ fl_pnfs_update_layout(struct inode *ino, status = filelayout_check_deviceid(lo, fl, gfp_flags); if (status) { pnfs_put_lseg(lseg); - lseg = ERR_PTR(status); + lseg = NULL; } out: return lseg;