Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2168977ybm; Thu, 23 May 2019 12:29:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhv+cXAap1Sz8I7gokOPJUlJDJz+1R1w2qcgWFM/DgENJKBSpshl31OSW2+F3RU97IpPCW X-Received: by 2002:a17:902:8508:: with SMTP id bj8mr57915125plb.79.1558639787518; Thu, 23 May 2019 12:29:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558639787; cv=none; d=google.com; s=arc-20160816; b=GIYQnY3UoRS7NWCwa9mhzXIBWd6B0RXLphzsOUgE6wF5i6820UCE87wiUIswrpWNTV E/+sWbL2N3gOTZ5/knnSdOVEel6DtUfYTnqe75tO6rWuTtbH4E+ErlJG0Qf1jlx2c21f obTayLflFjg09qZ4CG4vnB+pbMx38OTcj34XG6zQPwQ15EXfO8QUhvffhIX6RBiuqwV9 hLS4JgRdQly5mR/tNZVmGZCHUpZj86/Gse+RF2Ios0JTd2gFI+Je6QYzxKrdbRUImbLq FILIPH7QJPeuRIOg0KDJ5AEsmMQHvHY+xmIzXBn8qmw5c8lQHJafXnj+frbIGL+IRAD+ fdeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NyVAp5iaSjoYPnOMINSYrbLHbAIlkntd+/6b+jclnjE=; b=ZMKHkiziBNZ9v80bLVM7qi2yuycJeYaLa/12gGRPv0i2926nt3KUUwCLqfdHJJj+18 lVFOf/kE/ctTou+apdPvMWC9A2/RQUF5di0BEyVergqfYd3srZScT6kuDplDL6KreeNg f8l/lfrVnNh3+QqpBBquGxHQ2DqdI50QWYfyda9fpIowhCZFT5ZS+sYjIE7Sfomctu1i 3j/qxbrwK2ZnJYVU+dKLyk3a0BNFhg3iXUpSbEcxh6zDL1Is/pHrbdEUWpPkyRT4/xmM sphaUNfVNp/4UoYgsuaamElTS3MtIXuBXf9SpFI14YPvHVKtQqw9Rh8KrfLIqnXGBI6F BOdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="yDQV214/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d23si502920pgv.513.2019.05.23.12.29.31; Thu, 23 May 2019 12:29:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="yDQV214/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391089AbfEWT2T (ORCPT + 99 others); Thu, 23 May 2019 15:28:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:40880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391389AbfEWT2R (ORCPT ); Thu, 23 May 2019 15:28:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C28C206BA; Thu, 23 May 2019 19:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639696; bh=ZNvB4MTqhULf+8cWMI+y4RjcPucrTChmDOREjgeOcBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yDQV214/2zThetsqooP02IitFCLGPLzDTWy4H3vobuO5vMjyPF1+QOsKSdkRY3jIP keRgt6nhhtcd2qj8rAMsyioPE3MP3Sgb176nj4g6D83V5xZwzCngfEQM0BAV+bYwZS okkkEtOxESpif6j5rISDj3sgsqUxwFSuL3NFdoY0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Kalle Valo Subject: [PATCH 5.1 045/122] brcmfmac: Add DMI nvram filename quirk for ACEPC T8 and T11 mini PCs Date: Thu, 23 May 2019 21:06:07 +0200 Message-Id: <20190523181710.637629318@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181705.091418060@linuxfoundation.org> References: <20190523181705.091418060@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans de Goede commit b1a0ba8f772d7a6dcb5aa3e856f5bd8274989ebe upstream. The ACEPC T8 and T11 mini PCs contain quite generic names in the sys_vendor and product_name DMI strings, without this patch brcmfmac will try to load: "brcmfmac43455-sdio.Default string-Default string.txt" as nvram file which is way too generic. The DMI strings on which we are matching are somewhat generic too, but "To be filled by O.E.M." is less common then "Default string" and the system-sku and bios-version strings are pretty unique. Beside the DMI strings we also check the wifi-module chip-id and revision. I'm confident that the combination of all this is unique. Both the T8 and T11 use the same wifi-module, this commit adds DMI quirks for both mini PCs pointing to brcmfmac43455-sdio.acepc-t8.txt . BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1690852 Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 26 +++++++++++++++++ 1 file changed, 26 insertions(+) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c @@ -31,6 +31,10 @@ struct brcmf_dmi_data { /* NOTE: Please keep all entries sorted alphabetically */ +static const struct brcmf_dmi_data acepc_t8_data = { + BRCM_CC_4345_CHIP_ID, 6, "acepc-t8" +}; + static const struct brcmf_dmi_data gpd_win_pocket_data = { BRCM_CC_4356_CHIP_ID, 2, "gpd-win-pocket" }; @@ -49,6 +53,28 @@ static const struct brcmf_dmi_data pov_t static const struct dmi_system_id dmi_platform_data[] = { { + /* ACEPC T8 Cherry Trail Z8350 mini PC */ + .matches = { + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "T8"), + /* also match on somewhat unique bios-version */ + DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1.000"), + }, + .driver_data = (void *)&acepc_t8_data, + }, + { + /* ACEPC T11 Cherry Trail Z8350 mini PC, same wifi as the T8 */ + .matches = { + DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."), + DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "T11"), + /* also match on somewhat unique bios-version */ + DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1.000"), + }, + .driver_data = (void *)&acepc_t8_data, + }, + { /* Match for the GPDwin which unfortunately uses somewhat * generic dmi strings, which is why we test for 4 strings. * Comparing against 23 other byt/cht boards, board_vendor