Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2174958ybm; Thu, 23 May 2019 12:35:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0j3Zi63K9+8y7jwxm5yL3aBX1Vj3u571ps67cjtCMRI1v9RkfzF1imVBTmDARG5YfpO+B X-Received: by 2002:a62:a511:: with SMTP id v17mr78832547pfm.129.1558640122219; Thu, 23 May 2019 12:35:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558640122; cv=none; d=google.com; s=arc-20160816; b=TduimFcvodhwrrFe8IRR10zl44HSdBQQPzzhapZD05iF2MIDyeszzWObztElpKCBkO Kr+j58D3lwQxNOXkbE9GLyBjCHdKSIB7v1/Wq//oUSemT3ZqgMyEi6VUcYxwAs6mhA17 zdGgI+XCimkRGfiAVSjYhXYDjnMDPA9b0BGrnktRTLJ939+sJ4IGBHm17VtntLbbx6hn aweLoEQfyAXa7xvWCrORRiWEkY43wg/39DwIWnSabYv5NDwmDJwc9GhhDwG70t+np/Se orbYMDCz/zy+NP4z1qiM9sBxmdXmRyPL/TbJ5rdmDAboBr0gAUxyA/1PHF9KzB4rM4JF 8Pdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XDdMAoxaFoBr2GV0kQlETYpnbaXDRWAPGMOxCpcQ4x4=; b=T4eEYrB3yZlOSUcpqwlfYrsMhS60OEOCoF5KluzJWuHyZiEoUdAb/sKv1+USK+6Ggg PUa+dWc2/El+2wMgAjKC8QuuOn2O3CQK70Y/USeHyHXkOuSrx4EJ9kHXXuksVkVT2qqv WKnXdFWSLRYAtj7NpPIDxOB4eIJkeLd3d3sL/RlUDYEvXs/YWJilGg/P8lCyVQ7YZx6P fNmvGsAt45frRT/sGHOlM8sf5xoMsDkUTcbSs8je5BpB5f4Nooz35hdC8PuHYzpR13lu 2yMuczcpcLdUQpj39ZyD97lFaCzVW7u4iYrFxkovp9YXRk8dqWTtqOrsgunV+QtWqDs1 vW/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U0iVKVtv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5si538797plq.116.2019.05.23.12.35.07; Thu, 23 May 2019 12:35:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=U0iVKVtv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391437AbfEWT33 (ORCPT + 99 others); Thu, 23 May 2019 15:29:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:42586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391435AbfEWT31 (ORCPT ); Thu, 23 May 2019 15:29:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59C6120879; Thu, 23 May 2019 19:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639766; bh=3rxfAX4mLHvVaXl+hX9hwHnq3HJQHQSfrnr68pxQPQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U0iVKVtv3FR6Ie6iFDroO0UE1rioN6Ncw2WwO66QPzCSrzKY65+wV1XkUXxrjTE4L tbwKxGO7dXtxmz+PzOGCYseuXoHlUXCE+aLDh3fqUFyuZ70pp8ZixRU1j82lOY7qug /2JUiu5AonPz5dDvVw/UM0wuyVqtcng/oHwF4SuI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yifeng Li , Sudip Mukherjee , Teddy Wang , Bartlomiej Zolnierkiewicz Subject: [PATCH 5.1 087/122] fbdev: sm712fb: fix VRAM detection, dont set SR70/71/74/75 Date: Thu, 23 May 2019 21:06:49 +0200 Message-Id: <20190523181716.431314928@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181705.091418060@linuxfoundation.org> References: <20190523181705.091418060@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yifeng Li commit dcf9070595e100942c539e229dde4770aaeaa4e9 upstream. On a Thinkpad s30 (Pentium III / i440MX, Lynx3DM), the amount of Video RAM is not detected correctly by the xf86-video-siliconmotion driver. This is because sm712fb overwrites the GPR71 Scratch Pad Register, which is set by BIOS on x86 and used to indicate amount of VRAM. Other Scratch Pad Registers, including GPR70/74/75, don't have the same side-effect, but overwriting to them is still questionable, as they are not related to modesetting. Stop writing to SR70/71/74/75 (a.k.a GPR70/71/74/75). Signed-off-by: Yifeng Li Tested-by: Sudip Mukherjee Cc: Teddy Wang Cc: # v4.4+ Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/sm712fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/video/fbdev/sm712fb.c +++ b/drivers/video/fbdev/sm712fb.c @@ -1146,7 +1146,9 @@ static void sm7xx_set_timing(struct smtc /* init SEQ register SR30 - SR75 */ for (i = 0; i < SIZE_SR30_SR75; i++) if ((i + 0x30) != 0x30 && (i + 0x30) != 0x62 && - (i + 0x30) != 0x6a && (i + 0x30) != 0x6b) + (i + 0x30) != 0x6a && (i + 0x30) != 0x6b && + (i + 0x30) != 0x70 && (i + 0x30) != 0x71 && + (i + 0x30) != 0x74 && (i + 0x30) != 0x75) smtc_seqw(i + 0x30, vgamode[j].init_sr30_sr75[i]);