Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2175360ybm; Thu, 23 May 2019 12:35:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfSa4fUSwXjZUQ/YwCBTZ57JShAE0qlggMNLJx1T9zPvouhnPazYdUd90EsI+gl1B+0oM5 X-Received: by 2002:a63:4419:: with SMTP id r25mr4148400pga.247.1558640146641; Thu, 23 May 2019 12:35:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558640146; cv=none; d=google.com; s=arc-20160816; b=Js/eAvER5DSeqDECnr7v3CHaOVWiesMRynr2JaMCHe0ZMlT1ncrfJbkH64KLhKagWl VJ7aOEPDUGDEynXZR/XMxybgwYtUM3R8A5Oq2NZPMeJ7q9OP3ZUkhZWI/twetrdV4ug/ xtr9U5eB+iEKQeuCW8vEtrRMVBYd0h8sAQ22Z+d/kOPKESJXKqaLSANbGfm8nzrf8DWm hzVrPll0rfLyCpeFkOgqSFLukOhwVNwY8NNETAV4+wEad8DPJxBB5VyIgG+SzNGph5Ui jsgKKy4TTE5GOmtB08blq2tY4K87y/x6xXtgz175Vxj50QmokohGY73xuiAh3/jyWux3 O5WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EPfdDEQWjENTMgpnWlG9Ristb9U4h3Cx7vgdYqod/xc=; b=ZM3kR/Ag8gF50Grz8UtVOjycm0i0PQZJ127KnbM9/Y+n7E8HeUkNVaR8BtjGcX4Nz9 bO7LtjfH4zPFxTTiw4sNoOywca6y+oCEVlyRegbwZdPr9CMMjQaONIdi6LpiBsAgnhhF Ftn0YvW/buhC2dn5LBT1bUK0o8+vL4UabrRsKQrDRYBrh1qjEWQBBIl2Fm5HDhIA+ytZ OppOTneJrcOG/xrKzZnDzpSGdAssKVcM3Yq7brypzUVI26CY0bJSjuPePGxqY8RGJE7H KthdANLhcEJg0xnrj91x+3wbyY49sd4xtSnkPgRCAwjthNut5Q5ZSaap2dvS/wdTOtjg iQkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I9QvOgLj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m145si152884pfd.217.2019.05.23.12.35.31; Thu, 23 May 2019 12:35:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I9QvOgLj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391915AbfEWT3P (ORCPT + 99 others); Thu, 23 May 2019 15:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:42276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391902AbfEWT3N (ORCPT ); Thu, 23 May 2019 15:29:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCC1021872; Thu, 23 May 2019 19:29:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639753; bh=0GUiNJsKaY4YyNVQ08p1lGKyxp86mUO25WH9yXSFZYA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I9QvOgLjaNvnVAS95GNr7GJtx3np+nBOg97AEelhY9tojj3WJ5wtpzB3uPU/XXda9 o+raPvjij3/+VonRqbuMT7u0FYitnAqNjD6OOb16/69zJlmmeLle4Azgg4xVCTe6YD PPdt0CW+gAnoUK8wvrW1b6sB/pUB+mgETBWv707M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Antonio SJ Musumeci , Miklos Szeredi Subject: [PATCH 5.1 066/122] fuse: fix writepages on 32bit Date: Thu, 23 May 2019 21:06:28 +0200 Message-Id: <20190523181713.460919265@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181705.091418060@linuxfoundation.org> References: <20190523181705.091418060@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi commit 9de5be06d0a89ca97b5ab902694d42dfd2bb77d2 upstream. Writepage requests were cropped to i_size & 0xffffffff, which meant that mmaped writes to any file larger than 4G might be silently discarded. Fix by storing the file size in a properly sized variable (loff_t instead of size_t). Reported-by: Antonio SJ Musumeci Fixes: 6eaf4782eb09 ("fuse: writepages: crop secondary requests") Cc: # v3.13 Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1586,7 +1586,7 @@ __acquires(fi->lock) { struct fuse_conn *fc = get_fuse_conn(inode); struct fuse_inode *fi = get_fuse_inode(inode); - size_t crop = i_size_read(inode); + loff_t crop = i_size_read(inode); struct fuse_req *req; while (fi->writectr >= 0 && !list_empty(&fi->queued_writes)) {