Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2178628ybm; Thu, 23 May 2019 12:39:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqyzbMbIYjNHXGOZN5SzPLjIQjVIoXa03T1CNWyhNmAT4zk6nOYWD1mALjYhoe8CZcPro8qZ X-Received: by 2002:a63:a449:: with SMTP id c9mr11157751pgp.149.1558640352035; Thu, 23 May 2019 12:39:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558640352; cv=none; d=google.com; s=arc-20160816; b=jbaOPvbg50CBVAOoLSakSrIiLpUNq6vEg/WhEIX+AuAQSbw+SPN4qf5IzE/02usp0L WLB5/i0S7Wx8xn0PMdJiYqQD7Fb6vzOn4ls9P8JojZij7M38SOKSRSAnmz3ghHRQ/G1u N99JRwJp8k3xMF/B9eAtt0tM61asQ1xUipiQmolOOdcOITZwYeyYV73KEt1bPC7SroFc CBl7wlO7d3wiEww0AhD7ZmaOQAvjmlx9XNROZtyiCq4B2wl7XMf/pXmC+nF2cwdWvdy1 esGeYaSSgFFFJ5nsa6JBoPtIMeZaMBrmpNrl6PCECRl1jHFDo8Rm6qhqDzPvGg8TaPrP 9CxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IdJtp1eJvF5BXffsR2Zk4vLrbxpgcROpRHOSHRB5ZxQ=; b=lsyRMNiKPPdrbTwKTecDd+f8r6UPkwaLCvNBmHtsr7LnSAsXTniyjpp2aWgSWyfrzU TvM23RDjQS3ujUQ1kYLJ8qiDLzvlDPmevanQr9vspU7EnbxVQJLDmgVdkjRdJPuPazM/ 12NyZ62+smGurLjf5W5nAy7IIkbOV4y/9psuzt7N3XkyjWeUf4K0dQ8zWyS8fnYIr6sr wobzTXpQZ3UUKsoVZZre+EY2Q74SFWX87NKnJCTXjMTXoscEkameGYW1ibTa24xfuD77 3ogwqCoNQ7rr6v7PryqeO0ea8ue+2mnYLsmBJK5HKIhg3wmERP7BmQn794rQON8JUtQ4 T4zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S5AkAkV9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k186si496845pgd.426.2019.05.23.12.38.56; Thu, 23 May 2019 12:39:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S5AkAkV9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391915AbfEWTfr (ORCPT + 99 others); Thu, 23 May 2019 15:35:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:38298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391334AbfEWT00 (ORCPT ); Thu, 23 May 2019 15:26:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECC712054F; Thu, 23 May 2019 19:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558639586; bh=ohi96GrQJW1etsYjYNksG5b5OIcpsBj69l3XFpp8G7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S5AkAkV9sjiubOeQVkwB7WECxxoBC5skOBY5R9LJnnjR06D5v0KgtQrAm01wQfPbe abM7St27vtnPCSI6/E04Yb4cdsIEamnDG9N8cQb/fOgfocWIECcTswYD+fGSCT4xG1 MdIVHFhwTuipI5CGR881mzZLBCwfvvNU5uZREY1c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmytro Linkin , Gavi Teitz , Roi Dayan , Saeed Mahameed Subject: [PATCH 5.1 020/122] net/mlx5e: Add missing ethtool driver info for representors Date: Thu, 23 May 2019 21:05:42 +0200 Message-Id: <20190523181707.480253543@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181705.091418060@linuxfoundation.org> References: <20190523181705.091418060@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmytro Linkin [ Upstream commit cf83c8fdcd4756644595521f48748ec22f7efede ] For all representors added firmware version info to show in ethtool driver info. For uplink representor, because only it is tied to the pci device sysfs, added pci bus info. Fixes: ff9b85de5d5d ("net/mlx5e: Add some ethtool port control entries to the uplink rep netdev") Signed-off-by: Dmytro Linkin Reviewed-by: Gavi Teitz Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -65,9 +65,26 @@ static void mlx5e_rep_indr_unregister_bl static void mlx5e_rep_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo) { + struct mlx5e_priv *priv = netdev_priv(dev); + struct mlx5_core_dev *mdev = priv->mdev; + strlcpy(drvinfo->driver, mlx5e_rep_driver_name, sizeof(drvinfo->driver)); strlcpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version)); + snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), + "%d.%d.%04d (%.16s)", + fw_rev_maj(mdev), fw_rev_min(mdev), + fw_rev_sub(mdev), mdev->board_id); +} + +static void mlx5e_uplink_rep_get_drvinfo(struct net_device *dev, + struct ethtool_drvinfo *drvinfo) +{ + struct mlx5e_priv *priv = netdev_priv(dev); + + mlx5e_rep_get_drvinfo(dev, drvinfo); + strlcpy(drvinfo->bus_info, pci_name(priv->mdev->pdev), + sizeof(drvinfo->bus_info)); } static const struct counter_desc sw_rep_stats_desc[] = { @@ -363,7 +380,7 @@ static const struct ethtool_ops mlx5e_vf }; static const struct ethtool_ops mlx5e_uplink_rep_ethtool_ops = { - .get_drvinfo = mlx5e_rep_get_drvinfo, + .get_drvinfo = mlx5e_uplink_rep_get_drvinfo, .get_link = ethtool_op_get_link, .get_strings = mlx5e_rep_get_strings, .get_sset_count = mlx5e_rep_get_sset_count,