To: neilb@suse.de
CC: akpm@osdl.org, linux-kernel@vger.kernel.org, trond.myklebust@fys.uio.no
In-reply-to: <1051115020002.9459@suse.de> (message from NeilBrown on Tue, 15
	Nov 2005 13:00:02 +1100)
Subject: Re: [PATCH ] Fix some problems with truncate and mtime semantics.
References: <20051115125657.9403.patches@notabene> <1051115020002.9459@suse.de>
Message-Id: <E1Ebxp3-0003me-00@dorka.pomaz.szeredi.hu>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Tue, 15 Nov 2005 11:13:53 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 688
Lines: 16

> Finally, if vmtruncate succeeds, and ATTR_SIZE is the only change
> requested, we now fall-through and mark_inode_dirty.  If a filesystem
> did not have a ->truncate function, then vmtruncate will have changed
> i_size, without marking the inode as 'dirty', and I think this is wrong.

And if filesystem does not have a ->truncate() function and it caller
was [f]truncate(), ctime and mtime won't be set.

That's wrong too, isn't it?

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/