Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2188665ybm; Thu, 23 May 2019 12:49:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWawa8aRK+7u6/PbS8Iord4E2Q6jsBKNfemf/EEhk5dElW8KdhbomWz4fTOxRsDa7sUm7V X-Received: by 2002:a17:902:b18c:: with SMTP id s12mr81390859plr.181.1558640992523; Thu, 23 May 2019 12:49:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558640992; cv=none; d=google.com; s=arc-20160816; b=C840O/E19m+yccHVFx3jBLSp85omKdmb+yWCogweE279zsrTgWfgLbAfXNjwKkleFh mUVcXsJNPXMiKfJIXnZks3G9idrpLq6zPI7hxpzGo75FZfcvPEC7M4q9JUPDzLtWeNHr cjAJ1gMgZiWJ5oaByaBlZz7RsznWs50Zj5JzslNbT2KH2h4Kd2/32eew/P04WasBv5+x 9L95oX5iAlRhNf+XzjpNnwzcy8ASNGM6psik9oxNZAOhSO00G6qe2RX7jWct5fQ1FWoa fURn6qUQahNOewEmJK/zd4/6s95QmrigUk2iku1SUV3ascM1iRoj89lu2F0gdWorI77p vS5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qKiyTAm5V0J7hWQitkz57xa5MFgq0QwsD8ashS3tz3g=; b=A/KW2nRUGGQiINI5cHBiHVbS8FFJDxRFDszEnF369NcfpO1peTbjOKwTRzYSny+FWK xBqbkxwJvkZSarh2Gj7Hzi9XG5st/I9gbtpp0aUjjs/s4dJxW/BPTTCcCcwcvVZzjV+A mcVrgxGXtstOzQiZ1NTqANx7yNng5MerrbgWgXmw/Dfeh1Zt8fX+F8JIAFOUfVz08TZ0 Z79vUF0f4uStV1wZQA2i65w3ByLmsh+WwdHvPn2KeDEuAaEQuRTYBtJE+EGkmqv2rjGR WkRh4TStyary5/SSQdTFOkwqnhVJdohdeQ4Xy1hhpaNMfZYNtwhBQu/nGpGgpQj0F+Pu c26Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fLTpRq8V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si721258pli.192.2019.05.23.12.49.37; Thu, 23 May 2019 12:49:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fLTpRq8V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388371AbfEWTMH (ORCPT + 99 others); Thu, 23 May 2019 15:12:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:45722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388347AbfEWTME (ORCPT ); Thu, 23 May 2019 15:12:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5BABC217F9; Thu, 23 May 2019 19:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638723; bh=ZKAWL+TfWyCxI4eR1wQK7z52Plma/GdthdPmEGtd6Z0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fLTpRq8VmarsvbzOEHH1xBRcuskk2QqWWeAod0cBD3I8fJIbamdG5gojF4FPEe5tQ eaqXn+fgELBTFMvvZFHJuhF1g24G9yxP8lnHxwyi7YS26wenFMdrt2MqJkPs9PEhlH eom+ofBCPtoYKcP7A+YGfJ2eBH9V6dJdTndfUi0s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Olga Kornievskaia , Anna Schumaker Subject: [PATCH 4.14 24/77] PNFS fallback to MDS if no deviceid found Date: Thu, 23 May 2019 21:05:42 +0200 Message-Id: <20190523181723.657210808@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181719.982121681@linuxfoundation.org> References: <20190523181719.982121681@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olga Kornievskaia commit b1029c9bc078a6f1515f55dd993b507dcc7e3440 upstream. If we fail to find a good deviceid while trying to pnfs instead of propogating an error back fallback to doing IO to the MDS. Currently, code with fals the IO with EINVAL. Signed-off-by: Olga Kornievskaia Fixes: 8d40b0f14846f ("NFS filelayout:call GETDEVICEINFO after pnfs_layout_process completes" Cc: stable@vger.kernel.org # v4.11+ Signed-off-by: Anna Schumaker Signed-off-by: Greg Kroah-Hartman --- fs/nfs/filelayout/filelayout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/nfs/filelayout/filelayout.c +++ b/fs/nfs/filelayout/filelayout.c @@ -904,7 +904,7 @@ fl_pnfs_update_layout(struct inode *ino, status = filelayout_check_deviceid(lo, fl, gfp_flags); if (status) { pnfs_put_lseg(lseg); - lseg = ERR_PTR(status); + lseg = NULL; } out: return lseg;