Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2191539ybm; Thu, 23 May 2019 12:52:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxq5zirfa1SHbqKfrrfCADwo5/RavUMQOaLgAY1M/AjCEp4FrDYMTwHZ7IHJxTGMy3bYDcO X-Received: by 2002:a17:90a:22d0:: with SMTP id s74mr3628260pjc.3.1558641179705; Thu, 23 May 2019 12:52:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558641179; cv=none; d=google.com; s=arc-20160816; b=RRLtWf1y8rnyr8nPjLJlUq32TcqUfw6/fjlrRZ4VBuVnaEHx/1HVPvft3wet8MopGD 4zm90cV7EFMT/KnOYqhd+avv2M++1xFfWhc24AuQ3+kRz7TRC2kdndTTOfo/hMG92Xrz Q5MsJMKhAJ/A69c7z4W7C/Ntb5zzNT/9A3qpgORnO2HrUwnhB8Y6g7WB7meOUVrGXTRE Otf20OKjZ8CEkeNB7uk0mU5d6LtRGoS2GSiBNya70ZH4zACng1f6gYJ5VqmkiCWiickH t/YZ+uG1/KexbnBmDmgEndRhLXI4VGew4isu6hHOXINYz8MOzdQiTCBh/GBPamfcFOhW Eqeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F+iK7kPk3gIe+1pkpxr/ZTqnf8WV5aGZQ5fcvPzT/5w=; b=LuQltTYv4K4ZYji9YU0QZzuTd3vdfkJPXF+s8uppStZUlkUxhw77JIz2NaSjYpy/oK emU0Kb6MApRx38/ePhimbbdbQwtUXaQRUzYmBQIpJs4rLwziEh7gcOy1NSpZJlj3IpE3 8BG49I8BItGAIJEPoDeRXRBvI447/CvQcZLyGnS7PhUZVttNqUBFHRrFA6RIboXYzEYr LYbRU/imZnAAHfy0YfRWpYjNkCQfGGYiBGN/BJ0ewmSeI1JqgsAsYctZWfunIlzZ6AXf wJrVJ+shrsW+FmvPgE4dpdWHCQWJN/0l8IczKOtYsEOhmGMs32BDi03cv9dmX7zwFhwW 2LZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VOglRKbu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f92si572644plf.100.2019.05.23.12.52.44; Thu, 23 May 2019 12:52:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VOglRKbu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387615AbfEWTu2 (ORCPT + 99 others); Thu, 23 May 2019 15:50:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:43048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387574AbfEWTJu (ORCPT ); Thu, 23 May 2019 15:09:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB13821841; Thu, 23 May 2019 19:09:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638589; bh=Rbsbd6QlhoNCTrhmdRBaMqtVoTwYH+FKiBtFuhyqzi8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VOglRKbuhXuvYghUE5Zr+j9xXILjXwYleFxCG9cLOPVvGOuG/OpOKMO2oIB0yDPgt YGuUVFFz12rxIF3N0ejFYSgo9pGNF3DrrOtXgtHpSKoX9YvdozI8cVrSwjf8sa91ZC v4nRKIboXvofPYEyjkulnLglV3/GwOO2dpkqlHWI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Hunter , Jiri Olsa , Arnaldo Carvalho de Melo Subject: [PATCH 4.9 28/53] perf intel-pt: Fix sample timestamp wrt non-taken branches Date: Thu, 23 May 2019 21:05:52 +0200 Message-Id: <20190523181715.242057269@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181710.981455400@linuxfoundation.org> References: <20190523181710.981455400@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Adrian Hunter commit 1b6599a9d8e6c9f7e9b0476012383b1777f7fc93 upstream. The sample timestamp is updated to ensure that the timestamp represents the time of the sample and not a branch that the decoder is still walking towards. The sample timestamp is updated when the decoder returns, but the decoder does not return for non-taken branches. Update the sample timestamp then also. Note that commit 3f04d98e972b5 ("perf intel-pt: Improve sample timestamp") was also a stable fix and appears, for example, in v4.4 stable tree as commit a4ebb58fd124 ("perf intel-pt: Improve sample timestamp"). Signed-off-by: Adrian Hunter Cc: Jiri Olsa Cc: stable@vger.kernel.org # v4.4+ Fixes: 3f04d98e972b ("perf intel-pt: Improve sample timestamp") Link: http://lkml.kernel.org/r/20190510124143.27054-4-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c @@ -1235,8 +1235,11 @@ static int intel_pt_walk_tnt(struct inte return 0; } decoder->ip += intel_pt_insn.length; - if (!decoder->tnt.count) + if (!decoder->tnt.count) { + decoder->sample_timestamp = decoder->timestamp; + decoder->sample_insn_cnt = decoder->timestamp_insn_cnt; return -EAGAIN; + } decoder->tnt.payload <<= 1; continue; }