Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2191723ybm; Thu, 23 May 2019 12:53:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8qFOAmRpD+FSNspng49R3mtgEkkZ2LwgcOqkI0IU/v0ssaDDye1r/z4Af/9MrcgXCzw/I X-Received: by 2002:a17:902:e18d:: with SMTP id cd13mr33378526plb.301.1558641191256; Thu, 23 May 2019 12:53:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558641191; cv=none; d=google.com; s=arc-20160816; b=Rf4UI95A6jCSq00ZqyGtQhfUkAdhKZBCzV1ATm6JfJ+E+Wzdd43YuwKSmHnD3v0Qq2 86DlISQq7vSfr7KapZL6NomQB9V+3IcOun04SJkvvsprPosfAYgy6sQAIVaHkBZISP4h IPnoltGUER+50OwDkQHlX9I4QvtxiE3KSea1P24uySNvk458XxKbCmj6JvBPD5J+FDmO 6mZGorLsz00PwNTKybnsRoVLOukfMggkexDKODhgWNOyyydcyK6K7ZtxMPsSoKvypGG+ Ap1r/mNR/uh9tqOaEEo1rMp1iUEvPT/eMVwbteY1fIgOsG2r7zmuMvhp0PaVjZu681Mw Ia0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XMnCeBULBtoKO+6yYVdEKIKuKc7xgYdEmdjxc7e+dkM=; b=o2/I/t/hBjvduf+7A/+jUi6+0sDuYD6A+I/W3j4r7kF3K4AXCv5FrWDp0GYcFe/uYX Zxm4EflznAP0Vk3OvVkv4jIOi906945hIx/b7d2ip70yj9CNEmAxMjVHeyWnQ+FnDD8z i2PAH2Vp1dEP0kRVCXXGIgqrzzuiq3enkMR12fNtnzVhWyUpF1v5SBDzNVBK2/nax7SK VdjYhv7VAlqe7q9dy7pD3OUY/cOKDrl3kL8YSq3s1msRenpPdswyCeP2GDhhqeCv3ZXw UBZE1g9Z5LMw16lfNfww9GY1bvAHKzb8agmWuyOhXx1ZPymtleUJfua085JNcy1nkozE jAcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BMggWRII; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8si477933pjq.89.2019.05.23.12.52.55; Thu, 23 May 2019 12:53:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BMggWRII; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731620AbfEWTvy (ORCPT + 99 others); Thu, 23 May 2019 15:51:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:41648 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731853AbfEWTIn (ORCPT ); Thu, 23 May 2019 15:08:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57367217D7; Thu, 23 May 2019 19:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558638522; bh=oLnhJo1VanbKdZHccG/M2AWX6tCSmV4ezVCwsTOPdPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BMggWRII9eJk/xnqwAnAOac5FrHXrYbN2tKU3ZTISEfqUDc6h3xrPrOBpdmV7KShF 1do5FTcT5UytZfBEOvCmhgOvrkIHa6ExImERd593k0Dhkumvj7WLFS/c+If6QPfCUF TxJjW35X5HSXoEIP6/qbnZI2+DIwrrhsspFbH5xI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Antonio SJ Musumeci , Miklos Szeredi Subject: [PATCH 4.9 20/53] fuse: fix writepages on 32bit Date: Thu, 23 May 2019 21:05:44 +0200 Message-Id: <20190523181714.052642775@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190523181710.981455400@linuxfoundation.org> References: <20190523181710.981455400@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi commit 9de5be06d0a89ca97b5ab902694d42dfd2bb77d2 upstream. Writepage requests were cropped to i_size & 0xffffffff, which meant that mmaped writes to any file larger than 4G might be silently discarded. Fix by storing the file size in a properly sized variable (loff_t instead of size_t). Reported-by: Antonio SJ Musumeci Fixes: 6eaf4782eb09 ("fuse: writepages: crop secondary requests") Cc: # v3.13 Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1521,7 +1521,7 @@ __acquires(fc->lock) { struct fuse_conn *fc = get_fuse_conn(inode); struct fuse_inode *fi = get_fuse_inode(inode); - size_t crop = i_size_read(inode); + loff_t crop = i_size_read(inode); struct fuse_req *req; while (fi->writectr >= 0 && !list_empty(&fi->queued_writes)) {