Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2303235ybm; Thu, 23 May 2019 14:48:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwgA0vy/aaIxgQvXuLF+hPbQ8IZE5/xAb0m0xUtBCrSKzRpRs5lT3ezjkvREN0zbjhMfyTz X-Received: by 2002:a63:555a:: with SMTP id f26mr100494144pgm.197.1558648127351; Thu, 23 May 2019 14:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558648127; cv=none; d=google.com; s=arc-20160816; b=UnEUNu2ki3dmK3a7kn7iK0AqxBxoib5fWEmk8tIy/acgGKrUFGA1HpeG2on4w0FEQN T/e9jxM64QS+jJYKa66PNfMQxtsN56GNXgHJZIM9zFYUgsB1nQEee0E4wAjUafjCKa2I 52cu+lqZ7yOMAB3h0fcrZiIqLicDVvT75jYkm42iJvN+xB25+MKz09Eq+RUvUu3Wr4T/ wuxzD6lUOMz3CD671J0rWIGHtygVzO4UHgjJ5GItEZXmdaNrRgz0Ne2quZu+i7D7c3qw U4lhusFBT86dwnJMAMwKaYxX/V4EKvnP/UnQ1RU/kshYOTk386qdNnGT6dfI3PKDmBkp FAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=jLaVtK3dTIBGULW9LqgDdHPCnDBMlxzNCTE/sRHoa70=; b=MtvypaOROwTLZcwZfxx1bnCvxfbUGzjlyhTU+2b0R4aG1/sX8GTF6kKYux8SsRS4tE EchszlMfbwpndkvsEeYpBuWrKJq5D47mA4SP0Kd6Hnt0/GIJNXrK1VbZTt2DBYq6bFh4 UytNHuIvPIxsBNXACz8cveF3F7H8s1BU4+s0sAEiEtPvKG6V/05POqhElMV07WIwUfKU QpLs/MGUl6JEqT+R9GU1zByPdDgzOShJI7DiXGVQYyHPRIxKalzO8z0TyU87ZYSVdYWi ylgUugd35qutAncAxJldMjrstRgNnLUpMcggVNgKfRS4CnxgIiDJPuMQH/df/DtHE4kG +qug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=ShEJArcL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c193si1194549pga.6.2019.05.23.14.48.30; Thu, 23 May 2019 14:48:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=ShEJArcL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388365AbfEWVqI (ORCPT + 99 others); Thu, 23 May 2019 17:46:08 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:45721 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387709AbfEWVqI (ORCPT ); Thu, 23 May 2019 17:46:08 -0400 Received: by mail-pg1-f195.google.com with SMTP id i21so3795633pgi.12 for ; Thu, 23 May 2019 14:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id; bh=jLaVtK3dTIBGULW9LqgDdHPCnDBMlxzNCTE/sRHoa70=; b=ShEJArcL1KurA1638gz4USiZ00iMtMSug5yVVcXiRtq5yuXns/UC6ym+0dTJvdOUoj 78DW7v4DCsJEVZi7VsL+DUQGnYD/1Gw8cYLRnzV2fIY9cvZHx4JmP8dJBZ/CkrOvy/r6 hi6huQyiN4IcB8uajCWgiy5jB/ADDU4MVssRWpr3I9BmE61Qbz5XtRDsAnlSFWRDu5DV sPy2ijb70+9EyYSeZQxR5v5/w559ski9jk2+HKGKlMcSUeFIRbXFkN2eGJ3NZx0sXHnv YduhiMCdIg52qX7KfA1u3Patzl0qE9lP7Gnrb1Jxs3NK9JufLOthzMFXYm5Ta+3oh9K1 nr4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jLaVtK3dTIBGULW9LqgDdHPCnDBMlxzNCTE/sRHoa70=; b=o5PF6I00+tA88Qpu1xqrIEsTGWf0VsHZDT4keGVqo2XEeYpwSvpyhAtmTJ2dwsXWdm YdZ7bfhOYPzCH1shxflDsUcGhqmDVb6EalkCOmzFQafpvleMeUlketkyBp9104edUCVT TujNJUUj/G2ryChBxuqqaHiEGWdsVrEBxphGtSqLEh2UT7TWqIjX0sVcXms9n/uKFRGo m1BcuF/huE21ppVFscwLR6NkPumslPMl5J2hk2L/2EHQelgl5eEhDfAQeWrLi5xPXTfr 6Kmmj8BRsnyqUHqq3dxHHCVsjbNjqrw+f54UaYYluMSp1/GinCDZhhFZXBXfGx4M7uXr QHYA== X-Gm-Message-State: APjAAAVsPa42ayL5P4rVZhlRABHbYtOfr8bNQvjZm+gRxAk2/T1lf+si +hx5Uq/dWSzHVFNGguwCfs7h4g== X-Received: by 2002:a63:5211:: with SMTP id g17mr69897684pgb.405.1558647967581; Thu, 23 May 2019 14:46:07 -0700 (PDT) Received: from nuc7.sifive.com ([12.206.222.2]) by smtp.gmail.com with ESMTPSA id q10sm376519pff.132.2019.05.23.14.46.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 May 2019 14:46:06 -0700 (PDT) From: Alan Mikhak X-Google-Original-From: Alan Mikhak < alan.mikhak@sifive.com > To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, lorenzo.pieralisi@arm.com, linux-riscv@lists.infradead.org, palmer@sifive.com, paul.walmsley@sifive.com Cc: Alan Mikhak Subject: [PATCH v2] PCI: endpoint: Set endpoint controller pointer to null Date: Thu, 23 May 2019 14:45:44 -0700 Message-Id: <1558647944-13816-1-git-send-email-alan.mikhak@sifive.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set endpoint controller pointer to null in pci_epc_remove_epf() to avoid -EBUSY on subsequent call to pci_epc_add_epf(). Requires checking for null endpoint function pointer. Signed-off-by: Alan Mikhak --- drivers/pci/endpoint/pci-epc-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c index e4712a0f249c..2091508c1620 100644 --- a/drivers/pci/endpoint/pci-epc-core.c +++ b/drivers/pci/endpoint/pci-epc-core.c @@ -519,11 +519,12 @@ void pci_epc_remove_epf(struct pci_epc *epc, struct pci_epf *epf) { unsigned long flags; - if (!epc || IS_ERR(epc)) + if (!epc || IS_ERR(epc) || !epf) return; spin_lock_irqsave(&epc->lock, flags); list_del(&epf->list); + epf->epc = NULL; spin_unlock_irqrestore(&epc->lock, flags); } EXPORT_SYMBOL_GPL(pci_epc_remove_epf); -- 2.7.4