Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2317236ybm; Thu, 23 May 2019 15:03:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYGPgwqv1T08zLeeMyKW0NseYeQtVW/lv1zYagAhEm0dr4kUQz6W6L20Jhry4z+FXBipHA X-Received: by 2002:a17:902:bd95:: with SMTP id q21mr64983524pls.159.1558649032541; Thu, 23 May 2019 15:03:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558649032; cv=none; d=google.com; s=arc-20160816; b=p+mUELBCF3Kgo0V9hhsFiKGfdoFbhCSN5gDtRDjvUkmrYlTvgtnHD6OneBQPRoD8M0 P3TXZIempyclKLcRYWywIBbWAruWGCm17B4As46HRS7Ei6Zdc3+AFAsIFpfEMqE3p8EZ oWl4RhMwxITelFu1wCrGyOV0/dIzDvnHHjZivaIj9e/O2tzqBSUTsr5TWWe+VkjNq/1o aUzayagyXXQUgNRd9fYCn/X9hduLiqW6gSRb1nSFaPTYdY+C+7/IJMgDmvjbqI/hrWLt KNAn/xxJ+XZo8z0mlLtBl3M/c6p5ELos8ptkmS5+B9S2l4PPzE1UpuEFx0X7ZqT7bPzQ Ym2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject :from:cc:to:dkim-signature; bh=xGSNd114YO+n9lj/9ZMYbNueQVRhgHUxg4b1ZWLZP2c=; b=DXcVH8Vg8rSHltZ3wyO40AV/f8lZkiOrM0lmXg/g1HWraluOWPAgzm9l86W7ie3s44 RrJxLliDsXfrxVRwYra0ZEqhwHmQrtT+4dasMVThk6gthq8TrqKvkVF3Ql5wgwbnOiDI t2rMXAoIa0u5ZGGQaDIU0PQ4eLeXQ5/H/EhG5qcI/3Ct6QE0p5O6tSWcU9WuSdDzVfZ0 Nk2UekEFCUdz3Cp+Lh/CgKece/7G/Dgnr/IYBCgEgba6fZXn9uzbXYvmoYLo1r2pmsl5 98TNZU9YerWizN6yINUTxaG6zGdsj3xzvmf53UG9Y0eIMk5XEjg9DJkJuMyl1dmeUnKS oWqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@infradead.org header.s=merlin.20170209 header.b="3VKjo/+z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 61si1169478plq.398.2019.05.23.15.03.37; Thu, 23 May 2019 15:03:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@infradead.org header.s=merlin.20170209 header.b="3VKjo/+z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388490AbfEWWA7 (ORCPT + 99 others); Thu, 23 May 2019 18:00:59 -0400 Received: from merlin.infradead.org ([205.233.59.134]:42228 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387616AbfEWWA6 (ORCPT ); Thu, 23 May 2019 18:00:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Subject:From:Cc:To:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=q0ChSwIgjWmAlSA3WLmbkrMunJ+EzRmHj6nCPrtyT6A=; b=3VKjo/+zSV+G+nl3AlhMIVepW+ +cr9FiVKt7O00ECmmRJS5LXWb0qORktCXK3waGV0LpMbofvOiuTA7MkuUYVSwD94A7jIZHFMXR6/A XciZW1qUoziZiVS+z/AEeO01pbjki3pb7H26BySZ1MtEYvuloC6fUW68pqymnw7daEeZx2xEL75Tr /RNM9zuLSIXG2It+JD6kbuSGirnKOIJ/wltfLd58y2whO96hqpcGSpqik/CoVx/nqCoIdGjbeuXq+ iA7lbSg0+Q2+45LGHRTw+hUL72iCNYmmaD++ipo51ilZ0vtVDv13lm8HHVQ/VvwarPw1xhJBuIi2N 0L1oD0cw==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=midway.dunlab) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTvlV-0005vn-6z; Thu, 23 May 2019 22:00:45 +0000 To: LKML , "linux-gpio@vger.kernel.org" Cc: kbuild test robot , Michael Hennerich , Linus Walleij , Bartosz Golaszewski From: Randy Dunlap Subject: [PATCH] gpio: fix gpio-adp5588 build errors Message-ID: <8054bec0-ea24-8590-738b-bae58c0be3b4@infradead.org> Date: Thu, 23 May 2019 15:00:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap The gpio-adp5588 driver uses interfaces that are provided by GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry. Fixes these build errors: ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_handler’: ../drivers/gpio/gpio-adp5588.c:266:26: error: ‘struct gpio_chip’ has no member named ‘irq’ dev->gpio_chip.irq.domain, gpio)); ^ ../drivers/gpio/gpio-adp5588.c: In function ‘adp5588_irq_setup’: ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function ‘gpiochip_irqchip_add_nested’ [-Werror=implicit-function-declaration] ret = gpiochip_irqchip_add_nested(&dev->gpio_chip, ^ ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function ‘gpiochip_set_nested_irqchip’ [-Werror=implicit-function-declaration] gpiochip_set_nested_irqchip(&dev->gpio_chip, ^ Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller") Reported-by: kbuild test robot Signed-off-by: Randy Dunlap Cc: Michael Hennerich Cc: Linus Walleij Cc: Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org --- drivers/gpio/Kconfig | 1 + 1 file changed, 1 insertion(+) --- lnx-52-rc1.orig/drivers/gpio/Kconfig +++ lnx-52-rc1/drivers/gpio/Kconfig @@ -822,6 +822,7 @@ config GPIO_ADP5588 config GPIO_ADP5588_IRQ bool "Interrupt controller support for ADP5588" depends on GPIO_ADP5588=y + select GPIOLIB_IRQCHIP help Say yes here to enable the adp5588 to be used as an interrupt controller. It requires the driver to be built in the kernel.