Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5ce722ac.1c69fb81.b62d2.16d0@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190523195313.24701-1-farosas@linux.ibm.com>
References: <20190523195313.24701-1-farosas@linux.ibm.com>
Subject: Re: [PATCH] scripts/gdb: Fix invocation when CONFIG_COMMON_CLK is not set
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Jackie Liu <liuyun01@kylinos.cn>
To:     Fabiano Rosas <farosas@linux.ibm.com>, linux-kernel@vger.kernel.org
User-Agent: alot/0.8.1
Date:   Thu, 23 May 2019 15:46:03 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Fabiano Rosas (2019-05-23 12:53:11)
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/consta=
nts.py.in
> index 1d73083da6cb..2efbec6b6b8d 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -40,7 +40,8 @@
>  import gdb
> =20
>  /* linux/clk-provider.h */
> -LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
> +if IS_BUILTIN(CONFIG_COMMON_CLK):
> +    LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
> =20

Why is this LX_GDBPARSED() instead of LX_VALUE()? From what I can tell
it doesn't need to be runtime evaluated, just assigned to something that
is macro expanded by CPP.

We should probably change the clk-provider.h header to export more
things than what it's exporting right now when COMMON_CLK is disabled.
I'm not sure why the whole thing is wrapped in a big ifdef.

Either way

Reviewed-by: Stephen Boyd <swboyd@chromium.org>