Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Stephen Boyd <swboyd@chromium.org>,
        Fabiano Rosas <farosas@linux.ibm.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH] scripts/gdb: Fix invocation when CONFIG_COMMON_CLK is not
 set
Thread-Topic: [PATCH] scripts/gdb: Fix invocation when CONFIG_COMMON_CLK is
 not set
Thread-Index: AQHVEaEw3la++p0LyEyZRXi/xw4poQ==
Date:   Thu, 23 May 2019 23:09:18 +0000
Message-ID: <AM0PR04MB6434A12D2DCB42ECAA7EB1FAEE010@AM0PR04MB6434.eurprd04.prod.outlook.com>
References: <20190523195313.24701-1-farosas@linux.ibm.com>
 <5ce722ac.1c69fb81.b62d2.16d0@mx.google.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: bf21954e-eeb7-42b1-acff-08d6dfd3af30
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2019 23:09:18.8221
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6689
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/24/2019 1:46 AM, Stephen Boyd wrote:=0A=
> Quoting Fabiano Rosas (2019-05-23 12:53:11)=0A=
>> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/const=
ants.py.in=0A=
>> index 1d73083da6cb..2efbec6b6b8d 100644=0A=
>> --- a/scripts/gdb/linux/constants.py.in=0A=
>> +++ b/scripts/gdb/linux/constants.py.in=0A=
>> @@ -40,7 +40,8 @@=0A=
>>   import gdb=0A=
>>   =0A=
>>   /* linux/clk-provider.h */=0A=
>> -LX_GDBPARSED(CLK_GET_RATE_NOCACHE)=0A=
>> +if IS_BUILTIN(CONFIG_COMMON_CLK):=0A=
>> +    LX_GDBPARSED(CLK_GET_RATE_NOCACHE)=0A=
>>   =0A=
> =0A=
> Why is this LX_GDBPARSED() instead of LX_VALUE()? From what I can tell=0A=
> it doesn't need to be runtime evaluated, just assigned to something that=
=0A=
> is macro expanded by CPP.=0A=
=0A=
Because CLK_GET_RATE_NOCACHE expands to BIT() which expands to a =0A=
constant with an UL suffix which python doesn't understand.=0A=
=0A=
Alternatively we could redefine the BIT macros inside constants.py.in =0A=
but using gdb features seemed better. We could even try to strip integer =
=0A=
literal suffixes with sed.=0A=
=0A=
Mentioned before: https://lkml.org/lkml/2019/5/3/341=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=