Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2428326ybm; Thu, 23 May 2019 17:15:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWXzXzQqf1RAN1Ns7goiMYoshv3IwsVoVLS4734fPIazT9S1M6tvVy1pJZBAs8yLv9OcM/ X-Received: by 2002:a63:4c14:: with SMTP id z20mr9307670pga.360.1558656931612; Thu, 23 May 2019 17:15:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558656931; cv=none; d=google.com; s=arc-20160816; b=QRqsQy8fG64i29FmuZmGlxGVgxrdGH6mz3Oru4sXycF2YDUr73U8yPI6fff4zG+bDJ Xlc4NXocryCBu8tlv0E/dIL6vLwGGqvwKPhpAtSk99YWVNudNbBNUC/HRKX0WRV2nUAV lWmUbzg4qNOir/+1f8i3lJOSVs41JpHp+3hXJAoxhLRJtiATPE/vqnNqfZdYUJhEfuJa KQcAOIhMMLCEFimFVd79bzw/Y3BtA2Tc1C9PRq5s1Fs1MTsByy1aotl+rKKDeSmXmkyZ 4t7QxfnLfaQDlTchHaRHpFuNjC1kFTqlBeMZodibMSIEV0MTnZSdvOOwIITfWPlMUtey At5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=82j9oEtFSzhCPGBUCvqKrOX6wZt3XRagtmxZkSOBHHg=; b=CgsW/loHqfBT1s0sAUQ/QpwYRJl4ZtOjq3hHXqaNnuO/zJZi/bsqrhMg/X6mva1gZI LaPMrCkAr28Cqu85CYa36ER/FuH+dk7FMYdCxWkAbCqe2gXkK+QsP/MOf53thogJztfm DW3dBruOQVscKlv1WCoRrtJbIlTr2+4fB5YAaQNOvlEK9JGRPppA7nkapbVJTKvn0sSc 1vcfarcEDS12Jc+nDXh5w3yEHKdO9FReCLpLhi2++T8sS1BhzzWd9nXOfR8h61xezsxN ruoQvuRSAdnGbyu4JSJklT1+FPuhBIJB8n22XcrjP7umvnbe/HdjO+14gHWs+bmTcVMy 0OlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g191si1890825pgc.197.2019.05.23.17.15.10; Thu, 23 May 2019 17:15:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731584AbfEXAMo (ORCPT + 99 others); Thu, 23 May 2019 20:12:44 -0400 Received: from mx.allycomm.com ([138.68.30.55]:47689 "EHLO mx.allycomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727042AbfEXAMn (ORCPT ); Thu, 23 May 2019 20:12:43 -0400 Received: from jkletsky-mbp15.guidewire.com (inet.guidewire.com [199.91.42.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.allycomm.com (Postfix) with ESMTPSA id E376D3D38F; Thu, 23 May 2019 17:12:41 -0700 (PDT) Subject: Re: [PATCH v4 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG To: Schrempf Frieder , Miquel Raynal Cc: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20190522220555.11626-1-lede@allycomm.com> <20190522220555.11626-4-lede@allycomm.com> From: Jeff Kletsky Message-ID: Date: Thu, 23 May 2019 17:12:41 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (reduced direct addressees, though still on lists) On 5/22/19 11:42 PM, Schrempf Frieder wrote: > On 23.05.19 00:05, Jeff Kletsky wrote: >> From: Jeff Kletsky >> >> The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices >> and, while it has the same logical layout as the E-series devices, >> it differs in the SPI interfacing in significant ways. >> >> This support is contingent on previous commits to: >> >> * Add support for two-byte device IDs >> * Define macros for page-read ops with three-byte addresses >> >> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ >> >> Signed-off-by: Jeff Kletsky > Reviewed-by: Frieder Schrempf > >> Reported-by: kbuild test robot > I dont't think that this Reported-by tag should be used here. The bot > reported build errors caused by your patch and you fixed it in a new > version. As far as I understand this tag, it references someone who > reported a flaw/bug that led to this change in the first place. > The version history of the changes won't be visible in the git history > later, but the tag will be and would be rather confusing. Thank you for your patience and explanations. I've been being conservative as I'm not a "seasoned, Linux professional" and am still getting my git send-email config / command line for Linux properly straightened out. Should I send another patch set with the `kbuild...` tag removed, or would it be removed in the process of an appropriate member of the Linux MTD team adding their tag for approval, if and when that happens? Jeff