Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp2508039ybm; Thu, 23 May 2019 18:54:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfRp+8oGGkzIoYAcGZGesoHZ6DxqmVCn41KWNlzspU3pszDjlJ1rZKY6xZ7TgHMvZf6KKZ X-Received: by 2002:a17:902:704c:: with SMTP id h12mr47176407plt.65.1558662868470; Thu, 23 May 2019 18:54:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558662868; cv=none; d=google.com; s=arc-20160816; b=L8glyzwxuJo5med5g13hsco7uR47DbyeRp1RBQz/8pb8CBezxd+pFm8i53RBnrEZ9m rEyEsyyY0kPf+OvB+/0sS/t2iTVUUklKnMo8j8O+Lb8sdxXtW0F9YFcMr8U0wqQd3L+Z Z0272nmooHzN4v7nstBE37CZxwOi+d+ELJOr0Lt8mTKfE6etSqgb7CmqllAUM0zYUGj0 pFW0wBg/UOWHk1foawpwH74Uw+vi7k7y1eMgAojSPb14QiIarKplqlM5sgroosuBTJLO vcN+66870QDBgoeVOlu5yV9OZ90slUGPZPeHvMYHKAadZr6LdyjA+EQaZGb/dUIYK4f0 5rFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=fcmxKph3pCyexBJoShQkjYQnPHoxtN7FjobnykSc7YU=; b=Ew4U9ktaNsKxVy0qpAb9eZl4Edm2zo+640J720oGbZfUIoDihqImo62FiS9dm6uVOS M8UNTj40O6ztZQgBePXBH9KSnoftBRkFpbnVUEoQh86ZQty1SjpGfo3wnhxvcZgXb+no 8F/DHWajM06broR99pqBJVNGZuozk33i2gaFoK0lzWsJ1bkNghtqsL6c9K+8FDQn3ow2 F2GBYmRbUN8P7e42lwMICb95+zZSpp8f2LViL20NpfwWZ7lPZ7BvPuOjfhvYrUmR6VYo kivMG7HuBUKYdMu/z7TA9h+m53LorpUXHQTgjI6e/TdkRTjtrYxTCcaMIYd4CMztLXT+ olcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r4si2077662pgv.195.2019.05.23.18.54.06; Thu, 23 May 2019 18:54:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731726AbfEXBwd (ORCPT + 99 others); Thu, 23 May 2019 21:52:33 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34839 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729041AbfEXBwd (ORCPT ); Thu, 23 May 2019 21:52:33 -0400 Received: from mail-oi1-f198.google.com ([209.85.167.198]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hTzNk-0007DP-Vy for linux-kernel@vger.kernel.org; Fri, 24 May 2019 01:52:29 +0000 Received: by mail-oi1-f198.google.com with SMTP id a196so3088297oii.21 for ; Thu, 23 May 2019 18:52:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fcmxKph3pCyexBJoShQkjYQnPHoxtN7FjobnykSc7YU=; b=GIoONpDEVSlHYCsfJlVio1T7xEmDXy4xJuEnnanoFRc0c8ZqvzS3FoVZnvjqRFpOyQ fkZBH8zzK/3adgC5gmYXsIf/JehAIczJnC/D+QxpbJH3WEGWxG/zu8UB+WbywrxCl5Qq Geim70uXA01gwPRUMM8dJ3vdHtM1OnRanj7TGs5XUCGcFcw0EiHuhcRnJQ/00hHsEXSx CPkruFaHKVXHwGeqCjpkTsGlFgbuGUVnfo5au/uK2IsFPd1aXXNbFVCQtMzhG7E/MhTm sy59cdg6KJnCMROgHzQfHa+dW2VXzkut09Ax6MkYXBQV1/OVpOsssKf4BSENmb67gs9Y QbPQ== X-Gm-Message-State: APjAAAXt7xsLZT/cxPAh3VU4XI1dYVRG0laUEMKotzBer1FCNAlXpExn ftktquiS89323U6bu8uH560hUD619UvGYILgc9J/aWQsLt6MucxbP3HwQNTZOPxWYzL1rXMUbEK srvIUsSPqAV2E3NExIyC004nZZybvqzHRjCqmFzQqtIZU+OlP2yVL7E0kaA== X-Received: by 2002:aca:4457:: with SMTP id r84mr4757178oia.42.1558662745685; Thu, 23 May 2019 18:52:25 -0700 (PDT) X-Received: by 2002:aca:4457:: with SMTP id r84mr4757159oia.42.1558662745338; Thu, 23 May 2019 18:52:25 -0700 (PDT) MIME-Version: 1.0 References: <20190506223334.1834-1-nicoleotsuka@gmail.com> <20190506223334.1834-2-nicoleotsuka@gmail.com> In-Reply-To: <20190506223334.1834-2-nicoleotsuka@gmail.com> From: dann frazier Date: Thu, 23 May 2019 19:52:14 -0600 Message-ID: Subject: Re: [PATCH v2 1/2] dma-contiguous: Abstract dma_{alloc, free}_contiguous() To: Nicolin Chen Cc: Christoph Hellwig , Robin Murphy , Marek Szyprowski , chris@zankel.net, linux-xtensa@linux-xtensa.org, keescook@chromium.org, sfr@canb.auug.org.au, tony@atomide.com, Catalin Marinas , joro@8bytes.org, Will Deacon , linux@armlinux.org.uk, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, jcmvbkbc@gmail.com, wsa+renesas@sang-engineering.com, akpm@linux-foundation.org, treding@nvidia.com, dwmw2@infradead.org, iamjoonsoo.kim@lge.com, linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 6, 2019 at 4:35 PM Nicolin Chen wrote: > > Both dma_alloc_from_contiguous() and dma_release_from_contiguous() > are very simply implemented, but requiring callers to pass certain > parameters like count and align, and taking a boolean parameter to > check __GFP_NOWARN in the allocation flags. So every function call > duplicates similar work: > /* A piece of example */ > unsigned long order = get_order(size); > size_t count = size >> PAGE_SHIFT; > page = dma_alloc_from_contiguous(dev, count, order, gfp & __GFP_NOWARN); > [...] > dma_release_from_contiguous(dev, page, size >> PAGE_SHIFT); > > Additionally, as CMA can be used only in the context which permits > sleeping, most of callers do a gfpflags_allow_blocking() check and > a corresponding fallback allocation of normal pages upon any false > result: > /* A piece of example */ > if (gfpflags_allow_blocking(flag)) > page = dma_alloc_from_contiguous(); > if (!page) > page = alloc_pages(); > [...] > if (!dma_release_from_contiguous(dev, page, count)) > __free_pages(page, get_order(size)); > > So this patch simplifies those function calls by abstracting these > operations into the two new functions: dma_{alloc,free}_contiguous. > > As some callers of dma_{alloc,release}_from_contiguous() might be > complicated, this patch just implements these two new functions to > kernel/dma/direct.c only as an initial step. > > Suggested-by: Christoph Hellwig > Signed-off-by: Nicolin Chen > --- > Changelog > v1->v2: > * Added new functions beside the old ones so we can replace callers > one by one later. > * Applied new functions to dma/direct.c only, because it's the best > example caller to apply and should be safe with the new functions. > > include/linux/dma-contiguous.h | 10 +++++++ > kernel/dma/contiguous.c | 48 ++++++++++++++++++++++++++++++++++ > kernel/dma/direct.c | 24 +++-------------- > 3 files changed, 62 insertions(+), 20 deletions(-) > > diff --git a/include/linux/dma-contiguous.h b/include/linux/dma-contiguous.h > index f247e8aa5e3d..dacbdcb91a89 100644 > --- a/include/linux/dma-contiguous.h > +++ b/include/linux/dma-contiguous.h > @@ -115,6 +115,8 @@ struct page *dma_alloc_from_contiguous(struct device *dev, size_t count, > unsigned int order, bool no_warn); > bool dma_release_from_contiguous(struct device *dev, struct page *pages, > int count); > +struct page *dma_alloc_contiguous(struct device *dev, size_t size, gfp_t gfp); > +void dma_free_contiguous(struct device *dev, struct page *page, size_t size); > > #else > > @@ -157,6 +159,14 @@ bool dma_release_from_contiguous(struct device *dev, struct page *pages, > return false; > } > > +struct page *dma_alloc_contiguous(struct device *dev, size_t size, gfp_t gfp) > +{ > + return NULL; > +} > + > +static inline > +void dma_free_contiguous(struct device *dev, struct page *page, size_t size) { } > + > #endif > > #endif > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > index b2a87905846d..21f39a6cb04f 100644 > --- a/kernel/dma/contiguous.c > +++ b/kernel/dma/contiguous.c > @@ -214,6 +214,54 @@ bool dma_release_from_contiguous(struct device *dev, struct page *pages, > return cma_release(dev_get_cma_area(dev), pages, count); > } This breaks the build for me if CONFIG_DMA_CMA=n: LD [M] fs/9p/9p.o ld: fs/9p/vfs_inode.o: in function `dma_alloc_contiguous': vfs_inode.c:(.text+0xa60): multiple definition of `dma_alloc_contiguous'; fs/9p/vfs_super.o:vfs_super.c:(.text+0x500): first defined here Do the following insertions need to be under an #ifdef CONFIG_DMA_CMA ? -dann > +/** > + * dma_alloc_contiguous() - allocate contiguous pages > + * @dev: Pointer to device for which the allocation is performed. > + * @size: Requested allocation size. > + * @gfp: Allocation flags. > + * > + * This function allocates contiguous memory buffer for specified device. It > + * first tries to use device specific contiguous memory area if available or > + * the default global one, then tries a fallback allocation of normal pages. > + */ > +struct page *dma_alloc_contiguous(struct device *dev, size_t size, gfp_t gfp) > +{ > + int node = dev ? dev_to_node(dev) : NUMA_NO_NODE; > + size_t count = PAGE_ALIGN(size) >> PAGE_SHIFT; > + size_t align = get_order(PAGE_ALIGN(size)); > + struct cma *cma = dev_get_cma_area(dev); > + struct page *page = NULL; > + > + /* CMA can be used only in the context which permits sleeping */ > + if (cma && gfpflags_allow_blocking(gfp)) { > + align = min_t(size_t, align, CONFIG_CMA_ALIGNMENT); > + page = cma_alloc(cma, count, align, gfp & __GFP_NOWARN); > + } > + > + /* Fallback allocation of normal pages */ > + if (!page) > + page = alloc_pages_node(node, gfp, align); > + > + return page; > +} > + > +/** > + * dma_free_contiguous() - release allocated pages > + * @dev: Pointer to device for which the pages were allocated. > + * @page: Pointer to the allocated pages. > + * @size: Size of allocated pages. > + * > + * This function releases memory allocated by dma_alloc_contiguous(). As the > + * cma_release returns false when provided pages do not belong to contiguous > + * area and true otherwise, this function then does a fallback __free_pages() > + * upon a false-return. > + */ > +void dma_free_contiguous(struct device *dev, struct page *page, size_t size) > +{ > + if (!cma_release(dev_get_cma_area(dev), page, size >> PAGE_SHIFT)) > + __free_pages(page, get_order(size)); > +} > + > /* > * Support for reserved memory regions defined in device tree > */ > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 2c2772e9702a..0816c1e8b05a 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -96,8 +96,6 @@ static bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size) > struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs) > { > - unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; > - int page_order = get_order(size); > struct page *page = NULL; > u64 phys_mask; > > @@ -109,20 +107,9 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > gfp |= __dma_direct_optimal_gfp_mask(dev, dev->coherent_dma_mask, > &phys_mask); > again: > - /* CMA can be used only in the context which permits sleeping */ > - if (gfpflags_allow_blocking(gfp)) { > - page = dma_alloc_from_contiguous(dev, count, page_order, > - gfp & __GFP_NOWARN); > - if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > - dma_release_from_contiguous(dev, page, count); > - page = NULL; > - } > - } > - if (!page) > - page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > - > + page = dma_alloc_contiguous(dev, size, gfp); > if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > - __free_pages(page, page_order); > + dma_free_contiguous(dev, page, size); > page = NULL; > > if (IS_ENABLED(CONFIG_ZONE_DMA32) && > @@ -154,7 +141,7 @@ void *dma_direct_alloc_pages(struct device *dev, size_t size, > if (PageHighMem(page)) { > /* > * Depending on the cma= arguments and per-arch setup > - * dma_alloc_from_contiguous could return highmem pages. > + * dma_alloc_contiguous could return highmem pages. > * Without remapping there is no way to return them here, > * so log an error and fail. > */ > @@ -176,10 +163,7 @@ void *dma_direct_alloc_pages(struct device *dev, size_t size, > > void __dma_direct_free_pages(struct device *dev, size_t size, struct page *page) > { > - unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; > - > - if (!dma_release_from_contiguous(dev, page, count)) > - __free_pages(page, get_order(size)); > + dma_free_contiguous(dev, page, size); > } > > void dma_direct_free_pages(struct device *dev, size_t size, void *cpu_addr, > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel