Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 24 May 2019 11:45:17 +0800
From:   Gen Zhang <blackgod016574@gmail.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     rppt@linux.ibm.com, david.engraf@sysgo.com, steven.price@arm.com,
        osandov@fb.com, luc.vanoostenryck@gmail.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] initramfs: Fix =?utf-8?Q?a_?=
 =?utf-8?Q?missing-chek_bug_in_dir=5Fadd=28=29teven=2Eprice=40arm=2Ecom?=
 =?utf-8?B?44CB?=
Message-ID: <20190524034517.GA6821@zhanggen-UX430UQ>
References: <20190524033045.GA6628@zhanggen-UX430UQ>
 <20190523203523.8f638f378b54df0ef7a18f9d@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Description: =?utf-8?B?YXZpZC5lbmdyYWZAc3lzZ28uY29t44CB?=
Content-Disposition: inline
In-Reply-To: <20190523203523.8f638f378b54df0ef7a18f9d@linux-foundation.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 23, 2019 at 08:35:23PM -0700, Andrew Morton wrote:
> On Fri, 24 May 2019 11:30:45 +0800 Gen Zhang <blackgod016574@gmail.com> wrote:
> 
> > In dir_add() and do_name(), de->name and vcollected are allocated by
> > kstrdup(). And de->name and vcollected are dereferenced in the following
> > codes. However, memory allocation functions such as kstrdup() may fail. 
> > Dereferencing this null pointer may cause the kernel go wrong. Thus we
> > should check these two kstrdup() operations.
> > Further, if kstrdup() returns NULL, we should free de in dir_add().
> 
> We generally assume that memory allocations within __init code cannot
> fail.  If one does fail, something quite horrid has happened.  The
> resulting oops will provide the same information as the proposed panic()
> anyway.
Thanks for your reply, Andrew.
You mean that it is not necessary to check memory allcoation in __init,
right?
Thanks
Gen