Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1557500579-19720-1-git-send-email-yannick.fertre@st.com> <aa466c60-9110-630e-3c75-99e632207334@st.com>
In-Reply-To: <aa466c60-9110-630e-3c75-99e632207334@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Fri, 24 May 2019 10:34:13 +0200
Message-ID: <CA+M3ks6nqUdMGxkBYf17ptVMB0P3xJ+cY93xXhCX6FTcKJr+eA@mail.gmail.com>
Subject: Re: [PATCH] drm/stm: dsi: check hardware version
To:     Philippe CORNU <philippe.cornu@st.com>
Cc:     Yannick FERTRE <yannick.fertre@st.com>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Vincent ABRIOU <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre TORGUE <alexandre.torgue@st.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le ven. 10 mai 2019 =C3=A0 18:31, Philippe CORNU <philippe.cornu@st.com> a =
=C3=A9crit :
>
>
> Dear Yannick,
> Thank you for your patch,
>
> Acked-by: Philippe Cornu <philippe.cornu@st.com>
>
> Dear Benjamin,
> If you are fine with this patch, please push it *after* the patch named
> "drm/stm: dsi: add support of an optional regulator" (if I well
> understood those two patches)
>
> Thank you
> Philippe :-)

Applied on drm-misc-next,

Benjamin
>
>
> On 5/10/19 5:02 PM, Yannick Fertr=C3=A9 wrote:
> > Check version of DSI hardware IP. Only versions 1.30 & 1.31
> > are supported.
> >
> > Signed-off-by: Yannick Fertr=C3=A9 <yannick.fertre@st.com>
> > ---
> >   drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 24 +++++++++++++++++++++++-
> >   1 file changed, 23 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/st=
m/dw_mipi_dsi-stm.c
> > index 22bd095..29105e9 100644
> > --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> > +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> > @@ -227,7 +227,6 @@ dw_mipi_dsi_get_lane_mbps(void *priv_data, const st=
ruct drm_display_mode *mode,
> >       u32 val;
> >
> >       /* Update lane capabilities according to hw version */
> > -     dsi->hw_version =3D dsi_read(dsi, DSI_VERSION) & VERSION;
> >       dsi->lane_min_kbps =3D LANE_MIN_KBPS;
> >       dsi->lane_max_kbps =3D LANE_MAX_KBPS;
> >       if (dsi->hw_version =3D=3D HWVER_131) {
> > @@ -306,6 +305,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_de=
vice *pdev)
> >   {
> >       struct device *dev =3D &pdev->dev;
> >       struct dw_mipi_dsi_stm *dsi;
> > +     struct clk *pclk;
> >       struct resource *res;
> >       int ret;
> >
> > @@ -347,6 +347,28 @@ static int dw_mipi_dsi_stm_probe(struct platform_d=
evice *pdev)
> >               goto err_clk_get;
> >       }
> >
> > +     pclk =3D devm_clk_get(dev, "pclk");
> > +     if (IS_ERR(pclk)) {
> > +             ret =3D PTR_ERR(pclk);
> > +             DRM_ERROR("Unable to get peripheral clock: %d\n", ret);
> > +             goto err_dsi_probe;
> > +     }
> > +
> > +     ret =3D clk_prepare_enable(pclk);
> > +     if (ret) {
> > +             DRM_ERROR("%s: Failed to enable peripheral clk\n", __func=
__);
> > +             goto err_dsi_probe;
> > +     }
> > +
> > +     dsi->hw_version =3D dsi_read(dsi, DSI_VERSION) & VERSION;
> > +     clk_disable_unprepare(pclk);
> > +
> > +     if (dsi->hw_version !=3D HWVER_130 && dsi->hw_version !=3D HWVER_=
131) {
> > +             ret =3D -ENODEV;
> > +             DRM_ERROR("bad dsi hardware version\n");
> > +             goto err_dsi_probe;
> > +     }
> > +
> >       dw_mipi_dsi_stm_plat_data.base =3D dsi->base;
> >       dw_mipi_dsi_stm_plat_data.priv_data =3D dsi;
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel