Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp174749ybi; Fri, 24 May 2019 02:00:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxBg7OI4vBHjlwH5NeZMnOdJJuJGZa1kl6oTO3YSdYfwoeIrQf1Xu8ulm2YxafRgh1Tkcbq X-Received: by 2002:a63:1160:: with SMTP id 32mr104667421pgr.106.1558688455405; Fri, 24 May 2019 02:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558688455; cv=none; d=google.com; s=arc-20160816; b=rBGVzXOiKemA0Qfgur5ROdi0sI6g2U1bXZJlOgz2jPrYJ73WUZGRMzC/JpqI7HR7/F 9fpWWhNQj0ZSy94xb89RNpmZMlPgI+8zW/WPXgpnq751nFqY9ZPvEGzlUvs3JAInrck0 Xs62OyZtttoZHr8Oo+ilDmTJOVrQvYCyTXzfvuZe+MeCAFI3UFkge1uV7pHVbx8NfFG1 YJpW5zyBxFevt2tPDm3C1V5OsuXnb21Tp09pXEUilBNgYuJP0fDRygnfDFt/8FaXbDwY HkMBLA6kGCu8lo9QTxbWiA+K+bNd48J1RhNWyUiJ6tehxAQaFAOiLhybMUmQtc0mbxh9 rBbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=SbM4kkl5EWVc1Lud+LN0uVoCMIXyfC33Tfm6rZ3mnEI=; b=kWmRoYVDbwotKt4oD4/Y8LJqS7xxy2SlwdxzsiBr63ing+UjFFDEqjU9d5JrpfYQY8 IlbXtgf+DKlqtEkGHVsztUfKloiPuylS4W4JaynXbY3rPzKDrtVO2QJycPIO/JEsmo7H dTb+s7H5LiL9UeLZLP+HWteja1ySkkGCRJ3usELqwfzOhQABVIcvz8P/1TpNGBZxZf2a 0rrjtdcrVdo4qgJj7HXWTLOIrCK5YiMRMBrxh9xw29D9JPxOFlwZcUFPt4lS9GOVEjvX UWiOEi0XO3Sm/VSDjgt3nDJ8F/oz5phmrYAmwGzYF3HrjK3IPtYfUiA2nVv6pPSGpNA2 jEcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="c/FPyF4y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e15si2836738pge.578.2019.05.24.02.00.36; Fri, 24 May 2019 02:00:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="c/FPyF4y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389808AbfEXIyF (ORCPT + 99 others); Fri, 24 May 2019 04:54:05 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:37169 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389709AbfEXIyE (ORCPT ); Fri, 24 May 2019 04:54:04 -0400 Received: by mail-ed1-f67.google.com with SMTP id w37so13334151edw.4 for ; Fri, 24 May 2019 01:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SbM4kkl5EWVc1Lud+LN0uVoCMIXyfC33Tfm6rZ3mnEI=; b=c/FPyF4yrdA+kyY4YOL61v9wViH0qXWsWn7LeQbNFRkgk/NtlJDZd/2fQOm5/hWjBa PLBpGyU8BH+CjKkw/vlnSJ1M9WN303wo9Lz5muTXupETgpDMznUolBtQcGizX4JWfCai ayz2xzztT1E0yJ7VrbMfYeDSWGkMTKBHplZi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SbM4kkl5EWVc1Lud+LN0uVoCMIXyfC33Tfm6rZ3mnEI=; b=EfGUPJqfFV5PLXFCl6waCqeJooJXZiiv2nRd5hU9Qyltmt1XjLLTlFBm1KrDNK3m/v e43jxkVQDPXCIF3tmpIMKlNZbESArLztVJGxCo/0BR7ZGxkGoHpQm28i9ay6HTON0UzM OnENC5w9mC1d7hnWh5Mj6TdjOWNi/OC3PqDY/PvXYQ8JLt3rtBoAMjz74zUmeIqz6OPT gxUrrH7RoJk2LcOds/QhlK/eUUItP7qcOXt07FK1rakXtxoFkahp82aICWvxVjWMxB6y 7mtcKtrwmtaH0cCCR8rL8ow+jocFtkuBJtFn+DQ9GfkmfJr+fpH9SZ4yHAvHns+GG0Ls bB1A== X-Gm-Message-State: APjAAAURb7iiawJuAGyKNpneYKQGmP2NVHwjOmGvEi33uigE6Ut26Rtj Set47GwgEjxUVRMEoAskYhKwUgdz178= X-Received: by 2002:a50:b1d1:: with SMTP id n17mr103556301edd.131.1558688042014; Fri, 24 May 2019 01:54:02 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id 96sm567082edq.68.2019.05.24.01.54.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 01:54:01 -0700 (PDT) From: Daniel Vetter To: LKML Cc: Intel Graphics Development , DRI Development , Daniel Vetter , Daniel Vetter , Bartlomiej Zolnierkiewicz , Hans de Goede , Greg Kroah-Hartman , Kees Cook , Nicolas Pitre Subject: [PATCH 01/33] dummycon: Sprinkle locking checks Date: Fri, 24 May 2019 10:53:22 +0200 Message-Id: <20190524085354.27411-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190524085354.27411-1-daniel.vetter@ffwll.ch> References: <20190524085354.27411-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As part of trying to understand the locking (or lack thereof) in the fbcon/vt/fbdev maze, annotate everything. Signed-off-by: Daniel Vetter Cc: Bartlomiej Zolnierkiewicz Cc: Hans de Goede Cc: Daniel Vetter Cc: Greg Kroah-Hartman Cc: Kees Cook Cc: Nicolas Pitre --- drivers/video/console/dummycon.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c index 45ad925ad5f8..2352b4c37826 100644 --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -33,6 +33,8 @@ static bool dummycon_putc_called; void dummycon_register_output_notifier(struct notifier_block *nb) { + WARN_CONSOLE_UNLOCKED(); + raw_notifier_chain_register(&dummycon_output_nh, nb); if (dummycon_putc_called) @@ -41,11 +43,15 @@ void dummycon_register_output_notifier(struct notifier_block *nb) void dummycon_unregister_output_notifier(struct notifier_block *nb) { + WARN_CONSOLE_UNLOCKED(); + raw_notifier_chain_unregister(&dummycon_output_nh, nb); } static void dummycon_putc(struct vc_data *vc, int c, int ypos, int xpos) { + WARN_CONSOLE_UNLOCKED(); + dummycon_putc_called = true; raw_notifier_call_chain(&dummycon_output_nh, 0, NULL); } -- 2.20.1