Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp216676ybi; Fri, 24 May 2019 02:43:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNyb8yBzMkPZcmlEzl1B9WUsU5+6QqjNPu0QpYuWqZVMK+CnMOUdpkUM0twybBT51K7clN X-Received: by 2002:a17:90a:33c5:: with SMTP id n63mr7879870pjb.16.1558691030561; Fri, 24 May 2019 02:43:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558691030; cv=none; d=google.com; s=arc-20160816; b=dQZCW9bJK/75WPZIOJJ2B2VTic9TX5JH4ElnzdFMI/gqc7Cl4usalx2xUqF58P5aPx 7YWDkn68iQZ40n0wWbyGg23M8zBfV0uIJoh5FI3HpL4o1552Scph/NSLmx5DVG0oCQoV pqlihJZ7e3QCa2fM5ZrB2UNuPxzzWkOYIEeIcCMtrvaYr2yqQzLtnAxfoiNEETzOWMK0 BC94ID+SZkzUoSmqtpWQ9qRa2O5yoBC2tc5MdYPpvf9l43uDYiKAHUSToL4RbnZt8ADO s5IyV2Fkd9dJuZyQikTh+SCvbjbV6Xur2L/hXCp9PBpjf9wbwyGWYJiVCEpVefpDtqaG eoZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y5N3blBOF57aEuNrqnxupdWMUAa8sEMVdsUI1rflzSQ=; b=WUR59e972qKjhde4x+q6lf6X7hVBpqHLhFEBdduiPI98hm3rzGNavf2V9cyxcEvdPe +j1YZwar+i/k1jgabSIAJ62DNvAfIoaltFMA6+zrjV6RN6JfZfyWGP0jXTKQUJD398Gw dzZ6pLP0HWaP5MDvlq0rIuxCTt076imrB1E3MeJoI/Gw4WQzWqx3uqrpGidFr5FE42Rp kGahfiuEm/rK41pBqaNaOYXYD8IifQo2aewI6Sc/zbc3hyxGBEmGXhnoxIuHTtplRvNX tTyEBWUVsRF6MNgL71zghaSw+VSH91RENCvUrLy9EdZeLJ4if2l8+VuPJ2Ptoy09Iy7R KDIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A3eoary3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si3207332plo.396.2019.05.24.02.43.32; Fri, 24 May 2019 02:43:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=A3eoary3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390144AbfEXJlu (ORCPT + 99 others); Fri, 24 May 2019 05:41:50 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46236 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390058AbfEXJlu (ORCPT ); Fri, 24 May 2019 05:41:50 -0400 Received: by mail-wr1-f67.google.com with SMTP id r7so9263389wrr.13 for ; Fri, 24 May 2019 02:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y5N3blBOF57aEuNrqnxupdWMUAa8sEMVdsUI1rflzSQ=; b=A3eoary35mP/ldGozEDAvNCMcz//E5Pp2NMOTYth62qhOZRHuBL/1IULlsfXC0iE9P 2U0gHdxYDJUaj4/6vWvRNMk5HbYNmIhmOG5NAYpgm3RxPw/J/9h8cmhnbF+Cey7mkEbG ccMh7n93p3TomLg1SElpLdEG6psgy5ls35POE7RF/bxByT7tjwKwdXvhdPmpWY0gf3O7 OtZsfHFApGsWlB1Rnobgx9Pxe8YvME0Af3Da4OtTI/6CIJtdOY4QyTRafmL1vqAuDiFa BzxusJ/C1QxGVMQzSZsPcl8j+TmsdyWxL3P+T5qGGixYakACt/r6OdNpNGJAvo2oZI61 SFlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y5N3blBOF57aEuNrqnxupdWMUAa8sEMVdsUI1rflzSQ=; b=CQl3n77U0SmdReydIaCZYtJCI92YC1Y3vBWwG+6AsiQJPZcz0cK5DnIw1yLOStUge8 c7Gvf2idzSnucH5MW4NyNv3m5XFKBduyfCjFKbuOhpZ11YYV9lH6xGcCY+Pn9pkDyPuV komHNiX4U345IQoK8hBmhfrcnaKZwVZcEhztLm4akqBhjbOD3iDdyd688SNquEUL4Z5m 6XDbgph2j2Fm5jqo7SizQrDlFdbB43MzDQ8ufNwV0R1zh22qK8r31gB7A9IxxD1D/+Px 1OnZ4qReX4CAC0EZDyJ67Z80v3QZN1sUyC7gue5PMXzaGQnwTH0AMXIN0piQiUU82E4g k1XQ== X-Gm-Message-State: APjAAAX3xFVjq0O/kS9kXVsH6t5OAiQD6Lm0ExPeWSn2dj3e6sPQIvsf 3VZs9VWoDCngbor9zGUpX5d1Ag== X-Received: by 2002:adf:aa09:: with SMTP id p9mr9813762wrd.59.1558690909082; Fri, 24 May 2019 02:41:49 -0700 (PDT) Received: from apalos (ppp-94-66-229-5.home.otenet.gr. [94.66.229.5]) by smtp.gmail.com with ESMTPSA id o23sm247011wro.13.2019.05.24.02.41.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 May 2019 02:41:48 -0700 (PDT) Date: Fri, 24 May 2019 12:41:45 +0300 From: Ilias Apalodimas To: Ivan Khoronzhuk Cc: grygorii.strashko@ti.com, hawk@kernel.org, davem@davemloft.net, ast@kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, xdp-newbies@vger.kernel.org, netdev@vger.kernel.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, john.fastabend@gmail.com Subject: Re: [PATCH net-next 0/3] net: ethernet: ti: cpsw: Add XDP support Message-ID: <20190524094145.GA24675@apalos> References: <20190523182035.9283-1-ivan.khoronzhuk@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523182035.9283-1-ivan.khoronzhuk@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ivan, More XDP drivers, that's good! > This patchset add XDP support for TI cpsw driver and base it on > page_pool allocator. It was verified on af_xdp socket drop, > af_xdp l2f, ebpf XDP_DROP, XDP_REDIRECT, XDP_PASS, XDP_TX. > > It was verified with following configs enabled: > CONFIG_JIT=y > CONFIG_BPFILTER=y > CONFIG_BPF_SYSCALL=y > CONFIG_XDP_SOCKETS=y > CONFIG_BPF_EVENTS=y > CONFIG_HAVE_EBPF_JIT=y > CONFIG_BPF_JIT=y > CONFIG_CGROUP_BPF=y > > Link on previous RFC: > https://lkml.org/lkml/2019/4/17/861 > The recycling pattern has changed i'll have a closer look in the weekend and let you know > Also regular tests with iperf2 were done in order to verify impact on > regular netstack performance, compared with base commit: > https://pastebin.com/JSMT0iZ4 Do you have any XDP related numbers? > > Based on net-next/master > > Ivan Khoronzhuk (3): > net: ethernet: ti: davinci_cpdma: add dma mapped submit > net: ethernet: ti: davinci_cpdma: return handler status > net: ethernet: ti: cpsw: add XDP support > > drivers/net/ethernet/ti/Kconfig | 1 + > drivers/net/ethernet/ti/cpsw.c | 570 +++++++++++++++++++++--- > drivers/net/ethernet/ti/cpsw_ethtool.c | 55 ++- > drivers/net/ethernet/ti/cpsw_priv.h | 9 +- > drivers/net/ethernet/ti/davinci_cpdma.c | 122 +++-- > drivers/net/ethernet/ti/davinci_cpdma.h | 6 +- > drivers/net/ethernet/ti/davinci_emac.c | 18 +- > 7 files changed, 675 insertions(+), 106 deletions(-) > > -- > 2.17.1 > Thanks /Ilias