Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp235189ybi; Fri, 24 May 2019 03:03:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqwRjZ5UyCbN1415xk4kYWcBD5Y3N9YPtV0DXge4YVfhq5/jh1tdyyefHcN2gw4tyjkBvTB+ X-Received: by 2002:a17:902:44a4:: with SMTP id l33mr8967483pld.337.1558692234138; Fri, 24 May 2019 03:03:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558692234; cv=none; d=google.com; s=arc-20160816; b=Yckp0LDOgYNpN74EJPnaG4dXERTeKh3pt1bf0OQY2Bf175FeoMJl8DHR5gJtF82PsK Gq+ihU4yv/LNJQ2hXH+7GRUAp3foG4vXN+ZZIzoZmZyJFnj5ylVlGCIr3NZHGNht8zQ2 Fl68ChLPtKWlo76KWe1J2sHwhMft5LN1PSG4jtcot3lFF7/R2xSWgOZmG9+fjZbU/8Vu pnBbeequUY5Hpr2u7ZW6O1AmpqfJGPvbMv4uwY6M7Z7QXn/Eiekl0f7/b5yF2ZF7r7y1 YPZR1sKeyG3EcUcpM3NgLhNTwIwgIuFlecfmYdHfTBZNfQ5GqXsKnJvT1A0FmQGTX5qR SEhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=BHE07MLVda5C3h/XRwBIWl05yx4BsX70iMU5GWwr3nM=; b=YRrPzJqJVNC0sc0cgQCBdxfveuHUVWH0Fr2QkJcFvGsi/QCEmQVQVx/xrNrcJKNaS5 maZiNyDgIG561Ss2w7N7Mvx0e5XPQpUHG98cDWPH73gMNy3YnLmG85TtreDH9bvnZwEe /gKUYhDFKIrZFcANST+IUuF4HH4UrtgkOEmN8tCxfS8nF1LZZzNX/VVjz6/pECf+Zxlc qOmZMAToYb7LJtVr+uuY1o9Wx3F+c5iZhOo0GtW0QHB/wnZfVX5pw8F1E+BS8uNCCmZP Xx/qDyiCW7ecCavKoPjGkpykwrxwV1je7P3cYoK0lE4c2wrQEcKM472ErlDcCqyw84wZ 7kPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g191si3585270pgc.197.2019.05.24.03.03.33; Fri, 24 May 2019 03:03:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390306AbfEXKAN (ORCPT + 99 others); Fri, 24 May 2019 06:00:13 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:38584 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389758AbfEXKAN (ORCPT ); Fri, 24 May 2019 06:00:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC285A78; Fri, 24 May 2019 03:00:12 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 544253F718; Fri, 24 May 2019 03:00:11 -0700 (PDT) Date: Fri, 24 May 2019 11:00:08 +0100 From: Will Deacon To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linux Containers , Oleg Nesterov , linux-arch@vger.kernel.org, Dave Martin , James Morse Subject: Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL Message-ID: <20190524100008.GE3432@fuggles.cambridge.arm.com> References: <20190523003916.20726-1-ebiederm@xmission.com> <20190523003916.20726-4-ebiederm@xmission.com> <20190523101702.GG26646@fuggles.cambridge.arm.com> <875zq1gnh4.fsf_-_@xmission.com> <20190523161509.GE31896@fuggles.cambridge.arm.com> <8736l4evkn.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8736l4evkn.fsf@xmission.com> User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 03:59:20PM -0500, Eric W. Biederman wrote: > Will Deacon writes: > > > On Thu, May 23, 2019 at 11:11:19AM -0500, Eric W. Biederman wrote: > >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > >> index ade32046f3fe..e45d5b440fb1 100644 > >> --- a/arch/arm64/kernel/traps.c > >> +++ b/arch/arm64/kernel/traps.c > >> @@ -256,7 +256,10 @@ void arm64_force_sig_fault(int signo, int code, void __user *addr, > >> const char *str) > >> { > >> arm64_show_signal(signo, str); > >> - force_sig_fault(signo, code, addr, current); > >> + if (signo == SIGKILL) > >> + force_sig(SIGKILL, current); > >> + else > >> + force_sig_fault(signo, code, addr, current); > >> } > > > > Acked-by: Will Deacon > > > > Are you planning to send this series on, or would you like me to pick this > > into the arm64 tree? > > I am planning on taking this through siginfo tree, unless it causes > problems. Okey doke, it would just be nice to see this patch land in 5.2, that's all. Will