Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp276073ybi; Fri, 24 May 2019 03:44:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7JrVJI2jlhIILLQzcusgCMF5wulIqPoxlRHTMSNLLD+vIfZ3fW1jKOhlem9RF68ChOjU2 X-Received: by 2002:a17:902:18a:: with SMTP id b10mr79478310plb.277.1558694670202; Fri, 24 May 2019 03:44:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558694670; cv=none; d=google.com; s=arc-20160816; b=dUwBjr6iXk1HZsHbVQMju/ZCtgrH/rFV3yPjxFcUT+NkDbVAfNbPemn9LxTmQ7TuUA ATXTY3YXAo7VZnH/xSosD5ba0ihZoSxaxszOmJzbatGql7lX3B2xSk/KwS8yymrOU0ij ndeo2mq/M/joCAk/Ce0VpONK92SkQ41GAaW+imJEsBBjOuFKLdlieGRXjuty267SRypc 9wWwRwjQ6h55Ix1UnvhYHP4x+jgKAQ/WQYvuFQuaencHyZcuZ8rkP6Q6T/jGnZVGQA+s qvBgKjN0BOZKIEbwJIA2ZJvFWpDes9CHPbO5nraabZqDvmm2VD0uZaVZDtDBU0A6YQpn o/Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=n+qeBJwz0kgnFBzdg7sL3dpJilLxbEmfJ382JBCk3Kk=; b=zqpNXB3KtHEsNdYiEGrc3V24+1ZEqQlfm6ayGeWXKASqNQ5TxfqgCKIWVO2bLHbovi xl69iooGFv9ygwTEdj2Zb6sQGwh44VIFR6k7B6hNpqux9TJOUWbAkPS6ExXWeJGjXrSa PeSewp9XpbmdjfTp8MiM0pET4MQOoBe4bTqX14/zWktLFGpSljHOeTEWOl99IY93pG4Y Kjy0tMAyuWmP2XLMHgYUebQIMDdYN3N+ArDHi6yRTus0Y7qB8IKXLy5g93JaTbqThsiC nX3QyMfWg0F2JtWNFsm5aC6MPCbU1aZlE9pIRfPiuVIimljOVwIHvqIjxlNRi5OqEM22 /hgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v11si3573277pgi.568.2019.05.24.03.44.14; Fri, 24 May 2019 03:44:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390702AbfEXKmz (ORCPT + 99 others); Fri, 24 May 2019 06:42:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390374AbfEXKmy (ORCPT ); Fri, 24 May 2019 06:42:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A380308424C; Fri, 24 May 2019 10:42:54 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-101.ams2.redhat.com [10.36.116.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id DEA875B683; Fri, 24 May 2019 10:42:51 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0FD2511AB5; Fri, 24 May 2019 12:42:51 +0200 (CEST) From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: Gerd Hoffmann , Dave Airlie , David Airlie , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), spice-devel@lists.freedesktop.org (open list:DRM DRIVER FOR QXL VIRTUAL GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/qxl: drop WARN_ONCE() Date: Fri, 24 May 2019 12:42:50 +0200 Message-Id: <20190524104251.22761-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 24 May 2019 10:42:54 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no good reason to flood the kernel log with a WARN stacktrace just because someone tried to mmap a prime buffer. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_prime.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_prime.c b/drivers/gpu/drm/qxl/qxl_prime.c index 114653b471c6..7d3816fca5a8 100644 --- a/drivers/gpu/drm/qxl/qxl_prime.c +++ b/drivers/gpu/drm/qxl/qxl_prime.c @@ -77,6 +77,5 @@ void qxl_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr) int qxl_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *area) { - WARN_ONCE(1, "not implemented"); return -ENOSYS; } -- 2.18.1