Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp370851ybi; Fri, 24 May 2019 05:15:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwWWk1mxRnLSNyWpPBqRC/aPWsUT8ozSZftjPPNLhPgvaI074LqtnJ0B7uV0x0Bq7CMJxkh X-Received: by 2002:a62:ed1a:: with SMTP id u26mr106086986pfh.229.1558700118632; Fri, 24 May 2019 05:15:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558700118; cv=none; d=google.com; s=arc-20160816; b=cVYYOx4QsQLrzmwpqXAlatX+9MOJ4ebV/eTHjSScV5XhX+WmEVCBMXTuUTzyw/AInj SQuK9ME1mYxnZWej5aaNH2EP1RNL1feAPAVc7Qhov/OnwrHXvedapRpWk96/bW7BevhV lPAS1mZlGIHr9+fzfVokNwUo0nQNOMhDBx15En2We7nIm1pcgQ8RZQRMQX6wgelQQmFR 2U06qmvUQSC7Vu3dBhn0bDKBcW5jmcRjDojtKGAVHGBXN/fqIYvXtcq3yLF3tR2eGaMp dPn8aUubz0M6YyVgLFFmbBzoGibkYc6kMxuyN9uH40s/I3EsXQ84To91WJyldarwrd+p pjvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=1jfbm+ilo7jODaRxd8Scvr0X0nhcAhiF59hj2x7IHRk=; b=cJJH6ZNfkFEVsauBTlbB+GvX/dgAHAbYtGCSkP+5opsemYhBNoKYV4GBcyUb4enm5u TO7OdwmVVX8MWXU46CObAUljBNUHuS0BTJ0vWjVURRAk+4YWN2W46A/Xpc8q5CpVH+Nm 1t+I5IOAEjeO3cIDM7OTkrimB+Iey6g4g/kl65wHy8mVV0jT9w7Bw1NzF+1xmpakYDCP ljruzWjKXoNlpIUpwisSPmrQWeO581mG9+p6fg1Q4N8z//cOq2m4U5sHXbIdLTMtP22C ncDnJbJu2m+XmtEQ36+cU94dTh1q+sDiqOoP/gvHI2lAmUKU4NR1IeO901Qz+xC7dyQ3 NTDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ShjilB1E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si3467924pjq.54.2019.05.24.05.15.02; Fri, 24 May 2019 05:15:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ShjilB1E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391480AbfEXMMv (ORCPT + 99 others); Fri, 24 May 2019 08:12:51 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43310 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391449AbfEXMMv (ORCPT ); Fri, 24 May 2019 08:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=1jfbm+ilo7jODaRxd8Scvr0X0nhcAhiF59hj2x7IHRk=; b=ShjilB1EhGZQ Sd50u6x0iF3W13fvmbZze9Hnc5JpyFGWcRvuPq4HHsmTqGKgmgaVbPWIGPwvnhcXw82ADLoX9QQS1 tjbrRiXwN71Yym0BWnPOuYASF8ZcMQZhGCQBUvbH+rize5FixWquy4SpF5n3Tj8bui+BiIt5ot/Sc Dkr00=; Received: from [176.12.107.140] (helo=finisterre.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hU943-0003DW-EW; Fri, 24 May 2019 12:12:47 +0000 Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id 804B1440046; Fri, 24 May 2019 13:12:46 +0100 (BST) From: Mark Brown To: Axel Lin Cc: Eric Jeong , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Support Opensource Subject: Applied "regulator: slg51000: Remove unneeded regl_pdata from struct slg51000" to the regulator tree In-Reply-To: <20190524100247.7267-2-axel.lin@ingics.com> X-Patchwork-Hint: ignore Message-Id: <20190524121246.804B1440046@finisterre.sirena.org.uk> Date: Fri, 24 May 2019 13:12:46 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch regulator: slg51000: Remove unneeded regl_pdata from struct slg51000 has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 12c574d84c8e492320a4e75b2c1157f8b61e4092 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Fri, 24 May 2019 18:02:47 +0800 Subject: [PATCH] regulator: slg51000: Remove unneeded regl_pdata from struct slg51000 Just use a local variable *ena_gpiod in slg51000_of_parse_cb instead. With this change, the struct slg51000_pdata can be removed. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- drivers/regulator/slg51000-regulator.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/regulator/slg51000-regulator.c b/drivers/regulator/slg51000-regulator.c index a06a18f220e0..04b732991d69 100644 --- a/drivers/regulator/slg51000-regulator.c +++ b/drivers/regulator/slg51000-regulator.c @@ -35,14 +35,9 @@ enum slg51000_regulators { SLG51000_MAX_REGULATORS, }; -struct slg51000_pdata { - struct gpio_desc *ena_gpiod; -}; - struct slg51000 { struct device *dev; struct regmap *regmap; - struct slg51000_pdata regl_pdata[SLG51000_MAX_REGULATORS]; struct regulator_desc *rdesc[SLG51000_MAX_REGULATORS]; struct regulator_dev *rdev[SLG51000_MAX_REGULATORS]; struct gpio_desc *cs_gpiod; @@ -204,14 +199,14 @@ static int slg51000_of_parse_cb(struct device_node *np, struct regulator_config *config) { struct slg51000 *chip = config->driver_data; - struct slg51000_pdata *rpdata = &chip->regl_pdata[desc->id]; + struct gpio_desc *ena_gpiod; enum gpiod_flags gflags = GPIOD_OUT_LOW | GPIOD_FLAGS_BIT_NONEXCLUSIVE; - rpdata->ena_gpiod = devm_gpiod_get_from_of_node(chip->dev, np, - "enable-gpios", 0, - gflags, "gpio-en-ldo"); - if (rpdata->ena_gpiod) { - config->ena_gpiod = rpdata->ena_gpiod; + ena_gpiod = devm_gpiod_get_from_of_node(chip->dev, np, + "enable-gpios", 0, + gflags, "gpio-en-ldo"); + if (ena_gpiod) { + config->ena_gpiod = ena_gpiod; devm_gpiod_unhinge(chip->dev, config->ena_gpiod); } -- 2.20.1