Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp389967ybi; Fri, 24 May 2019 05:32:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFNzAhn2Rop0FsODVWCw/LTBM7QSGen/rIO580D9etagxOEIQSR9P5nlqK/YvhAh0ZakED X-Received: by 2002:a17:902:9348:: with SMTP id g8mr63155005plp.174.1558701139278; Fri, 24 May 2019 05:32:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558701139; cv=none; d=google.com; s=arc-20160816; b=O1z8BRYk+KxDJ/4Ibwjh/8K14GPVySYkbXH69BYA3aXgjP8sR1S30PCuv8fAmfH3wk D09lC/j2va/dHMWguA5mhcMgjO5V8Hu1zP66BSwdnfeMIF2VBtkImLC1wWwRNF5AQBnK ShlM55G+KwmFQIl2gCpYJuJrGYemR3ySh27HM70gWAibi0xjHaeLYMx3vdUKJg2cSolp /FBHVnt8Sd+w4/EvJfz1MC95lp/lDdUxkcPMdhiINcPdIvI7gCao64mluL5C8gTH5rAr E7n6cFm/AZuI86PVDOZnZAsW9dFFhsPFDmqXlFb2vR+S2GtRLU001Ru+wSeRbeF5R1jt ePiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:message-id :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:autocrypt:openpgp:references:cc:to:from; bh=v+QcfrJVrxCT18elN0rlm7wDXchrRXqb8V8vR9jDdLo=; b=m5Z0WJYgxx9uxF4q62p8rssxG8hkHM1l0qW5jynz67IHocgZl8i7wcEDSR7QabEvaL M707bvC/BvbwbXJ0HvXHjYCjAmidwlQxwct7VWv+zPT1rmbhNmvs7hCZxYJDbLiZXPKI vHfe0uovHvjxyTiktIhlRYu/Lr1dZemDsOQzFZOrvTGQX4OC/6HDGXKLyGM1flkx41/U E0WekLRuUtuE9pEo64HZoukRu6DsVOuipTVRufXzlnaiLOMM5u15+I+PiM3p7P52fi2D E5svJaO7FvRh0WVZ/syinSWnzGsITrEWwHy0UvRMYW5BICRTEUpd4+mkeEOYyHm8izoz YoXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si2173447pgg.523.2019.05.24.05.32.01; Fri, 24 May 2019 05:32:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391581AbfEXM3y (ORCPT + 99 others); Fri, 24 May 2019 08:29:54 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52914 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389057AbfEXM3x (ORCPT ); Fri, 24 May 2019 08:29:53 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4OCDfmT131752 for ; Fri, 24 May 2019 08:29:52 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2speeupwcr-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 24 May 2019 08:29:52 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 May 2019 13:29:49 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 24 May 2019 13:29:45 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x4OCTi1r50397408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 May 2019 12:29:44 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85B3452051; Fri, 24 May 2019 12:29:44 +0000 (GMT) Received: from oc7455500831.ibm.com (unknown [9.145.172.211]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id F253E5204E; Fri, 24 May 2019 12:29:43 +0000 (GMT) From: Christian Borntraeger To: Thomas Huth , Janosch Frank , kvm@vger.kernel.org Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Shuah Khan , David Hildenbrand , Cornelia Huck , Andrew Jones , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org References: <20190523164309.13345-1-thuth@redhat.com> <0ad63449-c329-f38d-b879-6e427e6a8656@de.ibm.com> Openpgp: preference=signencrypt Autocrypt: addr=borntraeger@de.ibm.com; prefer-encrypt=mutual; keydata= mQINBE6cPPgBEAC2VpALY0UJjGmgAmavkL/iAdqul2/F9ONz42K6NrwmT+SI9CylKHIX+fdf J34pLNJDmDVEdeb+brtpwC9JEZOLVE0nb+SR83CsAINJYKG3V1b3Kfs0hydseYKsBYqJTN2j CmUXDYq9J7uOyQQ7TNVoQejmpp5ifR4EzwIFfmYDekxRVZDJygD0wL/EzUr8Je3/j548NLyL 4Uhv6CIPf3TY3/aLVKXdxz/ntbLgMcfZsDoHgDk3lY3r1iwbWwEM2+eYRdSZaR4VD+JRD7p8 0FBadNwWnBce1fmQp3EklodGi5y7TNZ/CKdJ+jRPAAnw7SINhSd7PhJMruDAJaUlbYaIm23A +82g+IGe4z9tRGQ9TAflezVMhT5J3ccu6cpIjjvwDlbxucSmtVi5VtPAMTLmfjYp7VY2Tgr+ T92v7+V96jAfE3Zy2nq52e8RDdUo/F6faxcumdl+aLhhKLXgrozpoe2nL0Nyc2uqFjkjwXXI OBQiaqGeWtxeKJP+O8MIpjyGuHUGzvjNx5S/592TQO3phpT5IFWfMgbu4OreZ9yekDhf7Cvn /fkYsiLDz9W6Clihd/xlpm79+jlhm4E3xBPiQOPCZowmHjx57mXVAypOP2Eu+i2nyQrkapaY IdisDQfWPdNeHNOiPnPS3+GhVlPcqSJAIWnuO7Ofw1ZVOyg/jwARAQABtDRDaHJpc3RpYW4g Qm9ybnRyYWVnZXIgKElCTSkgPGJvcm50cmFlZ2VyQGRlLmlibS5jb20+iQI4BBMBAgAiBQJO nDz4AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRARe7yAtaYcfOYVD/9sqc6ZdYKD bmDIvc2/1LL0g7OgiA8pHJlYN2WHvIhUoZUIqy8Sw2EFny/nlpPVWfG290JizNS2LZ0mCeGZ 80yt0EpQNR8tLVzLSSr0GgoY0lwsKhAnx3p3AOrA8WXsPL6prLAu3yJI5D0ym4MJ6KlYVIjU ppi4NLWz7ncA2nDwiIqk8PBGxsjdc/W767zOOv7117rwhaGHgrJ2tLxoGWj0uoH3ZVhITP1z gqHXYaehPEELDV36WrSKidTarfThCWW0T3y4bH/mjvqi4ji9emp1/pOWs5/fmd4HpKW+44tD Yt4rSJRSa8lsXnZaEPaeY3nkbWPcy3vX6qafIey5d8dc8Uyaan39WslnJFNEx8cCqJrC77kI vcnl65HaW3y48DezrMDH34t3FsNrSVv5fRQ0mbEed8hbn4jguFAjPt4az1xawSp0YvhzwATJ YmZWRMa3LPx/fAxoolq9cNa0UB3D3jmikWktm+Jnp6aPeQ2Db3C0cDyxcOQY/GASYHY3KNra z8iwS7vULyq1lVhOXg1EeSm+lXQ1Ciz3ub3AhzE4c0ASqRrIHloVHBmh4favY4DEFN19Xw1p 76vBu6QjlsJGjvROW3GRKpLGogQTLslbjCdIYyp3AJq2KkoKxqdeQYm0LZXjtAwtRDbDo71C FxS7i/qfvWJv8ie7bE9A6Wsjn7kCDQROnDz4ARAAmPI1e8xB0k23TsEg8O1sBCTXkV8HSEq7 JlWz7SWyM8oFkJqYAB7E1GTXV5UZcr9iurCMKGSTrSu3ermLja4+k0w71pLxws859V+3z1jr nhB3dGzVZEUhCr3EuN0t8eHSLSMyrlPL5qJ11JelnuhToT6535cLOzeTlECc51bp5Xf6/XSx SMQaIU1nDM31R13o98oRPQnvSqOeljc25aflKnVkSfqWSrZmb4b0bcWUFFUKVPfQ5Z6JEcJg Hp7qPXHW7+tJTgmI1iM/BIkDwQ8qe3Wz8R6rfupde+T70NiId1M9w5rdo0JJsjKAPePKOSDo RX1kseJsTZH88wyJ30WuqEqH9zBxif0WtPQUTjz/YgFbmZ8OkB1i+lrBCVHPdcmvathknAxS bXL7j37VmYNyVoXez11zPYm+7LA2rvzP9WxR8bPhJvHLhKGk2kZESiNFzP/E4r4Wo24GT4eh YrDo7GBHN82V4O9JxWZtjpxBBl8bH9PvGWBmOXky7/bP6h96jFu9ZYzVgIkBP3UYW+Pb1a+b w4A83/5ImPwtBrN324bNUxPPqUWNW0ftiR5b81ms/rOcDC/k/VoN1B+IHkXrcBf742VOLID4 YP+CB9GXrwuF5KyQ5zEPCAjlOqZoq1fX/xGSsumfM7d6/OR8lvUPmqHfAzW3s9n4lZOW5Jfx bbkAEQEAAYkCHwQYAQIACQUCTpw8+AIbDAAKCRARe7yAtaYcfPzbD/9WNGVf60oXezNzSVCL hfS36l/zy4iy9H9rUZFmmmlBufWOATjiGAXnn0rr/Jh6Zy9NHuvpe3tyNYZLjB9pHT6mRZX7 Z1vDxeLgMjTv983TQ2hUSlhRSc6e6kGDJyG1WnGQaqymUllCmeC/p9q5m3IRxQrd0skfdN1V AMttRwvipmnMduy5SdNayY2YbhWLQ2wS3XHJ39a7D7SQz+gUQfXgE3pf3FlwbwZhRtVR3z5u aKjxqjybS3Ojimx4NkWjidwOaUVZTqEecBV+QCzi2oDr9+XtEs0m5YGI4v+Y/kHocNBP0myd pF3OoXvcWdTb5atk+OKcc8t4TviKy1WCNujC+yBSq3OM8gbmk6NwCwqhHQzXCibMlVF9hq5a FiJb8p4QKSVyLhM8EM3HtiFqFJSV7F+h+2W0kDyzBGyE0D8z3T+L3MOj3JJJkfCwbEbTpk4f n8zMboekuNruDw1OADRMPlhoWb+g6exBWx/YN4AY9LbE2KuaScONqph5/HvJDsUldcRN3a5V RGIN40QWFVlZvkKIEkzlzqpAyGaRLhXJPv/6tpoQaCQQoSAc5Z9kM/wEd9e2zMeojcWjUXgg oWj8A/wY4UXExGBu+UCzzP/6sQRpBiPFgmqPTytrDo/gsUGqjOudLiHQcMU+uunULYQxVghC syiRa+UVlsKmx1hsEg== Date: Fri, 24 May 2019 14:29:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19052412-0028-0000-0000-000003710425 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19052412-0029-0000-0000-00002430BA05 Message-Id: <411d4ad9-b43e-d3ae-1b66-65888c894caa@de.ibm.com> Subject: Re: [PATCH v1 0/9] KVM selftests for s390x X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-24_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=951 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905240084 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24.05.19 14:17, Christian Borntraeger wrote: > > > On 24.05.19 13:11, Christian Borntraeger wrote: >> I do get >> >> [10400.440298] kvm-s390: failed to commit memory region >> [10400.508723] kvm-s390: failed to commit memory region >> >> when running the tests. Will have a look. > > It comes from kvm_vm_free. This calls KVM_SET_USER_MEMORY_REGION with size 0, > which the s390 code does not like. > The doc says about KVM_SET_USER_MEMORY_REGION: This ioctl allows the user to create or modify a guest physical memory slot. When changing an existing slot, it may be moved in the guest physical memory space, or its flags may be modified. --> It may not be resized. <---- $ strace -f -e trace=ioctl tools/testing/selftests/kvm/s390x/sync_regs_test ioctl(3, KVM_CHECK_EXTENSION, KVM_CAP_SYNC_REGS) = 1 ioctl(4, KVM_CHECK_EXTENSION, KVM_CAP_IMMEDIATE_EXIT) = 1 ioctl(3, KVM_CREATE_VM, 0) = 4 ioctl(4, KVM_SET_USER_MEMORY_REGION, {slot=0, flags=0, guest_phys_addr=0, memory_size=2097152, userspace_addr=0x3ffac500000}) = 0 ioctl(4, KVM_CREATE_VCPU, 5) = 7 ioctl(8, KVM_GET_VCPU_MMAP_SIZE, 0) = 4096 ioctl(8, KVM_GET_VCPU_MMAP_SIZE, 0) = 4096 ioctl(7, KVM_GET_SREGS, 0x3ffef0fdb90) = 0 ioctl(7, KVM_SET_SREGS, 0x3ffef0fdb90) = 0 ioctl(7, KVM_GET_REGS, 0x3ffef0fdcf8) = 0 ioctl(7, KVM_SET_REGS, 0x3ffef0fdcf8) = 0 ioctl(7, KVM_GET_SREGS, 0x3ffef0fdd78) = 0 ioctl(7, KVM_SET_SREGS, 0x3ffef0fdd78) = 0 ioctl(7, KVM_RUN, 0) = 0 ioctl(7, KVM_GET_REGS, 0x3ffef0fdf90) = 0 ioctl(7, KVM_GET_SREGS, 0x3ffef0fe010) = 0 ioctl(7, KVM_RUN, 0) = 0 ioctl(7, KVM_GET_REGS, 0x3ffef0fdf90) = 0 ioctl(7, KVM_GET_SREGS, 0x3ffef0fe010) = 0 ioctl(7, KVM_RUN, 0) = 0 ioctl(4, KVM_SET_USER_MEMORY_REGION, {slot=0, flags=0, guest_phys_addr=0, memory_size=0, userspace_addr=0x3ffac500000}) = 0 +++ exited with 0 +++ So the testcase is wrong? (I think the s390 code is also not fully correct will double check)