Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp503818ybi; Fri, 24 May 2019 07:12:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/g9kCXK5bFIkeOT8/JdY+JCfzFEF4mFyMg8ZQAKemARATpZrVkC6yaMM+hLlpQH0ELZ9h X-Received: by 2002:a63:7146:: with SMTP id b6mr102177892pgn.426.1558707127668; Fri, 24 May 2019 07:12:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558707127; cv=none; d=google.com; s=arc-20160816; b=AqXMM3o1y2HEmdL/tNbRqKTbd7yPb4rbDyMePKCWJwZmqqIlIpejws7B9lKz6jX+oF hhfS1f7xxTTPv/D7DDiOK2QukAEfjkaCNDo+O53OeBsz+PzrF4KAUHg4UHWOOw/GwT/E ko1rHaKGkPZU0lbO+Bj1v3K46DOFfyy+YVnXKDZgbTqh++SOuD6NNDQ5f365d/C0pHpz m3ixZwROOsqXBFXWy/wZCrxaf65nPdnS3YR/CC6/9MvT6kd531uDICuT6NVddm2Jw3K6 83+aKsfKp1eQHQRfhRDUNNGQDVMX/gC45Kw8AGAngih558LNjhalu3dbF9mqggUizd6R 55aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xSF9eu8opdefdpigsESjYJVMkC5cltZDRkcdc5Jvsx8=; b=Ng7YJHb04YC7nZBI4n59a+4gby6VkXtrHnVhGBlr6bnhsqvUlm7cRSgvfKY3NJXWso XYiorVRSHlX5YS/qzdLsPCMxh8lDr2Y+DNR2KHrAKFZ2NjK6haObZrxUPJCZB0ps+cqW G2GGeUsQuZ7vqW+nQQWxfw2eped22NjtO2FeVgFYf7eTKlP5VpDHkUwtccz/AU6BAy8Z DfmxtPXeIDNhSt9HzIYZeWV9M3uwPio74q6wmkFBB3l2zcJLi6X3wKY3bq85aJB3cDHO 9/C3oolPvR6TENSn9OZI+82c62QACWCO15YN4Iq1mOU5SWumPxw9InpvFB0z7DwmCDpE Htdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b61si4252761pjc.46.2019.05.24.07.11.50; Fri, 24 May 2019 07:12:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403932AbfEXOKg (ORCPT + 99 others); Fri, 24 May 2019 10:10:36 -0400 Received: from verein.lst.de ([213.95.11.211]:54179 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403843AbfEXOKg (ORCPT ); Fri, 24 May 2019 10:10:36 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id D03B7227A81; Fri, 24 May 2019 16:10:11 +0200 (CEST) Date: Fri, 24 May 2019 16:10:11 +0200 From: "hch@lst.de" To: Thomas Hellstrom Cc: "hch@lst.de" , "cai@lca.pw" , "daniel@ffwll.ch" , "robin.murphy@arm.com" , "m.szyprowski@samsung.com" , "dri-devel@lists.freedesktop.org" , Linux-graphics-maintainer , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm/vmwgfx: fix a warning due to missing dma_parms Message-ID: <20190524141011.GA23514@lst.de> References: <20190524023719.1495-1-cai@lca.pw> <20190524061936.GA2337@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 24, 2019 at 11:57:04AM +0000, Thomas Hellstrom wrote: > It's a PCI device. The struct device * used in dma_map_sg() is the same > as the &pci_dev->dev handed to the probe() callback. But at probe time, > the struct device::dma_parms is non-NULL, at least on my system so > there shouldn't really be a need to kzalloc() it. Then there is something really odd going on in the OPs setup..