Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp518465ybi; Fri, 24 May 2019 07:22:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqysj/YaMGhpFON3saYOTw2zH3OexNFDlTDf/lqYCp7Q75lp68APwhEdS0477C2uXQy9+XhV X-Received: by 2002:a17:902:a511:: with SMTP id s17mr3982509plq.67.1558707767004; Fri, 24 May 2019 07:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558707766; cv=none; d=google.com; s=arc-20160816; b=wDbeJlMBtbP1MNbMW6ok0hvlTx+W8C+7tKfzzYjBK9miQ2ARKxh+e6YJ0uKJ+hoVV5 2YbkwghJ7O+8yJJ6Tv5ntRkTzHsajSSpzFFjRKfyjsFGQH74cPETln2k0AQKxub5Zis1 VkUgYfoPW5xaWCLlbYZU8iGEYwyySA/F6JEu7631mmxO+4qaW4bEsyZ/dhRkf3a865ae EKJqoqLiKFFGY1L6EDC4chW4GKrlDqrMeZ8mVMQZu6XtXxvyTCYum2HjX7rCB8z7u2lh odFZSkMKuitCHmCDyGfTC8avFi0TTgYlAxonAZTCeQMUAVAh3lBrEt/yIOBvHxZ8zxc0 RAfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=6QwJZoGHzXhv+DDjewYpBu/pwbbbXPBfximneHm1YCU=; b=wbwgMSTtbwYM04Swrc85gzxVa//gO6gmifXwjdvucRSLEtMrI7IMBP+4nISCWGnvZS ZkuxbiZ/FWQgtojjKr9Z5phuBN6Z8hqjffOqGtz/2zOZ6Y4Pgqmel04Cz8QqJdG/x3Rb IWbxcdTPyaGB1LxT7v6Ub2GIdaGrB+ITVHDHjWubV+w5TYiVE0fTbZfi043BJpMzb3lD RfRWx5n52ZRbAIXFHRpIQHY1jct+T7Wl2f6E2JDndFsrl4GkX9ihAtUkMRvDzQrxeebj awI3gKIzywHkj6CEvmwL3CXfnSTOgK6dYm6yAA09K6Ot6kKCjeGtLd5lcLoPc6nZxOem q6eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g98si609243plb.38.2019.05.24.07.22.30; Fri, 24 May 2019 07:22:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404119AbfEXOT5 (ORCPT + 99 others); Fri, 24 May 2019 10:19:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45064 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403917AbfEXOT5 (ORCPT ); Fri, 24 May 2019 10:19:57 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDD9575733; Fri, 24 May 2019 14:19:51 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.159]) by smtp.corp.redhat.com (Postfix) with SMTP id D58F57C55C; Fri, 24 May 2019 14:19:48 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 24 May 2019 16:19:51 +0200 (CEST) Date: Fri, 24 May 2019 16:19:48 +0200 From: Oleg Nesterov To: Deepa Dinamani Cc: David Laight , Linux Kernel Mailing List , Andrew Morton , Alexander Viro , Arnd Bergmann , "dbueso@suse.de" , "axboe@kernel.dk" , Davidlohr Bueso , Eric Wong , Jason Baron , Linux FS-devel Mailing List , linux-aio , Omar Kilani , Thomas Gleixner , "stable@vger.kernel.org" Subject: Re: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask() Message-ID: <20190524141947.GC2655@redhat.com> References: <20190522150505.GA4915@redhat.com> <20190522161407.GB4915@redhat.com> <4f7b6dbeab1d424baaebd7a5df116349@AcuMS.aculab.com> <20190523145944.GB23070@redhat.com> <345cfba5edde470f9a68d913f44fa342@AcuMS.aculab.com> <20190523163604.GE23070@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 24 May 2019 14:19:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/23, Deepa Dinamani wrote: > > 1. block the signals you don't care about. > 2. syscall() > 3. unblock the signals blocked in 1. and even this part of your email is very confusing. because in this case we can never miss a signal. I'd say 1. block the signals you don't care about 2. unblock the signals which should interrupt the syscall below 3. syscall() 4. block the signals unblocked in 2. Oleg.