Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190524143827.43301-1-wangkefeng.wang@huawei.com>
In-Reply-To: <20190524143827.43301-1-wangkefeng.wang@huawei.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Fri, 24 May 2019 08:00:34 -0700
Message-ID: <CANn89i+rSEJ3Rqd5JW-w7aLzETMX89Qgg3wne9Ae7WWDBe3yZg@mail.gmail.com>
Subject: Re: [PATCH] kernel: sysctl: change ipfrag_high/low_thresh to CTL_ULONG
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "David S. Miller" <davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, May 24, 2019 at 7:30 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> 3e67f106f619 ("inet: frags: break the 2GB limit for frags storage"),
> changes ipfrag_high/low_thread 'type' from int to long, using CTL_ULONG
> instead of CTL_INT to keep consistent.


What about  compatibility with existing applications ?
Will there sysctl() fail if they provide 32bit variable ?

/proc/sys/net  files are text files, but sysctl() system call has been
discouraged for more than a decade.