Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp594915ybi; Fri, 24 May 2019 08:25:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxjCUXMb+scWKhyetpuhmmSXbHlmNXKoHI8NfTyZIpuy54oNT1NtGLIFllRbEBVuzTWjQfe X-Received: by 2002:a17:902:6bcb:: with SMTP id m11mr36424213plt.318.1558711540093; Fri, 24 May 2019 08:25:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558711540; cv=none; d=google.com; s=arc-20160816; b=d2j0Fu1lLaFF9u1VeUB55+DkY0SzFCQE+g1JXrYINLzvaSHjIJcjp5Cq6L3t41yrq7 M447M6/CHK/LxNIliN7kytEBxi0G8fql8ihn4+LMjdGsSISrlYKQgRuhVuLkoevw227R YxDZY1m8UQrCdsPb023FnYt54CTcRI7IaRsfzEFrT356DIPwSLT6+EuaH3YC8pBfv6NE lJ8O4ANxddSPKryvOvWPBAhmEBdgbG20TkmU9MNM7sfME5VjVVgq5DXQ2NLxCcbGKoSP 7XaGpS/XKa8LWUUaFiWL2RMeyxKH8R/opyt46BTm3E6JtvIsYkOZz11683gHzNY92mFz OGzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date:dkim-signature; bh=k7OmuisNkzkTwuYE/EQOJliDD8pcB5YSDLZEagInUrA=; b=p3ni2Q68NPdSeukvXDfm3lpmAZl1F5P1FIw3irl2biwF2PPk4t8F8nP6UprPgXH/FR Oea09Nx5SYMWEgSDxPZ1RDIovhNDbLChmFMHXFKXKve59ZOs1KBtEEDfJVzbaaJKvGkZ I0TOhEVoDiDuic2TOMFI0Zh4NBPeS3EqsoppGX6AaKf1dpCGqPO0a0ncjlbbvK4g5/z3 SU+KX9DLdp8QbsYRy91gjbXTekaukJ12hCpZyray9lWQ+KDTNR6r2glWAXzCK01WJhhQ C78wYm5zUSkKxycr8JLz4085wCp2LioHeaMJjsU72JiZTSlYBGmgoAtJWtMXuvC4BFlc sVXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BcDtMGm8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si4809532pgj.258.2019.05.24.08.25.21; Fri, 24 May 2019 08:25:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BcDtMGm8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389543AbfEXPWf (ORCPT + 99 others); Fri, 24 May 2019 11:22:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:40694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389079AbfEXPWf (ORCPT ); Fri, 24 May 2019 11:22:35 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB1F920856; Fri, 24 May 2019 15:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558711354; bh=ViTpW6GI0CL9YOoouzWE0UuX5Qv63XxO/4tkNZStyQw=; h=Date:From:To:cc:Subject:From; b=BcDtMGm8rMx+VJmzCszxg5mUqfg0vWC2dhlCKQsG9FeBoG3OwUzQKi3g1v1dR+epD dpaJIO458pJ65k+1IiLQi3uZiOj39Xj49r7+tkkeAehxykedr5uVLmaORuyjSs52gm 3XWAaGfbOgACCVQRfPHZ+8W67dRkISz0sMH8iFfE= Date: Fri, 24 May 2019 17:22:30 +0200 (CEST) From: Jiri Kosina To: Jens Axboe , Christoph Hellwig cc: Hannes Reinecke , Keith Busch , Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: [5.2-rc1 regression]: nvme vs. hibernation Message-ID: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Something is broken in Linus' tree (4dde821e429) with respec to hibernation on my thinkpad x270, and it seems to be nvme related. I reliably see the warning below during hibernation, and then sometimes resume sort of works but the machine misbehaves here and there (seems like lost IRQs), sometimes it never comes back from the hibernated state. I will not have too much have time to look into this over weekend, so I am sending this out as-is in case anyone has immediate idea. Otherwise I'll bisect it on monday (I don't even know at the moment what exactly was the last version that worked reliably, I'll have to figure that out as well later). WARNING: CPU: 0 PID: 363 at kernel/irq/chip.c:210 irq_startup+0xff/0x110 Modules linked in: bnep ccm af_packet fuse 8021q garp stp mrp llc tun ip6table_mangle ip6table_filter ip6_tables iptable_mangle xt_DSCP xt_tcpudp xt_conntrac snd_hda_core aes_x86_64 glue_helper crypto_simd snd_pcm cryptd e1000e ptp pcspkr joydev pps_core snd_timer i2c_i801 cfg80211 mei_me mei intel_pch_thermal th CPU: 0 PID: 363 Comm: kworker/u8:4 Not tainted 5.1.0-08122-ga2d635decbfa #9 Hardware name: LENOVO 20K5S22R00/20K5S22R00, BIOS R0IET38W (1.16 ) 05/31/2017 Workqueue: events_unbound async_run_entry_fn RIP: 0010:irq_startup+0xff/0x110 Code: f6 4c 89 e7 e8 92 34 00 00 85 c0 75 21 4c 89 e7 31 d2 4c 89 ee e8 e1 cc ff ff 48 89 df e8 89 fe ff ff 41 89 c4 e9 37 ff ff ff <0f> 0b eb b0 0f 0b eb ac 66 0f 1f 84 00 00 44 00 00 RSP: 0018:ffffa05100f13bd0 EFLAGS: 00010002 RAX: 0000000000000200 RBX: ffff9168e360ec00 RCX: 0000000000000200 RDX: 0000000000000200 RSI: ffffffff9f383600 RDI: ffff9168e360ec18 RBP: 0000000000000001 R08: 0000000000000000 R09: 0000000000000007 R10: 000000007a6a7b55 R11: 0000000000000000 R12: 0000000000000001 R13: ffff9168e360ec18 R14: ffff9168e6c97000 R15: ffff9168df76c000 FS: 0000000000000000(0000) GS:ffff9168e7280000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fc942c4bf60 CR3: 00000001f1210002 CR4: 00000000003606e0 Call Trace: ? __irq_get_desc_lock+0x4e/0x90 enable_irq+0x39/0x70 nvme_poll_irqdisable+0x3a3/0x470 [nvme] __nvme_disable_io_queues.isra.42+0x16a/0x1d0 [nvme] nvme_dev_disable+0x17e/0x1e0 [nvme] ? pci_pm_poweroff+0xf0/0xf0 nvme_suspend+0x13/0x20 [nvme] pci_pm_freeze+0x52/0xd0 dpm_run_callback+0x6b/0x2e0 __device_suspend+0x147/0x630 ? dpm_show_time+0xe0/0xe0 async_suspend+0x1a/0x90 async_run_entry_fn+0x39/0x160 process_one_work+0x1f0/0x5b0 ? process_one_work+0x16a/0x5b0 worker_thread+0x4c/0x3f0 kthread+0x103/0x140 ? process_one_work+0x5b0/0x5b0 ? kthread_bind+0x10/0x10 ret_from_fork+0x3a/0x50 irq event stamp: 381230 hardirqs last enabled at (381229): [] _raw_spin_unlock_irqrestore+0x4d/0x70 hardirqs last disabled at (381230): [] _raw_spin_lock_irqsave+0x24/0x60 softirqs last enabled at (381104): [] __iwl_mvm_mac_stop+0xa4/0x1a0 [iwlmvm] softirqs last disabled at (381102): [] iwl_mvm_async_handlers_purge+0x26/0xa0 [iwlmvm] -- Jiri Kosina SUSE Labs