Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp769775ybi; Fri, 24 May 2019 11:08:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFZcI6wOmL/wdj/TjZco4GOES9ZrYV4oxhlrfAoh5D052yrHZyL8Dd/Bz4OTQe++dZ/nUa X-Received: by 2002:a17:902:158b:: with SMTP id m11mr66843169pla.268.1558721315209; Fri, 24 May 2019 11:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558721315; cv=none; d=google.com; s=arc-20160816; b=m2AHl49DXpMMXnIgInIB/k4ReszQ+MY+r6iIekfAIS04HJOrZSgu0t+Xqvf/IaPodJ 9qpIMAth+iwV4Hg/g08PM7WCh4ziiRu6+PCxDpdZ9eWn5nuHf3MKJA8tJaZ9eFuMwqjR HUPjmC9C1r5cQj6iKKgnO2h2Pi+h2w0IY8kbjrwrTDIC0/ZrJlHKPg8xAV5vYIrrC0k1 fKhpaW5o2iuDWbW6lLofeTEC7Ga+baRIsOZ9sniEXd+y/jveNGXTmiRLE1SYbiQFPEHm 7ehXio1crfY+hdR8Xz8Eqj90SrnkxCHJVZI/7weiSlArUm3oky+Q2FQuEJ73VD6zTbrd 60xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-disposition:mime-version:references:in-reply-to:subject:cc :to:from:message-id:date:dkim-signature; bh=PcoTHdGaQs/oS0l0s0m+vBHryefQqzo0n8dHugWubO8=; b=vRYevVQO5iR8ahlJQR+WlKGTqvIpscMw6OvC4f7Ew+GsbMr7Foq9MlYkdsMcmgHNYY 3zpk0RQBuJb7vEOnJk/YdjnSEIJMrft3yiIKYbUHGOdN+/uiGCMfjU11Ojp3rbnn1wvh HeVvaNgbW7jCxqOMV0olDAFRpj5I25AETrBG9KifUM8wHVX4sFD7KrfaACHH4mRLtHoY 3vlzCrHOI3Q1WNPi2jUW1kmizc4VK1vbbxUQe/var0wXmkX7d/vNfHef5NbqvIZ1shmt bw3OO8gYNwnegq+J0dE6o3+oOy55+gdCF/Uoy8qGeigZ2QGHA2yUxrBLKvcVszY5usH0 PeLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NeXqS1Hv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r88si5042929pjb.15.2019.05.24.11.08.19; Fri, 24 May 2019 11:08:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NeXqS1Hv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731918AbfEXSFo (ORCPT + 99 others); Fri, 24 May 2019 14:05:44 -0400 Received: from mail-ua1-f67.google.com ([209.85.222.67]:33007 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbfEXSFo (ORCPT ); Fri, 24 May 2019 14:05:44 -0400 Received: by mail-ua1-f67.google.com with SMTP id 49so3952132uas.0; Fri, 24 May 2019 11:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=PcoTHdGaQs/oS0l0s0m+vBHryefQqzo0n8dHugWubO8=; b=NeXqS1HvsZSSQRUkTzNHSX6lYJlU04peNsF9phz9BtuIIDoB2w/XG1s+IBZ7NT1GDg L13UfZN1KSPpSTcnH2A1viXbsFRhEAqPmRyq06Dwq67zxoiwxhXW8ZXEnT8tpR5RDf7c uSlOGwi6YYKb909ek9RNaAUXDItdj7n51ZHznUCf9y8tauP4ZERUNpNjP4x9Pl/3NLE3 vJR8v6WY6ORryPQmElOTEAxwKm17hjLyrPJF/5t9EJ1TElx3J12ywmOcCijM+N7KYWhj KpLSZNYUhtmNKbgWJv61oXlKMsdz3uxYTpQoUxo9RWVs2xcOsM2pbCd55rVPcm44cP7K F+Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=PcoTHdGaQs/oS0l0s0m+vBHryefQqzo0n8dHugWubO8=; b=WR3QHzmK9SHo5sSVoAuo7u6TmOtNS9wwRjLySoHVpF37PXzRJb7/W+2qfSkW3AHX2S hoihr7GfxQfI94hxfkVUoJihhVlEIGEdNGpo909B7e9JhW2R7SeFMYQVNIAeyRS98Mc8 A7Mws6QzHIFQ7KWIFpo2pydOsCIaDJuh8r7SgtSPalsIzZ5AiyWWaplXkRhPt9MfGV8u 5nZ5z8s2B4w4ylnFIBbrKumOI+5w22byMxlK2d5U6LVtWgtqn90UDhETuylMatqZujjf KDrPGZDAzG6mbL1r3r2b0qibnRo7tOwLxI4YlP1vswZZioGsImwVhTxk0eUqAyq6Ag3J 6cmQ== X-Gm-Message-State: APjAAAVOUIKCL/Ov0EPHzIi2qi04BeHFBeGnpdZtHQy2d0pyvLDg9S9M WH8NGINSg1lyE0IQl5wVuZk= X-Received: by 2002:ab0:644d:: with SMTP id j13mr23523976uap.98.1558721143160; Fri, 24 May 2019 11:05:43 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id g41sm1889892uah.12.2019.05.24.11.05.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 11:05:42 -0700 (PDT) Date: Fri, 24 May 2019 14:05:41 -0400 Message-ID: <20190524140541.GH17138@t480s.localdomain> From: Vivien Didelot To: Rasmus Villemoes Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Rasmus Villemoes , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 4/5] net: dsa: mv88e6xxx: implement watchdog_ops for mv88e6250 In-Reply-To: <20190524085921.11108-5-rasmus.villemoes@prevas.dk> References: <20190501193126.19196-1-rasmus.villemoes@prevas.dk> <20190524085921.11108-1-rasmus.villemoes@prevas.dk> <20190524085921.11108-5-rasmus.villemoes@prevas.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 May 2019 09:00:29 +0000, Rasmus Villemoes wrote: > The MV88E6352_G2_WDOG_CTL_* bits almost, but not quite, describe the > watchdog control register on the mv88e6250. Among those actually > referenced in the code, only QC_ENABLE differs (bit 6 rather than bit > 5). > > Signed-off-by: Rasmus Villemoes Clean patch, Reviewed-by: Vivien Didelot Thanks, Vivien